gortiz commented on code in PR #15609:
URL: https://github.com/apache/pinot/pull/15609#discussion_r2073370059
##########
pinot-spi/src/main/java/org/apache/pinot/spi/utils/CommonConstants.java:
##########
@@ -1577,6 +1576,18 @@ public static class PlanVersions {
public static final String KEY_OF_MULTISTAGE_EXPLAIN_INCLUDE_SEGMENT_PLAN =
"pinot.query.multistage.explain.include.segment.plan";
public static final boolean
DEFAULT_OF_MULTISTAGE_EXPLAIN_INCLUDE_SEGMENT_PLAN = false;
+
+ /// Max number of rows operators stored in the op stats cache.
+ /// Although the cache stores stages, each entry has a weight equal to the
number of operators in the stage.
+ public static final String KEY_OF_OP_STATS_CACHE_MAX =
"pinot.server.query.op.stats.cache.max";
+ public static final int DEFAULT_OF_OP_STATS_CACHE_MAX = 1000;
+
+ /// Max time to keep the op stats in the cache.
+ public static final String KEY_OF_OP_STATS_CACHE_EXPIRE_MS =
"pinot.server.query.op.stats.cache.secs";
+ public static final int DEFAULT_OF_OP_STATS_CACHE_EXPIRE_MS = 10 * 60 *
1000;
Review Comment:
Fixed. AFAIU the main problem was the actual property name, but I'm also
changing the default to 1 min, given that should be good enough (specially when
we have a timeout of 1s for the cancellation mechanism)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
