vrajat commented on PR #15251:
URL: https://github.com/apache/pinot/pull/15251#issuecomment-2723492069
For some reason, this function is not being triggered by my changes in
`TimestampIndexMseTest`
```
protected void overrideBrokerConf(PinotConfiguration brokerConf) {
Stri
yashmayya commented on PR #15263:
URL: https://github.com/apache/pinot/pull/15263#issuecomment-2723467849
@ankitsultana the large `IN` clause compilation issue comes from two
sources. One is in certain optimization rules like
`CoreRules.FILTER_REDUCE_EXPRESSIONS` and `PinotSortExchangeNodeI
vrajat commented on PR #15251:
URL: https://github.com/apache/pinot/pull/15251#issuecomment-2723348775
Once again the individual test passes on my laptop. Investigating
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
somandal commented on code in PR #15175:
URL: https://github.com/apache/pinot/pull/15175#discussion_r1994318189
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/DefaultRebalancePreChecker.java:
##
@@ -138,4 +157,80 @@ private boolean checkIsMini
J-HowHuang commented on code in PR #15175:
URL: https://github.com/apache/pinot/pull/15175#discussion_r1994421697
##
pinot-controller/src/test/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancerClusterStatelessTest.java:
##
@@ -513,6 +533,106 @@ public void tes
J-HowHuang commented on code in PR #15175:
URL: https://github.com/apache/pinot/pull/15175#discussion_r1994387762
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/DefaultRebalancePreChecker.java:
##
@@ -138,4 +157,80 @@ private boolean checkIsMi
somandal commented on code in PR #15175:
URL: https://github.com/apache/pinot/pull/15175#discussion_r1994381252
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/DefaultRebalancePreChecker.java:
##
@@ -138,4 +157,80 @@ private boolean checkIsMini
codecov-commenter commented on PR #15268:
URL: https://github.com/apache/pinot/pull/15268#issuecomment-2723023524
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/15268?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u
vrajat commented on PR #15251:
URL: https://github.com/apache/pinot/pull/15251#issuecomment-2722971180
Now it's passed the window test. It's in TimestampMSE related test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
deepthi912 opened a new pull request, #15268:
URL: https://github.com/apache/pinot/pull/15268
The consumption for slow replicas should be disabled in all of the following
scenarios when replacing the consuming segments:
1. Partial Upserts
2. Dedup Tables
3. Full Upserts with Drop
somandal commented on code in PR #15175:
URL: https://github.com/apache/pinot/pull/15175#discussion_r1994442520
##
pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/OfflineClusterIntegrationTest.java:
##
@@ -878,9 +878,10 @@ private void checkRebalancePreC
somandal commented on code in PR #15175:
URL: https://github.com/apache/pinot/pull/15175#discussion_r1994440367
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/DefaultRebalancePreChecker.java:
##
@@ -42,19 +47,28 @@ public class DefaultRebalanc
J-HowHuang commented on code in PR #15175:
URL: https://github.com/apache/pinot/pull/15175#discussion_r1994431306
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/DefaultRebalancePreChecker.java:
##
@@ -42,19 +47,28 @@ public class DefaultRebala
J-HowHuang commented on code in PR #15175:
URL: https://github.com/apache/pinot/pull/15175#discussion_r1994424450
##
pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/OfflineClusterIntegrationTest.java:
##
@@ -878,9 +878,10 @@ private void checkRebalancePr
J-HowHuang commented on code in PR #15175:
URL: https://github.com/apache/pinot/pull/15175#discussion_r1994392642
##
pinot-controller/src/test/java/org/apache/pinot/controller/helix/ControllerTest.java:
##
@@ -227,6 +227,8 @@ public Map
getDefaultControllerConfiguration() {
J-HowHuang commented on code in PR #15175:
URL: https://github.com/apache/pinot/pull/15175#discussion_r1994392642
##
pinot-controller/src/test/java/org/apache/pinot/controller/helix/ControllerTest.java:
##
@@ -227,6 +227,8 @@ public Map
getDefaultControllerConfiguration() {
codecov-commenter commented on PR #15267:
URL: https://github.com/apache/pinot/pull/15267#issuecomment-2722795432
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/15267?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u
rajagopr commented on code in PR #15257:
URL: https://github.com/apache/pinot/pull/15257#discussion_r1994344588
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/retention/RetentionManager.java:
##
@@ -165,6 +183,85 @@ private void manageRetentionForRealti
rajagopr commented on code in PR #15257:
URL: https://github.com/apache/pinot/pull/15257#discussion_r1994358106
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/retention/RetentionManager.java:
##
@@ -165,6 +183,85 @@ private void manageRetentionForRealti
somandal commented on code in PR #15175:
URL: https://github.com/apache/pinot/pull/15175#discussion_r1994319736
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/DefaultRebalancePreChecker.java:
##
@@ -138,4 +157,80 @@ private boolean checkIsMini
J-HowHuang commented on code in PR #15175:
URL: https://github.com/apache/pinot/pull/15175#discussion_r1994313176
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/DefaultRebalancePreChecker.java:
##
@@ -138,4 +157,80 @@ private boolean checkIsMi
npawar opened a new pull request, #15267:
URL: https://github.com/apache/pinot/pull/15267
Experimenting with adding PreEnricher. The current RecordEnricher
Transformer is after complex transformer, and doesn't allow enrichment before
unnest
--
This is an automated message from the Apache
somandal commented on code in PR #15175:
URL: https://github.com/apache/pinot/pull/15175#discussion_r1994287916
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/DefaultRebalancePreChecker.java:
##
@@ -42,19 +47,28 @@ public class DefaultRebalanc
somandal commented on code in PR #15175:
URL: https://github.com/apache/pinot/pull/15175#discussion_r1994318189
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/DefaultRebalancePreChecker.java:
##
@@ -138,4 +157,80 @@ private boolean checkIsMini
somandal commented on code in PR #15175:
URL: https://github.com/apache/pinot/pull/15175#discussion_r1994283360
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/DefaultRebalancePreChecker.java:
##
@@ -138,4 +157,80 @@ private boolean checkIsMini
J-HowHuang commented on code in PR #15175:
URL: https://github.com/apache/pinot/pull/15175#discussion_r1994312270
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/DefaultRebalancePreChecker.java:
##
@@ -138,4 +157,80 @@ private boolean checkIsMi
J-HowHuang commented on code in PR #15175:
URL: https://github.com/apache/pinot/pull/15175#discussion_r1994280527
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/DefaultRebalancePreChecker.java:
##
@@ -138,4 +157,80 @@ private boolean checkIsMi
klsince commented on code in PR #15175:
URL: https://github.com/apache/pinot/pull/15175#discussion_r1994254289
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/DefaultRebalancePreChecker.java:
##
@@ -138,4 +157,80 @@ private boolean checkIsMinim
ankitsultana commented on PR #15263:
URL: https://github.com/apache/pinot/pull/15263#issuecomment-2722594049
@yashmayya : I suppose you folks must have considered this already, but for
the large IN clause optimization, have you folks thought of rewriting the IN to
a UDF in perhaps the first
codecov-commenter commented on PR #15266:
URL: https://github.com/apache/pinot/pull/15266#issuecomment-2722572008
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/15266?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u
codecov-commenter commented on PR #15265:
URL: https://github.com/apache/pinot/pull/15265#issuecomment-2722469854
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/15265?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u
somandal opened a new pull request, #15266:
URL: https://github.com/apache/pinot/pull/15266
This PR enhances the Table Rebalance progress stats.
It adds the following to the existing progress stats:
```
"rebalanceProgressStatsOverall" : {
"_totalSegmentsToBeAdded" :
jayeshchoudhary commented on code in PR #15256:
URL: https://github.com/apache/pinot/pull/15256#discussion_r1993632588
##
pinot-controller/src/main/resources/app/components/Homepage/Operations/RebalanceServer/RebalanceServerOptions.ts:
##
@@ -0,0 +1,145 @@
+export type Rebalance
ankitsultana commented on code in PR #15265:
URL: https://github.com/apache/pinot/pull/15265#discussion_r1994147929
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/assignment/segment/strategy/custom/ZoneAwareSegmentAssignmentStrategy.java:
##
@@ -0,0 +1,
zeronerdzerogeekzerocool opened a new pull request, #15265:
URL: https://github.com/apache/pinot/pull/15265
Instructions:
1. The PR has to be tagged with at least one of the following labels (*):
1. `feature`
2. `bugfix`
3. `performance`
4. `ui`
5. `backward-i
somandal commented on code in PR #15233:
URL: https://github.com/apache/pinot/pull/15233#discussion_r1994112946
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/DefaultRebalancePreChecker.java:
##
@@ -105,37 +102,87 @@ private Boolean checkReloa
somandal commented on code in PR #15233:
URL: https://github.com/apache/pinot/pull/15233#discussion_r1994112679
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/RebalancePreCheckerResult.java:
##
@@ -0,0 +1,80 @@
+/**
+ * Licensed to the Apache
klsince commented on code in PR #15233:
URL: https://github.com/apache/pinot/pull/15233#discussion_r1994077071
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/RebalancePreCheckerResult.java:
##
@@ -0,0 +1,80 @@
+/**
+ * Licensed to the Apache S
swaminathanmanish commented on code in PR #15257:
URL: https://github.com/apache/pinot/pull/15257#discussion_r1994032068
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/retention/RetentionManager.java:
##
@@ -165,6 +183,85 @@ private void manageRetention
klsince commented on code in PR #15110:
URL: https://github.com/apache/pinot/pull/15110#discussion_r1994044837
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/assignment/instance/InstanceAssignmentDriver.java:
##
@@ -55,40 +55,66 @@ public InstanceAssign
cbalci commented on PR #12570:
URL: https://github.com/apache/pinot/pull/12570#issuecomment-2722095648
@jitendrakr88 can you propose a test case if you need this faster? We can
merge it quicker then.
--
This is an automated message from the Apache Git Service.
To respond to the message, p
codecov-commenter commented on PR #15264:
URL: https://github.com/apache/pinot/pull/15264#issuecomment-2722011874
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/15264?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u
vrajat commented on PR #15251:
URL: https://github.com/apache/pinot/pull/15251#issuecomment-2721957329
Oh - I think I know why. Since it is part of suite, the cluster was setup
before the config was setup.
--
This is an automated message from the Apache Git Service.
To respond to the mes
vrajat commented on PR #15251:
URL: https://github.com/apache/pinot/pull/15251#issuecomment-2721672985
I changed the test to not use casts. However it is still failing with
different error. Something about the test env in the github runners and my
laptop is different. It is not creating the
gortiz commented on code in PR #15180:
URL: https://github.com/apache/pinot/pull/15180#discussion_r1991807637
##
pinot-spi/src/main/java/org/apache/pinot/spi/utils/CommonConstants.java:
##
@@ -1357,9 +1358,22 @@ public static class ServerResponseStatus {
}
public static
ankitsultana merged PR #15225:
URL: https://github.com/apache/pinot/pull/15225
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
albertobastos opened a new pull request, #15264:
URL: https://github.com/apache/pinot/pull/15264
For observability purposes, all incoming queries will be now logged also at
the start of the request processing and not only after a response has been
obtained (or some failure occurred). This w
codecov-commenter commented on PR #15263:
URL: https://github.com/apache/pinot/pull/15263#issuecomment-2721649130
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/15263?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u
ankitsultana commented on code in PR #15225:
URL: https://github.com/apache/pinot/pull/15225#discussion_r1993730497
##
pinot-query-planner/src/main/java/org/apache/pinot/calcite/rel/rules/PinotTableScanConverterRule.java:
##
@@ -0,0 +1,46 @@
+/**
+ * Licensed to the Apache Softw
jayeshchoudhary commented on code in PR #15256:
URL: https://github.com/apache/pinot/pull/15256#discussion_r1993636663
##
pinot-controller/src/main/resources/app/components/Homepage/Operations/RebalanceServer/RebalanceServerConfigurationOptions/RebalanceServerConfigurationOptionInteger.
jayeshchoudhary commented on code in PR #15256:
URL: https://github.com/apache/pinot/pull/15256#discussion_r1993636663
##
pinot-controller/src/main/resources/app/components/Homepage/Operations/RebalanceServer/RebalanceServerConfigurationOptions/RebalanceServerConfigurationOptionInteger.
jayeshchoudhary commented on PR #15256:
URL: https://github.com/apache/pinot/pull/15256#issuecomment-2721426146
> https://private-user-images.githubusercontent.com/30361728/422021231-f35b6b18-3adf-4d1b-9004-9a1dfb37381b.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29t
jayeshchoudhary commented on code in PR #15256:
URL: https://github.com/apache/pinot/pull/15256#discussion_r1993632588
##
pinot-controller/src/main/resources/app/components/Homepage/Operations/RebalanceServer/RebalanceServerOptions.ts:
##
@@ -0,0 +1,145 @@
+export type Rebalance
jayeshchoudhary commented on code in PR #15256:
URL: https://github.com/apache/pinot/pull/15256#discussion_r1993631824
##
pinot-controller/src/main/resources/app/components/Homepage/Operations/RebalanceServer/RebalanceServerOptions.ts:
##
@@ -0,0 +1,145 @@
+export type Rebalance
r-reis opened a new issue, #15262:
URL: https://github.com/apache/pinot/issues/15262
I'm trying to use pinot stream Kafka data, but the schema registry from
Confluent only works for Avro and Protobuf.
JSON messages work as long as you do not use the JSON schema.
How to reproduce t
gortiz merged PR #15240:
URL: https://github.com/apache/pinot/pull/15240
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apach
This is an automated email from the ASF dual-hosted git repository.
gortiz pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new e49026c8d0 Consolidate Auth and Validation in SSE
gortiz commented on code in PR #15225:
URL: https://github.com/apache/pinot/pull/15225#discussion_r1993579054
##
pinot-query-planner/src/main/java/org/apache/pinot/calcite/rel/rules/PinotTableScanConverterRule.java:
##
@@ -0,0 +1,46 @@
+/**
+ * Licensed to the Apache Software Fo
gortiz merged PR #15260:
URL: https://github.com/apache/pinot/pull/15260
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apach
gortiz commented on code in PR #15254:
URL: https://github.com/apache/pinot/pull/15254#discussion_r1993551675
##
pinot-common/src/main/java/org/apache/pinot/common/metrics/ServerMeter.java:
##
@@ -148,6 +148,15 @@ public enum ServerMeter implements AbstractMetrics.Meter {
*
This is an automated email from the ASF dual-hosted git repository.
gortiz pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 35bb12a230 Add tests for DUAL as well as non-comp
swaminathanmanish commented on code in PR #15142:
URL: https://github.com/apache/pinot/pull/15142#discussion_r1993358381
##
pinot-spi/src/main/java/org/apache/pinot/spi/config/table/SegmentsValidationAndRetentionConfig.java:
##
@@ -55,6 +55,8 @@ public class SegmentsValidationAn
noob-se7en commented on code in PR #15261:
URL: https://github.com/apache/pinot/pull/15261#discussion_r1993424037
##
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeSegmentDataManager.java:
##
@@ -1063,12 +1063,7 @@ AtomicBoolean getAcquiredConsumerS
noob-se7en opened a new pull request, #15261:
URL: https://github.com/apache/pinot/pull/15261
Instructions:
1. The PR has to be tagged with at least one of the following labels (*):
1. `feature`
2. `bugfix`
3. `performance`
4. `ui`
5. `backward-incompat`
albertobastos commented on code in PR #15254:
URL: https://github.com/apache/pinot/pull/15254#discussion_r1993208222
##
pinot-core/src/main/java/org/apache/pinot/core/operator/combine/GroupByCombineOperator.java:
##
@@ -123,6 +124,7 @@ protected void processSegments() {
codecov-commenter commented on PR #15260:
URL: https://github.com/apache/pinot/pull/15260#issuecomment-2720784838
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/15260?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u
vrajat commented on code in PR #15260:
URL: https://github.com/apache/pinot/pull/15260#discussion_r1993165097
##
pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/MultiStageEngineIntegrationTest.java:
##
@@ -327,6 +327,24 @@ public void testMultiValueColum
vrajat commented on PR #15251:
URL: https://github.com/apache/pinot/pull/15251#issuecomment-2720673707
Confused. Passed with mvn on my laptop as well.
```
mvn test -Dsurefire.failIfNoSpecifiedTests=false
-Dtest="WindowResourceAccountingTest"
15:32:02.386 WARN [CustomDat
vrajat commented on code in PR #15260:
URL: https://github.com/apache/pinot/pull/15260#discussion_r1993153553
##
pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/MultiStageEngineIntegrationTest.java:
##
@@ -327,6 +327,24 @@ public void testMultiValueColum
yashmayya commented on code in PR #15260:
URL: https://github.com/apache/pinot/pull/15260#discussion_r1993148486
##
pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/MultiStageEngineIntegrationTest.java:
##
@@ -327,6 +327,24 @@ public void testMultiValueCo
vrajat commented on PR #15251:
URL: https://github.com/apache/pinot/pull/15251#issuecomment-2720629715
> can you fix the integration test?
>
> ```
> WindowResourceAccountingTest.testFunnel:72 ClassCast class
org.apache.pinot.spi.trace.Tracing$DefaultThreadResourceUsageAccountant c
jitendrakr88 commented on PR #12570:
URL: https://github.com/apache/pinot/pull/12570#issuecomment-2720592145
Hi @vytautas-karpavicius @cbalci @Jackie-Jiang ,
Would it be possible to expedite this? we need it for an internal issue.
Thanks!
--
This is an automated message from the
vrajat opened a new pull request, #15260:
URL: https://github.com/apache/pinot/pull/15260
Dual behaviour in SSE is non-compliant. However the non-compliant query
`select 1 from unknownTable` is used in production. This PR adds tests to
detect changes that may change this non-compliant SQL
KKcorps commented on code in PR #15246:
URL: https://github.com/apache/pinot/pull/15246#discussion_r1992960831
##
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeSegmentDataManager.java:
##
@@ -1719,6 +1728,42 @@ public RealtimeSegmentDataManager(Seg
xiangfu0 commented on PR #15251:
URL: https://github.com/apache/pinot/pull/15251#issuecomment-2720564010
can you fix the integration test?
```
WindowResourceAccountingTest.testFunnel:72 ClassCast class
org.apache.pinot.spi.trace.Tracing$DefaultThreadResourceUsageAccountant cannot
be
krishan1390 commented on code in PR #15244:
URL: https://github.com/apache/pinot/pull/15244#discussion_r1992960652
##
pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/MultiStageEngineIntegrationTest.java:
##
@@ -1596,6 +1606,32 @@ public void testNumServe
noob-se7en commented on code in PR #15250:
URL: https://github.com/apache/pinot/pull/15250#discussion_r1992966695
##
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/utils/SegmentPreloadUtils.java:
##
@@ -191,4 +195,36 @@ private static Map
getSegmentsZKMetadata
77 matches
Mail list logo
