gortiz commented on code in PR #15180: URL: https://github.com/apache/pinot/pull/15180#discussion_r1991807637
########## pinot-spi/src/main/java/org/apache/pinot/spi/utils/CommonConstants.java: ########## @@ -1357,9 +1358,22 @@ public static class ServerResponseStatus { } public static class Query { + + /** + * Configuration keys for query context mode. + * + * Valid values are 'strict' (ignoring case) or empty. + * + * In strict mode, if the {@link QueryThreadContext} is not initialized, an {@link IllegalStateException} will be + * thrown when setter and getter methods are used. Otherwise a warning will be logged and the fake instance will be + * returned. + */ + public static final String CONFIG_OF_QUERY_CONTEXT_MODE = "pinot.query.context.mode"; Review Comment: I think it is the other way around. Asserts are turned off by default and turned on in tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org