yashmayya commented on code in PR #15260:
URL: https://github.com/apache/pinot/pull/15260#discussion_r1993148486
##########
pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/MultiStageEngineIntegrationTest.java:
##########
@@ -327,6 +327,24 @@ public void testMultiValueColumnAggregationQuery(boolean
useMultiStageQueryEngin
Assert.assertTrue(jsonNode.get("resultTable").get("rows").get(0).get(0).asDouble()
< 17000);
}
+ @Test(dataProvider = "useBothQueryEngines")
Review Comment:
Why is this testing both query engines if it is in the MSE's integration
test class?
##########
pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/MultiStageEngineIntegrationTest.java:
##########
@@ -327,6 +327,24 @@ public void testMultiValueColumnAggregationQuery(boolean
useMultiStageQueryEngin
Assert.assertTrue(jsonNode.get("resultTable").get("rows").get(0).get(0).asDouble()
< 17000);
}
+ @Test(dataProvider = "useBothQueryEngines")
+ void testDual(boolean useMultiStageQueryEngine)
Review Comment:
Just to clarify, we don't actually have the concept of a `DUAL` table in
Pinot right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
