KKcorps commented on code in PR #15246:
URL: https://github.com/apache/pinot/pull/15246#discussion_r1992960831


##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeSegmentDataManager.java:
##########
@@ -1719,6 +1728,42 @@ public RealtimeSegmentDataManager(SegmentZKMetadata 
segmentZKMetadata, TableConf
     }
   }
 
+  private boolean allowConsumptionDuringCommit() {
+    if (_realtimeTableDataManager.isDedupEnabled()) {

Review Comment:
   @klsince does simply adding this solve the inconsistency issue with dedup 
during segment download or not?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to