yashmayya opened a new pull request, #13933:
URL: https://github.com/apache/pinot/pull/13933
- https://github.com/apache/pinot/pull/13922/#discussion_r1742779113
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new d411f34b86 Remove unnecessary plugin version over
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new b66efb8284 Move schema related tests to pinot-spi
Jackie-Jiang merged PR #13929:
URL: https://github.com/apache/pinot/pull/13929
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
9aman closed pull request #13927: Basic changes on server and controller side
to introduce pauseless co…
URL: https://github.com/apache/pinot/pull/13927
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
jadami10 commented on PR #13879:
URL: https://github.com/apache/pinot/pull/13879#issuecomment-2327888469
> We do have a check in `TimeValidationTransformer` to check if the time
value is in valid range. Can you double check why it is not triggered since you
don't have `continueOnError` set
Jackie-Jiang commented on code in PR #13835:
URL: https://github.com/apache/pinot/pull/13835#discussion_r1742857916
##
pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/index/startree/AggregationFunctionColumn.java:
##
@@ -127,9 +149,14 @@ public boolean equals(Object
Jackie-Jiang commented on code in PR #13891:
URL: https://github.com/apache/pinot/pull/13891#discussion_r1742841062
##
pom.xml:
##
@@ -1579,17 +1580,6 @@
${scala.version}
-
Review Comment:
Suggest keeping it as is and only override the version in kaf
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new f50f321f05 Expose Get Segments/Table Config Chang
Jackie-Jiang merged PR #13915:
URL: https://github.com/apache/pinot/pull/13915
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
This is an automated email from the ASF dual-hosted git repository.
xiangfu pushed a commit to branch new-site-dev
in repository https://gitbox.apache.org/repos/asf/pinot-site.git
The following commit(s) were added to refs/heads/new-site-dev by this push:
new 8e5b2760 Add Blurb for Uber blo
xiangfu0 merged PR #134:
URL: https://github.com/apache/pinot-site/pull/134
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.ap
codecov-commenter commented on PR #13932:
URL: https://github.com/apache/pinot/pull/13932#issuecomment-2327629951
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/13932?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u
Jackie-Jiang opened a new pull request, #13932:
URL: https://github.com/apache/pinot/pull/13932
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
deepthi912 commented on PR #13915:
URL: https://github.com/apache/pinot/pull/13915#issuecomment-2327571584
getReloadCheckResponses, made this method public.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
Jackie-Jiang commented on PR #13915:
URL: https://github.com/apache/pinot/pull/13915#issuecomment-2327564895
I don't fully follow. Currently this PR becomes a pure refactor without
adding public method
--
This is an automated message from the Apache Git Service.
To respond to the message,
Jackie-Jiang commented on issue #13833:
URL: https://github.com/apache/pinot/issues/13833#issuecomment-2327562832
Can you share the star-tree index config? There should be no scan if the
dimension is properly split. The split dimension is sorted, thus binary search
is applied instead of sca
Jackie-Jiang commented on code in PR #13922:
URL: https://github.com/apache/pinot/pull/13922#discussion_r1742779113
##
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/HashJoinOperator.java:
##
@@ -307,7 +303,7 @@ private TransferableBlock buildJoinedDat
deepthi912 commented on code in PR #13915:
URL: https://github.com/apache/pinot/pull/13915#discussion_r1742773173
##
pinot-controller/src/main/java/org/apache/pinot/controller/util/TableMetadataReader.java:
##
@@ -60,21 +60,28 @@ public TableMetadataReader(Executor executor,
Ht
deepthi912 commented on PR #13915:
URL: https://github.com/apache/pinot/pull/13915#issuecomment-2327549775
Do you want to add a new method boolean isReloadNeeded()?
Re: I am thinking to extract boolean in the integration with the server
responses.
--
This is an automated message from t
deepthi912 commented on code in PR #13915:
URL: https://github.com/apache/pinot/pull/13915#discussion_r1742773173
##
pinot-controller/src/main/java/org/apache/pinot/controller/util/TableMetadataReader.java:
##
@@ -60,21 +60,28 @@ public TableMetadataReader(Executor executor,
Ht
Jackie-Jiang commented on code in PR #13915:
URL: https://github.com/apache/pinot/pull/13915#discussion_r1742764772
##
pinot-controller/src/main/java/org/apache/pinot/controller/util/TableMetadataReader.java:
##
@@ -60,21 +60,28 @@ public TableMetadataReader(Executor executor,
egalpin commented on PR #13742:
URL: https://github.com/apache/pinot/pull/13742#issuecomment-2327526039
@siddharthteotia @jackjlli @vvivekiyer Is there a specific order in which
different pinot components _must_ be restarted when performing an upgrade?
I can think of a smooth way to
egalpin commented on code in PR #13742:
URL: https://github.com/apache/pinot/pull/13742#discussion_r1742753156
##
pinot-core/src/main/java/org/apache/pinot/core/transport/AsyncQueryResponse.java:
##
@@ -50,21 +52,31 @@ public class AsyncQueryResponse implements QueryResponse {
deepthi912 commented on code in PR #13915:
URL: https://github.com/apache/pinot/pull/13915#discussion_r1742705976
##
pinot-controller/src/main/java/org/apache/pinot/controller/util/TableMetadataReader.java:
##
@@ -86,6 +86,16 @@ public JsonNode getSegmentsMetadata(String
tableN
deepthi912 commented on code in PR #13915:
URL: https://github.com/apache/pinot/pull/13915#discussion_r1739563818
##
pinot-controller/src/main/java/org/apache/pinot/controller/util/TableMetadataReader.java:
##
@@ -86,6 +86,16 @@ public JsonNode getSegmentsMetadata(String
tableN
gio-startree commented on PR #134:
URL: https://github.com/apache/pinot-site/pull/134#issuecomment-2327444158
> The author profile doesn't look correct. Are they included accidentally?
I have removed the content we don't use from their profile. It is a _legacy_
thing we were discussin
suvodeep-pyne commented on PR #13913:
URL: https://github.com/apache/pinot/pull/13913#issuecomment-2327274122
@swaminathanmanish
> Curious how you plan to extend this?
I'm not planning to extend the iterator. Rather I am trying to reach a
simple code path. One example enhancement
suvodeep-pyne commented on code in PR #13913:
URL: https://github.com/apache/pinot/pull/13913#discussion_r1742564600
##
pinot-plugins/pinot-input-format/pinot-csv/src/main/java/org/apache/pinot/plugin/inputformat/csv/CSVRecordReader.java:
##
@@ -202,158 +209,142 @@ public Map ge
suvodeep-pyne commented on code in PR #13913:
URL: https://github.com/apache/pinot/pull/13913#discussion_r1742552352
##
pinot-plugins/pinot-input-format/pinot-csv/src/main/java/org/apache/pinot/plugin/inputformat/csv/CSVRecordReader.java:
##
@@ -202,158 +209,142 @@ public Map ge
suvodeep-pyne commented on code in PR #13913:
URL: https://github.com/apache/pinot/pull/13913#discussion_r1742551019
##
pinot-plugins/pinot-input-format/pinot-csv/src/main/java/org/apache/pinot/plugin/inputformat/csv/CSVRecordReader.java:
##
@@ -202,158 +209,142 @@ public Map ge
suvodeep-pyne commented on code in PR #13913:
URL: https://github.com/apache/pinot/pull/13913#discussion_r1742547048
##
pinot-plugins/pinot-input-format/pinot-csv/src/main/java/org/apache/pinot/plugin/inputformat/csv/CSVRecordReader.java:
##
@@ -60,102 +61,119 @@ public class CS
suvodeep-pyne commented on code in PR #13913:
URL: https://github.com/apache/pinot/pull/13913#discussion_r1742543940
##
pinot-plugins/pinot-input-format/pinot-csv/src/main/java/org/apache/pinot/plugin/inputformat/csv/CSVRecordReader.java:
##
@@ -60,102 +61,119 @@ public class CS
suvodeep-pyne commented on code in PR #13913:
URL: https://github.com/apache/pinot/pull/13913#discussion_r1742543940
##
pinot-plugins/pinot-input-format/pinot-csv/src/main/java/org/apache/pinot/plugin/inputformat/csv/CSVRecordReader.java:
##
@@ -60,102 +61,119 @@ public class CS
Jackie-Jiang commented on code in PR #13837:
URL: https://github.com/apache/pinot/pull/13837#discussion_r1742484129
##
pinot-connectors/pinot-flink-connector/src/main/java/org/apache/pinot/connector/flink/sink/FlinkSegmentWriter.java:
##
@@ -124,12 +135,26 @@ public void init(Ta
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a change to branch
dependabot/maven/org.codehaus.mojo-buildnumber-maven-plugin-3.2.1
in repository https://gitbox.apache.org/repos/asf/pinot.git
was f99a2822fa Bump org.codehaus.mojo:buildnumber-maven-plugin
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new d9a0c7786d Bump org.codehaus.mojo:buildnumber-mav
Jackie-Jiang merged PR #13931:
URL: https://github.com/apache/pinot/pull/13931
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a change to branch dependabot/maven/org.yaml-snakeyaml-2.3
in repository https://gitbox.apache.org/repos/asf/pinot.git
was d3c13d2022 Bump org.yaml:snakeyaml from 2.2 to 2.3
The revisions that were on this br
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
from 240507bbe5 Bump com.puppycrawl.tools:checkstyle from 10.18.0 to
10.18.1 (#13926)
add c323ec1978 Bump org.yaml:sna
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a change to branch
dependabot/maven/com.puppycrawl.tools-checkstyle-10.18.1
in repository https://gitbox.apache.org/repos/asf/pinot.git
was 30c8f0c1ac Bump com.puppycrawl.tools:checkstyle from 10.18.0 to 10.1
Jackie-Jiang merged PR #13925:
URL: https://github.com/apache/pinot/pull/13925
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a change to branch
dependabot/maven/software.amazon.awssdk-bom-2.27.17
in repository https://gitbox.apache.org/repos/asf/pinot.git
was 1c3f70bb7c Bump software.amazon.awssdk:bom from 2.27.16 to 2.27.17
The r
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
from dffdb6bbdd Bump software.amazon.awssdk:bom from 2.27.16 to 2.27.17
(#13924)
add 240507bbe5 Bump com.puppycrawl.to
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a change to branch
dependabot/maven/com.microsoft.azure-msal4j-1.17.1
in repository https://gitbox.apache.org/repos/asf/pinot.git
was 8cc17840f5 Bump com.microsoft.azure:msal4j from 1.17.0 to 1.17.1
The revi
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new dffdb6bbdd Bump software.amazon.awssdk:bom from 2
Jackie-Jiang merged PR #13926:
URL: https://github.com/apache/pinot/pull/13926
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
Jackie-Jiang merged PR #13924:
URL: https://github.com/apache/pinot/pull/13924
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
from d008709064 Add OOM Protection Support for Multi-Stage Queries (#13598)
add 78be114fbf Bump com.microsoft.azure:msa
Jackie-Jiang merged PR #13923:
URL: https://github.com/apache/pinot/pull/13923
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
gio-startree opened a new pull request, #134:
URL: https://github.com/apache/pinot-site/pull/134
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe
gortiz commented on code in PR #13930:
URL: https://github.com/apache/pinot/pull/13930#discussion_r1742088636
##
pinot-spi/src/main/java/org/apache/pinot/spi/plugin/PluginManager.java:
##
@@ -229,22 +257,86 @@ private void initRecordReaderClassMap() {
/**
* Loads jars rec
gortiz commented on code in PR #13930:
URL: https://github.com/apache/pinot/pull/13930#discussion_r1742087623
##
pinot-spi/src/test/java/org/apache/pinot/spi/plugin/PluginManagerTest.java:
##
@@ -195,6 +199,116 @@ public void testBackwardCompatible() {
"org.apache.pinot
gortiz commented on code in PR #13930:
URL: https://github.com/apache/pinot/pull/13930#discussion_r1742084366
##
pinot-spi/src/test/java/org/apache/pinot/spi/plugin/PluginManagerTest.java:
##
@@ -195,6 +199,116 @@ public void testBackwardCompatible() {
"org.apache.pinot
rfscholte commented on code in PR #13930:
URL: https://github.com/apache/pinot/pull/13930#discussion_r1742076065
##
pinot-spi/src/main/java/org/apache/pinot/spi/plugin/PluginManager.java:
##
@@ -229,22 +257,86 @@ private void initRecordReaderClassMap() {
/**
* Loads jars
rfscholte commented on code in PR #13930:
URL: https://github.com/apache/pinot/pull/13930#discussion_r1742069989
##
pinot-spi/src/main/java/org/apache/pinot/spi/plugin/PluginManager.java:
##
@@ -229,22 +257,86 @@ private void initRecordReaderClassMap() {
/**
* Loads jars
gortiz commented on code in PR #13930:
URL: https://github.com/apache/pinot/pull/13930#discussion_r1742062595
##
pinot-spi/src/main/java/org/apache/pinot/spi/plugin/PluginManager.java:
##
@@ -229,22 +257,86 @@ private void initRecordReaderClassMap() {
/**
* Loads jars rec
gortiz commented on code in PR #13930:
URL: https://github.com/apache/pinot/pull/13930#discussion_r1742060140
##
pinot-spi/src/main/java/org/apache/pinot/spi/plugin/PluginManager.java:
##
@@ -229,22 +257,86 @@ private void initRecordReaderClassMap() {
/**
* Loads jars rec
gortiz commented on code in PR #13930:
URL: https://github.com/apache/pinot/pull/13930#discussion_r1742032478
##
pinot-spi/src/main/java/org/apache/pinot/spi/plugin/PluginManager.java:
##
@@ -229,22 +257,86 @@ private void initRecordReaderClassMap() {
/**
* Loads jars rec
gortiz commented on code in PR #13930:
URL: https://github.com/apache/pinot/pull/13930#discussion_r1742031724
##
pinot-spi/src/main/java/org/apache/pinot/spi/plugin/PluginManager.java:
##
@@ -229,22 +257,86 @@ private void initRecordReaderClassMap() {
/**
* Loads jars rec
rfscholte commented on PR #13907:
URL: https://github.com/apache/pinot/pull/13907#issuecomment-2326339893
Superseded by https://github.com/apache/pinot/pull/13930
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
rfscholte closed pull request #13907: pinot plugin loader
URL: https://github.com/apache/pinot/pull/13907
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a change to branch
dependabot/maven/org.codehaus.mojo-buildnumber-maven-plugin-3.2.1
in repository https://gitbox.apache.org/repos/asf/pinot.git
at f99a2822fa Bump org.codehaus.mojo:buildnumber-maven-plu
dependabot[bot] opened a new pull request, #13931:
URL: https://github.com/apache/pinot/pull/13931
Bumps
[org.codehaus.mojo:buildnumber-maven-plugin](https://github.com/mojohaus/buildnumber-maven-plugin)
from 3.2.0 to 3.2.1.
Release notes
Sourced from https://github.com/mojohaus/b
codecov-commenter commented on PR #13930:
URL: https://github.com/apache/pinot/pull/13930#issuecomment-2326291206
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/13930?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u
shounakmk219 commented on code in PR #13584:
URL: https://github.com/apache/pinot/pull/13584#discussion_r1741836921
##
pinot-common/src/main/java/org/apache/pinot/common/metrics/ControllerGauge.java:
##
@@ -160,7 +160,8 @@ public enum ControllerGauge implements
AbstractMetrics.
shounakmk219 commented on PR #13584:
URL: https://github.com/apache/pinot/pull/13584#issuecomment-2326191290
Hey @mcvsubbu @sajjad-moradi I have updated the PR with the changes from
PauseState PR and also removed the storage quota check from segment commit
process and now only have it as pa
rfscholte opened a new pull request, #13930:
URL: https://github.com/apache/pinot/pull/13930
With classrealms there will be much more control over the classloaders.
Next to the shaded plugins, a plugin-directory may contain a
pinot-plugin.properties (to switch from PluginClassloader to Cl
abhioncbr closed issue #13008: [Flaky test]: PulsarConsumerTest,
testPartitionLevelConsumerBatchMessages
URL: https://github.com/apache/pinot/issues/13008
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
abhioncbr closed issue #13764: Bump avro.version from 1.11.3 to 1.12.0
URL: https://github.com/apache/pinot/issues/13764
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsu
abhioncbr commented on issue #13764:
URL: https://github.com/apache/pinot/issues/13764#issuecomment-2326085021
We decided not to upgrade the version because of some reported issues with
Avro primitive array support. closing this issue. Thanks
--
This is an automated message from the Apach
vrajat commented on PR #13650:
URL: https://github.com/apache/pinot/pull/13650#issuecomment-2325998240
Lets abandon. I'll add implicit tests in `pg-test-suite` project and then we
can take a call based on the results of the compatibility tests.
--
This is an automated message from the Ap
vrajat closed pull request #13650: Disable Implicit Cast of Varchar to Int in
Multi-Stage engine
URL: https://github.com/apache/pinot/pull/13650
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
This is an automated email from the ASF dual-hosted git repository.
gortiz pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new d008709064 Add OOM Protection Support for Multi-S
gortiz merged PR #13598:
URL: https://github.com/apache/pinot/pull/13598
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apach
vrajat commented on PR #13598:
URL: https://github.com/apache/pinot/pull/13598#issuecomment-2325991568
Test failure is unrelated. Looks like a flaky test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
gortiz commented on PR #13845:
URL: https://github.com/apache/pinot/pull/13845#issuecomment-232586
I'm going to close this PR because Robert has been focused on
https://github.com/apache/pinot/pull/13907, which also includes the new plugin
layout and simplifies the logic here
--
This
gortiz closed pull request #13845: Introduce Plexus ClassWorld for more control
over the classloaders
URL: https://github.com/apache/pinot/pull/13845
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
78 matches
Mail list logo
