rfscholte opened a new pull request, #13930:
URL: https://github.com/apache/pinot/pull/13930
With classrealms there will be much more control over the classloaders.
Next to the shaded plugins, a plugin-directory may contain a
pinot-plugin.properties (to switch from PluginClassloader to ClassRealms).
if there is no `pinot-plugin.properties`, the original behavior is used.
if there is a `pinot-plugin.properties`, a classrealm will be created: every
direct file or directory in the plugin-directory will be added to the
classrealm.
It is possible to let shaded plugins use a classrealm. In that case the
classes in the shaded jar will be loaded before the system classloader (as done
by the PluginLoader).
this implementation doesn't unpack plugin-zips as created with the assembly
descriptor. Instead is assumes it is unpacked before pinot starts.
Instructions:
1. The PR has to be tagged with at least one of the following labels (*):
1. `feature`
2. `bugfix`
3. `performance`
4. `ui`
5. `backward-incompat`
6. `release-notes` (**)
2. Remove these instructions before publishing the PR.
(*) Other labels to consider:
- `testing`
- `dependencies`
- `docker`
- `kubernetes`
- `observability`
- `security`
- `code-style`
- `extension-point`
- `refactor`
- `cleanup`
(**) Use `release-notes` label for scenarios like:
- New configuration options
- Deprecation of configurations
- Signature changes to public methods/interfaces
- New plugins added or old plugins removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
