Re: [PR] [partial-upsert] configure early release of _partitionGroupConsumerSemaphore in RealtimeSegmentDataManager [pinot]

2024-06-13 Thread via GitHub
rohityadav1993 commented on PR #13256: URL: https://github.com/apache/pinot/pull/13256#issuecomment-2167355537 Removed unnecessary changes in the QuickStartRunner.java which got pushed by mistake in the previous commit. -- This is an automated message from the Apache Git Service. To respo

Re: [PR] track segments for snapshotting even if they lost all comparisons [pinot]

2024-06-13 Thread via GitHub
tibrewalpratik17 commented on code in PR #13388: URL: https://github.com/apache/pinot/pull/13388#discussion_r1639341763 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/BasePartitionUpsertMetadataManager.java: ## @@ -933,7 +943,6 @@ protected void doTak

Re: [PR] add unit test for StringFunctions encodeUrl [pinot]

2024-06-13 Thread via GitHub
codecov-commenter commented on PR #13391: URL: https://github.com/apache/pinot/pull/13391#issuecomment-2167132820 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/13391?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

[PR] add unit test for StringFunctions encodeUrl [pinot]

2024-06-13 Thread via GitHub
sullis opened a new pull request, #13391: URL: https://github.com/apache/pinot/pull/13391 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mai

Re: [PR] Avoid port conflict in integration tests [pinot]

2024-06-13 Thread via GitHub
codecov-commenter commented on PR #13390: URL: https://github.com/apache/pinot/pull/13390#issuecomment-2167031982 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/13390?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

[PR] Avoid port conflict in integration tests [pinot]

2024-06-13 Thread via GitHub
Jackie-Jiang opened a new pull request, #13390: URL: https://github.com/apache/pinot/pull/13390 - Assign port in a deterministic way to avoid port conflict in the integration tests - Assign port when creating the instance config - Controller port starts with 16000; Broker 17000; Server

Re: [PR] Refactored compatibility-verifier module [pinot]

2024-06-13 Thread via GitHub
Jackie-Jiang commented on PR #13359: URL: https://github.com/apache/pinot/pull/13359#issuecomment-2166985865 I took a look at the compatibility test run, and didn't see any log from `BaseOp`. Is this expected? -- This is an automated message from the Apache Git Service. To respond to the

(pinot) branch master updated: Fix segment size check in OfflineClusterIntegrationTest (#13389)

2024-06-13 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 7571f711b8 Fix segment size check in OfflineClust

Re: [PR] Fix segment size check in OfflineClusterIntegrationTest [pinot]

2024-06-13 Thread via GitHub
Jackie-Jiang merged PR #13389: URL: https://github.com/apache/pinot/pull/13389 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

Re: [PR] Fix segment size check in OfflineClusterIntegrationTest [pinot]

2024-06-13 Thread via GitHub
codecov-commenter commented on PR #13389: URL: https://github.com/apache/pinot/pull/13389#issuecomment-2166931380 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/13389?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

(pinot) branch master updated (a564b7f36d -> 030f1b00e2)

2024-06-13 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from a564b7f36d Bump com.google.cloud:libraries-bom from 26.40.0 to 26.41.0 (#13385) add 030f1b00e2 Add clickstream e

Re: [PR] Add clickstream example table for funnel analysis [pinot]

2024-06-13 Thread via GitHub
xiangfu0 merged PR #13379: URL: https://github.com/apache/pinot/pull/13379 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apa

Re: [PR] add `skipUnavailableServers` query option [pinot]

2024-06-13 Thread via GitHub
itschrispeck commented on code in PR #13387: URL: https://github.com/apache/pinot/pull/13387#discussion_r1639016799 ## pinot-core/src/test/java/org/apache/pinot/core/transport/QueryRoutingTest.java: ## @@ -286,6 +293,89 @@ public void testServerDown() assertEquals(_serverR

[PR] Fix segment size check in OfflineClusterIntegrationTest [pinot]

2024-06-13 Thread via GitHub
Jackie-Jiang opened a new pull request, #13389: URL: https://github.com/apache/pinot/pull/13389 Segment size is platform dependent because of the native library used by the chunk compressor. Do not use the hard-coded segment size. Cache the segment size of the generated segments. -- T

Re: [PR] track segments for snapshotting even if they lost all comparisons [pinot]

2024-06-13 Thread via GitHub
codecov-commenter commented on PR #13388: URL: https://github.com/apache/pinot/pull/13388#issuecomment-2166886075 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/13388?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

Re: [PR] Add retry policy to wait for job id to persist during rebalancing [pinot]

2024-06-13 Thread via GitHub
codecov-commenter commented on PR #13372: URL: https://github.com/apache/pinot/pull/13372#issuecomment-2166871574 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/13372?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

Re: [PR] add `skipUnavailableServers` query option [pinot]

2024-06-13 Thread via GitHub
chenboat commented on code in PR #13387: URL: https://github.com/apache/pinot/pull/13387#discussion_r1638993216 ## pinot-core/src/main/java/org/apache/pinot/core/transport/AsyncQueryResponse.java: ## @@ -181,4 +181,11 @@ void markServerDown(ServerRoutingInstance serverRoutingIn

Re: [PR] track segments for snapshotting even if they lost all comparisons [pinot]

2024-06-13 Thread via GitHub
klsince commented on code in PR #13388: URL: https://github.com/apache/pinot/pull/13388#discussion_r1638983644 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/BasePartitionUpsertMetadataManager.java: ## @@ -1134,7 +1143,6 @@ protected void replaceDocId

Re: [PR] track segments for snapshotting even if they lost all comparisons [pinot]

2024-06-13 Thread via GitHub
klsince commented on code in PR #13388: URL: https://github.com/apache/pinot/pull/13388#discussion_r1638982416 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/BasePartitionUpsertMetadataManager.java: ## @@ -488,6 +491,7 @@ public void preloadSegment(Im

[PR] track segments for snapshotting even if they lost all comparisons [pinot]

2024-06-13 Thread via GitHub
klsince opened a new pull request, #13388: URL: https://github.com/apache/pinot/pull/13388 It's possible that docs from a segment lost all comparison with docs from other segments, thus not going to call any of those methods addDocId/replaceDocId where we track segments for snapshotting. So

Re: [PR] Add retry policy to wait for job id to persist during rebalancing [pinot]

2024-06-13 Thread via GitHub
Jackie-Jiang commented on code in PR #13372: URL: https://github.com/apache/pinot/pull/13372#discussion_r1638963244 ## pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotTableRestletResource.java: ## @@ -697,6 +698,31 @@ public RebalanceResult rebalanc

Re: [PR] add `skipUnavailableServers` query option [pinot]

2024-06-13 Thread via GitHub
codecov-commenter commented on PR #13387: URL: https://github.com/apache/pinot/pull/13387#issuecomment-2166734342 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/13387?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

Re: [PR] Bump com.google.cloud:libraries-bom from 26.40.0 to 26.41.0 [pinot]

2024-06-13 Thread via GitHub
Jackie-Jiang merged PR #13385: URL: https://github.com/apache/pinot/pull/13385 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

[PR] add `skipUnavailableServers` query option [pinot]

2024-06-13 Thread via GitHub
itschrispeck opened a new pull request, #13387: URL: https://github.com/apache/pinot/pull/13387 By default, during query submission to servers, if any exception is encountered the request will be failed. The change here adds a query option that so the server will be skipped and we can still

(pinot) branch master updated: Bump com.google.cloud:libraries-bom from 26.40.0 to 26.41.0 (#13385)

2024-06-13 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new a564b7f36d Bump com.google.cloud:libraries-bom fr

Re: [PR] [partial-upsert] configure early release of _partitionGroupConsumerSemaphore in RealtimeSegmentDataManager [pinot]

2024-06-13 Thread via GitHub
rohityadav1993 commented on code in PR #13256: URL: https://github.com/apache/pinot/pull/13256#discussion_r1638735568 ## pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeSegmentDataManager.java: ## @@ -1611,6 +1622,10 @@ public RealtimeSegmentDataMana

(pinot) branch dependabot/maven/com.google.cloud-libraries-bom-26.41.0 deleted (was 84898a9a0d)

2024-06-13 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch dependabot/maven/com.google.cloud-libraries-bom-26.41.0 in repository https://gitbox.apache.org/repos/asf/pinot.git was 84898a9a0d Bump com.google.cloud:libraries-bom from 26.40.0 to 26.41.

(pinot) branch master updated: Bump software.amazon.awssdk:bom from 2.26.0 to 2.26.1 (#13386)

2024-06-13 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 37608c1c51 Bump software.amazon.awssdk:bom from 2

Re: [PR] Ensure upsert deletion consistency when enabled with compaction flow [pinot]

2024-06-13 Thread via GitHub
tibrewalpratik17 commented on code in PR #13347: URL: https://github.com/apache/pinot/pull/13347#discussion_r1638652782 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/ConcurrentMapPartitionUpsertMetadataManagerForConsistentDeletes.java: ## @@ -0,0 +1,

(pinot) branch dependabot/maven/software.amazon.awssdk-bom-2.26.1 deleted (was 4200c45a42)

2024-06-13 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch dependabot/maven/software.amazon.awssdk-bom-2.26.1 in repository https://gitbox.apache.org/repos/asf/pinot.git was 4200c45a42 Bump software.amazon.awssdk:bom from 2.26.0 to 2.26.1 The revi

Re: [PR] [partial-upsert] configure early release of _partitionGroupConsumerSemaphore in RealtimeSegmentDataManager [pinot]

2024-06-13 Thread via GitHub
klsince commented on code in PR #13256: URL: https://github.com/apache/pinot/pull/13256#discussion_r1638623922 ## pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeSegmentDataManager.java: ## @@ -1611,6 +1622,10 @@ public RealtimeSegmentDataManager(Seg

Re: [PR] Bump software.amazon.awssdk:bom from 2.26.0 to 2.26.1 [pinot]

2024-06-13 Thread via GitHub
Jackie-Jiang merged PR #13386: URL: https://github.com/apache/pinot/pull/13386 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

Re: [PR] Add pinot-core dependency back to JDBC client [pinot]

2024-06-13 Thread via GitHub
abhioncbr commented on PR #13384: URL: https://github.com/apache/pinot/pull/13384#issuecomment-2165767592 pinot-core depends on four others(pinot-spi, pinot-segment-spi, pinot-segment-local, pinot-common). We have removed it because of the heavy client, as mentioned in this [issue](https:/

Re: [I] Improve the ser/de of the query plan [pinot]

2024-06-13 Thread via GitHub
yashmayya closed issue #12934: Improve the ser/de of the query plan URL: https://github.com/apache/pinot/issues/12934 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubsc

Re: [I] Improve the ser/de of the query plan [pinot]

2024-06-13 Thread via GitHub
yashmayya commented on issue #12934: URL: https://github.com/apache/pinot/issues/12934#issuecomment-2165536833 Closed by https://github.com/apache/pinot/pull/13221 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

(pinot) branch dependabot/maven/software.amazon.awssdk-bom-2.26.1 created (now 4200c45a42)

2024-06-13 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/software.amazon.awssdk-bom-2.26.1 in repository https://gitbox.apache.org/repos/asf/pinot.git at 4200c45a42 Bump software.amazon.awssdk:bom from 2.26.0 to 2.26.1 No n

[PR] Bump software.amazon.awssdk:bom from 2.26.0 to 2.26.1 [pinot]

2024-06-13 Thread via GitHub
dependabot[bot] opened a new pull request, #13386: URL: https://github.com/apache/pinot/pull/13386 Bumps software.amazon.awssdk:bom from 2.26.0 to 2.26.1. [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=software

(pinot) branch dependabot/maven/com.google.cloud-libraries-bom-26.41.0 created (now 84898a9a0d)

2024-06-13 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/com.google.cloud-libraries-bom-26.41.0 in repository https://gitbox.apache.org/repos/asf/pinot.git at 84898a9a0d Bump com.google.cloud:libraries-bom from 26.40.0 to 26

[PR] Bump com.google.cloud:libraries-bom from 26.40.0 to 26.41.0 [pinot]

2024-06-13 Thread via GitHub
dependabot[bot] opened a new pull request, #13385: URL: https://github.com/apache/pinot/pull/13385 Bumps [com.google.cloud:libraries-bom](https://github.com/googleapis/java-cloud-bom) from 26.40.0 to 26.41.0. Release notes Sourced from https://github.com/googleapis/java-cloud-bom/

Re: [PR] Add pinot-core dependency back to JDBC client [pinot]

2024-06-13 Thread via GitHub
codecov-commenter commented on PR #13384: URL: https://github.com/apache/pinot/pull/13384#issuecomment-2165018057 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/13384?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

[PR] Add pinot-core dependency back to JDBC client [pinot]

2024-06-13 Thread via GitHub
KKcorps opened a new pull request, #13384: URL: https://github.com/apache/pinot/pull/13384 PR #11620 removed `pinot-core` dependency from the `pinot-jdbc-client` since it was not needed for Auth anymore However, there are a lot of other deps such as sl4j which jdbc client needs from

[I] Unable to ingest Protobuf Messages into Pinot table with Realtime connector [pinot]

2024-06-13 Thread via GitHub
rahulgulati89 opened a new issue, #13383: URL: https://github.com/apache/pinot/issues/13383 I am trying to ingest Kafka messages serialized with Protobuf format into Pinot tables using realtime connector but i am getting errors while querying table. Here are the steps followed. Proto