itschrispeck commented on code in PR #13387:
URL: https://github.com/apache/pinot/pull/13387#discussion_r1639016799
##########
pinot-core/src/test/java/org/apache/pinot/core/transport/QueryRoutingTest.java:
##########
@@ -286,6 +293,89 @@ public void testServerDown()
assertEquals(_serverRoutingStatsManager.fetchNumInFlightRequestsForServer(serverId).intValue(),
0);
}
+ @Test
+ public void testSkipUnavailableServer()
+ throws IOException, InterruptedException {
+ // Using a different port is a hack to avoid resource conflict with other
tests, ideally queryServer.shutdown()
+ // should ensure there is no possibility of resource conflict.
+ int port = 12346;
Review Comment:
I don't love this workaround, but using the same port as other tests impacts
test isolation. It looks like `queryServer.shutDown()` doesn't properly
shutdown and block.
I'm open to suggestions, as I am pretty unfamiliar w/ netty and did not find
a clean solution
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
