tibrewalpratik17 commented on code in PR #13388:
URL: https://github.com/apache/pinot/pull/13388#discussion_r1639341763
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/BasePartitionUpsertMetadataManager.java:
##########
@@ -933,7 +943,6 @@ protected void doTakeSnapshot() {
continue;
}
immutableSegment.persistValidDocIdsSnapshot();
- _updatedSegmentsSinceLastSnapshot.remove(segment);
Review Comment:
nit: we can still keep this `remove` statement. If snapshotting errors out
in between then we don't need to process the segments for snapshot in next
cycle again if they were processed this cycle.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
