klsince commented on code in PR #13388:
URL: https://github.com/apache/pinot/pull/13388#discussion_r1638983644
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/BasePartitionUpsertMetadataManager.java:
##########
@@ -1134,7 +1143,6 @@ protected void replaceDocId(IndexSegment newSegment,
ThreadSafeMutableRoaringBit
doBatchRefreshUpsertView(_upsertViewRefreshIntervalMs);
}
if (_enableSnapshot) {
- _updatedSegmentsSinceLastSnapshot.add(newSegment);
Review Comment:
no need to add `new` segment to Set as we have tracked it in the higher
level methods, but we should track the old segment being updated while adding
docs from the new segment.
similar for the removal of following two methods that update `new` segment,
which is tracked in Set already.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
