klsince opened a new pull request, #13388: URL: https://github.com/apache/pinot/pull/13388
It's possible that docs from a segment lost all comparison with docs from other segments, thus not going to call any of those methods addDocId/replaceDocId where we track segments for snapshotting. So in this PR, we track segments for snapshotting in addSegment/replaceSegment high level entry methods, beside replaceDocId/removeDocId where the existing segments may be updated. This should keep a complete set of segments being updated since last snapshotting. Also made a fix for another minor bug that some segments were not removed from the track Set after taking snapshot for them. The batch mode of consistent view feature is also subject to this issue, i.e missing segment that lost all comparison. Will address that in separate RP so that changes can be reverted separately in case. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
