klsince commented on code in PR #13388:
URL: https://github.com/apache/pinot/pull/13388#discussion_r1638982416
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/BasePartitionUpsertMetadataManager.java:
##########
@@ -488,6 +491,7 @@ public void preloadSegment(ImmutableSegment segment) {
try {
doPreloadSegment((ImmutableSegmentImpl) segment);
_trackedSegments.add(segment);
+ _updatedSegmentsSinceLastSnapshot.add(segment);
Review Comment:
preloadSegment() checked _enableSnapshot above already, so saved the
if-check here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
