[GitHub] [pinot] codecov-commenter commented on pull request #11620: Refactor BasicAuthUtils from pinot-core to pinot-common

2023-09-18 Thread via GitHub
codecov-commenter commented on PR #11620: URL: https://github.com/apache/pinot/pull/11620#issuecomment-1724933249 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/11620?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) R

[GitHub] [pinot] xiangfu0 commented on issue #11507: pinot-clients have too many dependencies

2023-09-18 Thread via GitHub
xiangfu0 commented on issue #11507: URL: https://github.com/apache/pinot/issues/11507#issuecomment-1724901472 Some improvement: https://github.com/apache/pinot/pull/11620 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [pinot] ArnavBalyan commented on issue #11563: Pinot build in local is getting into error

2023-09-18 Thread via GitHub
ArnavBalyan commented on issue #11563: URL: https://github.com/apache/pinot/issues/11563#issuecomment-1724895751 Hi I was able to reproduce this. System specs are similar to what @eaugene described above. Seems to be working after the above PR got merged -- This is an automated message f

[GitHub] [pinot] xiangfu0 opened a new pull request, #11620: Refactor BasicAuthUtils from pinot-core to pinot-common

2023-09-18 Thread via GitHub
xiangfu0 opened a new pull request, #11620: URL: https://github.com/apache/pinot/pull/11620 - Refactor BasicAuthUtils from `pinot-core` to `pinot-common` - Remove `pinot-core` dependency from` pinot-jdbc-client` -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [pinot] codecov-commenter commented on pull request #11619: fix jackson vulnerability

2023-09-18 Thread via GitHub
codecov-commenter commented on PR #11619: URL: https://github.com/apache/pinot/pull/11619#issuecomment-1724888511 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/11619?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) R

[GitHub] [pinot] eaugene commented on pull request #11564: Use builder method for initalizing immutable map in integration test

2023-09-18 Thread via GitHub
eaugene commented on PR #11564: URL: https://github.com/apache/pinot/pull/11564#issuecomment-1724878103 > @eaugene I know this PR was already merged, but something in this caused our code coverage to drop from 63% to 14% and given that we've been holding a steady 63% for a few months I thin

[GitHub] [pinot] eaugene commented on issue #11570: Deprecate schema name field in table config

2023-09-18 Thread via GitHub
eaugene commented on issue #11570: URL: https://github.com/apache/pinot/issues/11570#issuecomment-1724874257 > @eaugene The current plan is to do a one time modification to all the existing tables without manually trigger the API for each individual table, one implementation example is #115

[GitHub] [pinot] eaugene commented on pull request #11574: Adding a controller task to update schema name

2023-09-18 Thread via GitHub
eaugene commented on PR #11574: URL: https://github.com/apache/pinot/pull/11574#issuecomment-1724871776 @xiangfu0 , I am not able to understand - Why are we needing a periodic task for this , as new tables creation with different schema name is anyways going to blocked . Any problems we enc

[GitHub] [pinot] xiangfu0 opened a new pull request, #11619: fix jackson vulnerability

2023-09-18 Thread via GitHub
xiangfu0 opened a new pull request, #11619: URL: https://github.com/apache/pinot/pull/11619 Bump jackson version from `2.12.7` to `2.12.7.20221012`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[pinot] branch master updated: Fix the alias handling in single-stage engine (#11610)

2023-09-18 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new e1236429a7 Fix the alias handling in single-stag

[GitHub] [pinot] xiangfu0 closed issue #11597: Aliasing a column with a function to the same name causes a StackOverflowException

2023-09-18 Thread via GitHub
xiangfu0 closed issue #11597: Aliasing a column with a function to the same name causes a StackOverflowException URL: https://github.com/apache/pinot/issues/11597 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[GitHub] [pinot] xiangfu0 merged pull request #11610: Fix the alias handling in single-stage engine

2023-09-18 Thread via GitHub
xiangfu0 merged PR #11610: URL: https://github.com/apache/pinot/pull/11610 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apa

[GitHub] [pinot] xiangfu0 commented on pull request #11610: Fix the alias handling in single-stage engine

2023-09-18 Thread via GitHub
xiangfu0 commented on PR #11610: URL: https://github.com/apache/pinot/pull/11610#issuecomment-1724827392 > Just for curiosity, what regression do you observe when the #10815 is introduced? master branch build failure: https://github.com/apache/pinot/actions/runs/6230277100/job/1691

[GitHub] [pinot] wirybeaver commented on pull request #11610: Fix the alias handling in single-stage engine

2023-09-18 Thread via GitHub
wirybeaver commented on PR #11610: URL: https://github.com/apache/pinot/pull/11610#issuecomment-1724826090 Just for curiosity, what regression do you observe when the https://github.com/apache/pinot/pull/10815 is introduced? -- This is an automated message from the Apache Git Service. To

[GitHub] [pinot] xiangfu0 commented on issue #11570: Deprecate schema name field in table config

2023-09-18 Thread via GitHub
xiangfu0 commented on issue #11570: URL: https://github.com/apache/pinot/issues/11570#issuecomment-1724824347 > @xiangfu0 @Jackie-Jiang > > 1. Can we keep a new REST API open for this action ? - Given a table name which allows a new schema with same name as table to be created from th

[GitHub] [pinot] xiangfu0 commented on pull request #11574: Adding a controller task to update schema name

2023-09-18 Thread via GitHub
xiangfu0 commented on PR #11574: URL: https://github.com/apache/pinot/pull/11574#issuecomment-1724821237 > Actually a periodic task is also fine. We will remove it after one release anyway I would say we can keep this job for 1.x release, then remove it in 2.x :) -- This is an aut

[GitHub] [pinot] xiangfu0 commented on a diff in pull request #10815: Periodically delete Tmp Segment file brought by the SplitCommit End phase

2023-09-18 Thread via GitHub
xiangfu0 commented on code in PR #10815: URL: https://github.com/apache/pinot/pull/10815#discussion_r1329564462 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java: ## @@ -1465,6 +1469,78 @@ public void uploadToDe

[GitHub] [pinot] jadami10 commented on issue #11603: segmentReloadStatus API never completes

2023-09-18 Thread via GitHub
jadami10 commented on issue #11603: URL: https://github.com/apache/pinot/issues/11603#issuecomment-1724730745 I looked at the code, and it's a little tough to debug. We store the "submissionTime" of the reload request in ZK, then successCount == count(segment.loadTime >= submissionTime). It

[GitHub] [pinot] Jackie-Jiang commented on issue #11603: segmentReloadStatus API never completes

2023-09-18 Thread via GitHub
Jackie-Jiang commented on issue #11603: URL: https://github.com/apache/pinot/issues/11603#issuecomment-1724727413 @saurabhd336 Can you help take a look at this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[pinot] branch master updated: Periodically delete Tmp Segment file brought by the SplitCommit End phase (#10815)

2023-09-18 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new d9c0790a46 Periodically delete Tmp Segment file b

[GitHub] [pinot] Jackie-Jiang merged pull request #10815: Periodically delete Tmp Segment file brought by the SplitCommit End phase

2023-09-18 Thread via GitHub
Jackie-Jiang merged PR #10815: URL: https://github.com/apache/pinot/pull/10815 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #11604: JSON index: Add support for ignoring values longer than a given length.

2023-09-18 Thread via GitHub
Jackie-Jiang commented on code in PR #11604: URL: https://github.com/apache/pinot/pull/11604#discussion_r1329472659 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/realtime/impl/json/MutableJsonIndexImpl.java: ## @@ -106,8 +106,11 @@ private void addFlattened

[GitHub] [pinot] Jackie-Jiang commented on issue #11570: Deprecate schema name field in table config

2023-09-18 Thread via GitHub
Jackie-Jiang commented on issue #11570: URL: https://github.com/apache/pinot/issues/11570#issuecomment-1724716023 @eaugene The current plan is to do a one time modification to all the existing tables without manually trigger the API for each individual table, one implementation example is #

[GitHub] [pinot] Jackie-Jiang commented on issue #11601: Can't use SegmentUriPush job

2023-09-18 Thread via GitHub
Jackie-Jiang commented on issue #11601: URL: https://github.com/apache/pinot/issues/11601#issuecomment-1724713553 cc @snleee -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [pinot] codecov-commenter commented on pull request #11617: In multi-stage aggregate, directly store column index as identifier

2023-09-18 Thread via GitHub
codecov-commenter commented on PR #11617: URL: https://github.com/apache/pinot/pull/11617#issuecomment-1724667548 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/11617?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) R

[GitHub] [pinot] itschrispeck opened a new issue, #11618: regexp_like using wildcard prefix/suffix without anchors is unoptimized

2023-09-18 Thread via GitHub
itschrispeck opened a new issue, #11618: URL: https://github.com/apache/pinot/issues/11618 Take the query, `REGEXP_LIKE(direct_tags, '^.*"key":[^\]]*"value".*$'))` which searches for some array element = "value" in array "key". This query, and the minimized syntax `REGEXP_LIKE(direct_tags,

[pinot] branch master updated: Use constant null place holder (#11615)

2023-09-18 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 0db63aac80 Use constant null place holder (#11615

[GitHub] [pinot] Jackie-Jiang merged pull request #11615: Use constant null place holder

2023-09-18 Thread via GitHub
Jackie-Jiang merged PR #11615: URL: https://github.com/apache/pinot/pull/11615 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

[pinot] branch master updated: Move all BlockValSet into the same package (#11616)

2023-09-18 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 2bb8e0be7c Move all BlockValSet into the same pac

[GitHub] [pinot] Jackie-Jiang merged pull request #11616: Move all BlockValSet into the same package

2023-09-18 Thread via GitHub
Jackie-Jiang merged PR #11616: URL: https://github.com/apache/pinot/pull/11616 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

[GitHub] [pinot] Jackie-Jiang opened a new pull request, #11617: In multi-stage aggregate, directly store column index as identifier

2023-09-18 Thread via GitHub
Jackie-Jiang opened a new pull request, #11617: URL: https://github.com/apache/pinot/pull/11617 Avoid constructing the column name to index map and converting back and forth -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[pinot] branch realtime.partition.increase.fix created (now f14700a1e2)

2023-09-18 Thread sajjad
This is an automated email from the ASF dual-hosted git repository. sajjad pushed a change to branch realtime.partition.increase.fix in repository https://gitbox.apache.org/repos/asf/pinot.git at f14700a1e2 only emit throttling metrics when throttling is allowed (#11443) No new revisions

[GitHub] [pinot] xiangfu0 commented on pull request #11591: Throw exception when schema name doesn't match table name during table creation

2023-09-18 Thread via GitHub
xiangfu0 commented on PR #11591: URL: https://github.com/apache/pinot/pull/11591#issuecomment-1724630911 > Hi @xiangfu0 @Jackie-Jiang , > > As @mcvsubbu mentioned, We are working with partner team to resolve the table creation flow since this will error out for new tables. As I unders

[pinot] branch master updated: Remove deprecated Request class from pinot-java-client (#11614)

2023-09-18 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 70a1335460 Remove deprecated Request class from

[GitHub] [pinot] xiangfu0 closed issue #11582: Remove deprecated methods from pinot-java-client

2023-09-18 Thread via GitHub
xiangfu0 closed issue #11582: Remove deprecated methods from pinot-java-client URL: https://github.com/apache/pinot/issues/11582 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [pinot] xiangfu0 merged pull request #11614: Remove deprecated Request class from pinot-java-client

2023-09-18 Thread via GitHub
xiangfu0 merged PR #11614: URL: https://github.com/apache/pinot/pull/11614 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apa

[pinot] branch master updated (7fb47f062d -> 949083d8b4)

2023-09-18 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from 7fb47f062d Select testng as the test provider explicitly instead of relying on the classpath. (#11612) add 94908

[GitHub] [pinot] xiangfu0 merged pull request #11611: UI: add toggle to hide/show query exceptions

2023-09-18 Thread via GitHub
xiangfu0 merged PR #11611: URL: https://github.com/apache/pinot/pull/11611 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apa

[pinot] branch master updated: Select testng as the test provider explicitly instead of relying on the classpath. (#11612)

2023-09-18 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 7fb47f062d Select testng as the test provider ex

[GitHub] [pinot] xiangfu0 merged pull request #11612: Select testng as the test provider explicitly instead of relying on the classpath

2023-09-18 Thread via GitHub
xiangfu0 merged PR #11612: URL: https://github.com/apache/pinot/pull/11612 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apa

[GitHub] [pinot] abhioncbr commented on issue #11507: pinot-clients have too many dependencies

2023-09-18 Thread via GitHub
abhioncbr commented on issue #11507: URL: https://github.com/apache/pinot/issues/11507#issuecomment-1724552681 > Another approach is to remove the dependencies of `pinot-common`, only `pinot-spi`. This might take longer time to finish. We need to extract the `SqlParser` out from the `pinot-

[GitHub] [pinot] abhioncbr commented on pull request #11606: Fix the broken Pinot JDBC client.

2023-09-18 Thread via GitHub
abhioncbr commented on PR #11606: URL: https://github.com/apache/pinot/pull/11606#issuecomment-1724551284 Thanks @shenyu0127 , I will start looking the more robust fix as suggested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [pinot] codecov-commenter commented on pull request #11615: Use constant null place holder

2023-09-18 Thread via GitHub
codecov-commenter commented on PR #11615: URL: https://github.com/apache/pinot/pull/11615#issuecomment-1724550077 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/11615?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) R

[GitHub] [pinot] codecov-commenter commented on pull request #11616: Move all BlockValSet into the same package

2023-09-18 Thread via GitHub
codecov-commenter commented on PR #11616: URL: https://github.com/apache/pinot/pull/11616#issuecomment-1724546752 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/11616?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) R

[GitHub] [pinot] Jackie-Jiang opened a new pull request, #11616: Move all BlockValSet into the same package

2023-09-18 Thread via GitHub
Jackie-Jiang opened a new pull request, #11616: URL: https://github.com/apache/pinot/pull/11616 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [pinot] Jackie-Jiang opened a new pull request, #11615: Use constant null place holder

2023-09-18 Thread via GitHub
Jackie-Jiang opened a new pull request, #11615: URL: https://github.com/apache/pinot/pull/11615 This PR also fixes some wrong type casting for `BYTES` type -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [pinot] codecov-commenter commented on pull request #11611: UI: add toggle to hide/show query exceptions

2023-09-18 Thread via GitHub
codecov-commenter commented on PR #11611: URL: https://github.com/apache/pinot/pull/11611#issuecomment-1724480272 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/11611?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) R

[GitHub] [pinot] jasperjiaguo commented on pull request #11496: Fix direct memory OOM on broker

2023-09-18 Thread via GitHub
jasperjiaguo commented on PR #11496: URL: https://github.com/apache/pinot/pull/11496#issuecomment-172153 > @jasperjiaguo This is resource starvation instead of deadlock then. During your investigation do you see closing all connections necessary? Ideally we want to only close the connec

[GitHub] [pinot] xiangfu0 commented on a diff in pull request #11610: Fix the alias handling in single-stage engine

2023-09-18 Thread via GitHub
xiangfu0 commented on code in PR #11610: URL: https://github.com/apache/pinot/pull/11610#discussion_r1329276237 ## pinot-common/src/main/java/org/apache/pinot/sql/parsers/rewriter/AliasApplier.java: ## @@ -31,38 +29,30 @@ public class AliasApplier implements QueryRewriter {

[pinot] branch master updated (fef4e64ed7 -> 086a936340)

2023-09-18 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from fef4e64ed7 Avoid unnecessary rows conversion in aggregation (#11607) add 086a936340 Remove old thirdeye files. (#

[GitHub] [pinot] xiangfu0 merged pull request #11609: Remove old thirdeye files.

2023-09-18 Thread via GitHub
xiangfu0 merged PR #11609: URL: https://github.com/apache/pinot/pull/11609 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apa

[pinot] branch master updated (49196ec7df -> fef4e64ed7)

2023-09-18 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from 49196ec7df Add table indexes API (#11576) add fef4e64ed7 Avoid unnecessary rows conversion in aggregation (#11607)

[GitHub] [pinot] Jackie-Jiang merged pull request #11607: Avoid unnecessary rows conversion in aggregation

2023-09-18 Thread via GitHub
Jackie-Jiang merged PR #11607: URL: https://github.com/apache/pinot/pull/11607 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

[GitHub] [pinot] codecov-commenter commented on pull request #11614: Remove deprecated Request class from pinot-java-client

2023-09-18 Thread via GitHub
codecov-commenter commented on PR #11614: URL: https://github.com/apache/pinot/pull/11614#issuecomment-1724333759 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/11614?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) R

[GitHub] [pinot] lucifer4j opened a new pull request, #11614: Remove deprecated Request class from pinot-java-client

2023-09-18 Thread via GitHub
lucifer4j opened a new pull request, #11614: URL: https://github.com/apache/pinot/pull/11614 also delete related methods. partially fix: #11582 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [pinot] walterddr commented on pull request #11457: Turn on expand identifier in SqlValidator config

2023-09-18 Thread via GitHub
walterddr commented on PR #11457: URL: https://github.com/apache/pinot/pull/11457#issuecomment-1724208046 i was wondering if there's a better way to handle it. expanding both into a CAST seems a bit overkill b/c we might not really want to perform the cast operation, is there any rule in Ca

[GitHub] [pinot] thatran opened a new issue, #11613: Allow a default replication to be set at the Tenant level, instead of requiring it to be set at the table level

2023-09-18 Thread via GitHub
thatran opened a new issue, #11613: URL: https://github.com/apache/pinot/issues/11613 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: c

[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #11607: Avoid unnecessary rows conversion in aggregation

2023-09-18 Thread via GitHub
Jackie-Jiang commented on code in PR #11607: URL: https://github.com/apache/pinot/pull/11607#discussion_r1329131350 ## pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/block/DataBlockValSet.java: ## @@ -36,29 +36,28 @@ * TODO: Support MV */ public c

[GitHub] [pinot] codecov-commenter commented on pull request #11612: Select testng as the test provider explicitly instead of relying on the classpath

2023-09-18 Thread via GitHub
codecov-commenter commented on PR #11612: URL: https://github.com/apache/pinot/pull/11612#issuecomment-1724158086 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/11612?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) R

[GitHub] [pinot] walterddr commented on pull request #11545: [multistage] (improve #11518) disable calcite implicit float to double cast

2023-09-18 Thread via GitHub
walterddr commented on PR #11545: URL: https://github.com/apache/pinot/pull/11545#issuecomment-1724155844 do we have a story behind this PR and https://github.com/apache/pinot/pull/11518 ? it seems like we have some issue still unaddressed? -- This is an automated message from the Apache

[GitHub] [pinot] walterddr commented on a diff in pull request #11512: [multistage] Support range queries in search

2023-09-18 Thread via GitHub
walterddr commented on code in PR #11512: URL: https://github.com/apache/pinot/pull/11512#discussion_r1329127702 ## pinot-query-planner/src/main/java/org/apache/pinot/query/planner/logical/RexExpressionUtils.java: ## @@ -155,10 +157,83 @@ private static RexExpression.FunctionCal

[GitHub] [pinot] walterddr commented on pull request #11484: Changes to support private columns

2023-09-18 Thread via GitHub
walterddr commented on PR #11484: URL: https://github.com/apache/pinot/pull/11484#issuecomment-1724149302 just to confirm the behavior for private column is now matching v1 right? (e.g. we dont need any additional documentation to state the differences) -- This is an automated message fro

[GitHub] [pinot] walterddr commented on a diff in pull request #11473: [multistage] Reuse broker/server hostname for multistage queryrunner hostname

2023-09-18 Thread via GitHub
walterddr commented on code in PR #11473: URL: https://github.com/apache/pinot/pull/11473#discussion_r1329123287 ## pinot-broker/src/main/java/org/apache/pinot/broker/broker/helix/BaseBrokerStarter.java: ## @@ -146,6 +146,10 @@ public void init(PinotConfiguration brokerConf)

[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #11607: Avoid unnecessary rows conversion in aggregation

2023-09-18 Thread via GitHub
Jackie-Jiang commented on code in PR #11607: URL: https://github.com/apache/pinot/pull/11607#discussion_r1329122172 ## pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/AggregateOperator.java: ## @@ -325,57 +291,126 @@ private ExpressionContext convertRe

[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #11607: Avoid unnecessary rows conversion in aggregation

2023-09-18 Thread via GitHub
Jackie-Jiang commented on code in PR #11607: URL: https://github.com/apache/pinot/pull/11607#discussion_r1329121619 ## pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/AggregateOperator.java: ## @@ -325,57 +291,126 @@ private ExpressionContext convertRe

[GitHub] [pinot] walterddr commented on a diff in pull request #11607: Avoid unnecessary rows conversion in aggregation

2023-09-18 Thread via GitHub
walterddr commented on code in PR #11607: URL: https://github.com/apache/pinot/pull/11607#discussion_r1329104386 ## pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/AggregateOperator.java: ## @@ -325,57 +291,126 @@ private ExpressionContext convertRexEx

[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #11607: Avoid unnecessary rows conversion in aggregation

2023-09-18 Thread via GitHub
Jackie-Jiang commented on code in PR #11607: URL: https://github.com/apache/pinot/pull/11607#discussion_r1329117658 ## pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/AggregateOperator.java: ## @@ -117,31 +96,34 @@ public AggregateOperator(OpChainExecut

[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #11607: Avoid unnecessary rows conversion in aggregation

2023-09-18 Thread via GitHub
Jackie-Jiang commented on code in PR #11607: URL: https://github.com/apache/pinot/pull/11607#discussion_r1329115153 ## pinot-query-runtime/src/test/java/org/apache/pinot/query/runtime/operator/AggregateOperatorTest.java: ## @@ -79,7 +79,7 @@ public void shouldHandleUpstreamError

[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #11607: Avoid unnecessary rows conversion in aggregation

2023-09-18 Thread via GitHub
Jackie-Jiang commented on code in PR #11607: URL: https://github.com/apache/pinot/pull/11607#discussion_r1329113379 ## pinot-spi/src/main/java/org/apache/pinot/spi/utils/CommonConstants.java: ## @@ -1065,4 +1066,14 @@ public enum JoinOverFlowMode { THROW, BREAK }

[GitHub] [pinot] walterddr commented on a diff in pull request #11607: Avoid unnecessary rows conversion in aggregation

2023-09-18 Thread via GitHub
walterddr commented on code in PR #11607: URL: https://github.com/apache/pinot/pull/11607#discussion_r1329106373 ## pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/block/DataBlockValSet.java: ## @@ -36,29 +36,28 @@ * TODO: Support MV */ public clas

[GitHub] [pinot] walterddr commented on a diff in pull request #11607: Avoid unnecessary rows conversion in aggregation

2023-09-18 Thread via GitHub
walterddr commented on code in PR #11607: URL: https://github.com/apache/pinot/pull/11607#discussion_r1329106373 ## pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/block/DataBlockValSet.java: ## @@ -36,29 +36,28 @@ * TODO: Support MV */ public clas

[GitHub] [pinot] walterddr commented on a diff in pull request #11607: Avoid unnecessary rows conversion in aggregation

2023-09-18 Thread via GitHub
walterddr commented on code in PR #11607: URL: https://github.com/apache/pinot/pull/11607#discussion_r1329089094 ## pinot-spi/src/main/java/org/apache/pinot/spi/utils/CommonConstants.java: ## @@ -1065,4 +1066,14 @@ public enum JoinOverFlowMode { THROW, BREAK } } +

[GitHub] [pinot] soumitra-st opened a new pull request, #11612: Select testng as the test provider explicitly instead of relying on the classpath

2023-09-18 Thread via GitHub
soumitra-st opened a new pull request, #11612: URL: https://github.com/apache/pinot/pull/11612 I am adding testcases which brings in below dependencies: org.glassfish.jersey.test-framework jersey-test-framework-core 2.26

[GitHub] [pinot] jayeshchoudhary opened a new pull request, #11611: UI: add toggle to hide/show query exceptions

2023-09-18 Thread via GitHub
jayeshchoudhary opened a new pull request, #11611: URL: https://github.com/apache/pinot/pull/11611 Instructions: 1. The PR has to be tagged with at least one of the following labels (*): 1. `feature` 2. `bugfix` 3. `performance` 4. `ui` 5. `backward-incompat`

[GitHub] [pinot] deemoliu commented on pull request #11346: Add hyperLogLogPlus aggregation function for distinct count

2023-09-18 Thread via GitHub
deemoliu commented on PR #11346: URL: https://github.com/apache/pinot/pull/11346#issuecomment-1724017438 thanks @Jackie-Jiang @jackjlli @siddharthteotia and @chenboat for review. I will address comment today. -- This is an automated message from the Apache Git Service. To respond to the m

[pinot] branch master updated: Add table indexes API (#11576)

2023-09-18 Thread saurabhd336
This is an automated email from the ASF dual-hosted git repository. saurabhd336 pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 49196ec7df Add table indexes API (#11576) 49

[GitHub] [pinot] saurabhd336 merged pull request #11576: Add table indexes API

2023-09-18 Thread via GitHub
saurabhd336 merged PR #11576: URL: https://github.com/apache/pinot/pull/11576 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.

[GitHub] [pinot] ege-st commented on pull request #11564: Use builder method for initalizing immutable map in integration test

2023-09-18 Thread via GitHub
ege-st commented on PR #11564: URL: https://github.com/apache/pinot/pull/11564#issuecomment-1723585568 @eaugene I know this PR was already merged, but something in this caused our code coverage to drop from 63% to 14% and given that we've been holding a steady 63% for a few months I think t

[GitHub] [pinot] kishoreg commented on issue #11488: Losing a controller leads to a minimum 5 minute window where segments cannot be committed

2023-09-18 Thread via GitHub
kishoreg commented on issue #11488: URL: https://github.com/apache/pinot/issues/11488#issuecomment-1723570737 +1 to what Johan is asking for. We need to fix the design/impl. Subbu, flapping can be detected easily. In fact, helix will put the participant in disabled state if it flaps

[GitHub] [pinot] ArnavBalyan commented on pull request #11608: Updated the response for reload API to be pretty printed

2023-09-18 Thread via GitHub
ArnavBalyan commented on PR #11608: URL: https://github.com/apache/pinot/pull/11608#issuecomment-1723432879 > you also need to update > > https://github.com/apache/pinot/blob/b1b070f68dce37605a705b25834f0f5579a3b3be/pinot-controller/src/main/resources/app/pages/TenantDetails.tsx#L340

[GitHub] [pinot] jadami10 commented on a diff in pull request #11608: Updated the response for reload API to be pretty printed

2023-09-18 Thread via GitHub
jadami10 commented on code in PR #11608: URL: https://github.com/apache/pinot/pull/11608#discussion_r1328719375 ## pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotSegmentRestletResource.java: ## @@ -782,7 +782,7 @@ public SuccessResponse reloadAllSe

[GitHub] [pinot] jadami10 commented on issue #11488: Losing a controller leads to a minimum 5 minute window where segments cannot be committed

2023-09-18 Thread via GitHub
jadami10 commented on issue #11488: URL: https://github.com/apache/pinot/issues/11488#issuecomment-1723396128 Those are all valid points. For us, a lot of it is mitigated because we are overprovisioned on the controller side. Every cluster has 3 controllers, I don't see any GC taking > 1 ms

[GitHub] [pinot] codecov-commenter commented on pull request #11610: Fix the alias handling in single-stage engine

2023-09-18 Thread via GitHub
codecov-commenter commented on PR #11610: URL: https://github.com/apache/pinot/pull/11610#issuecomment-1723079012 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/11610?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) R

[GitHub] [pinot] Jackie-Jiang commented on pull request #11499: Add API to query upsert metadata for a primary key from servers

2023-09-18 Thread via GitHub
Jackie-Jiang commented on PR #11499: URL: https://github.com/apache/pinot/pull/11499#issuecomment-1723030669 > > Do we really need this API? We can retrieve the same information by querying the table and ask for `$segmentName` and `$docId`. From the query we can even get the history of the

[GitHub] [pinot] Jackie-Jiang opened a new pull request, #11610: Fix the alias handling in single-stage engine

2023-09-18 Thread via GitHub
Jackie-Jiang opened a new pull request, #11610: URL: https://github.com/apache/pinot/pull/11610 Fix 2 issues: - Fix #11597 - Alias should not be applied to filter (SQL standard) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [pinot] gortiz commented on pull request #11609: Remove old thirdeye files.

2023-09-18 Thread via GitHub
gortiz commented on PR #11609: URL: https://github.com/apache/pinot/pull/11609#issuecomment-1722984421 cc @cyrilou242 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[GitHub] [pinot] gortiz opened a new pull request, #11609: Remove old thirdeye files.

2023-09-18 Thread via GitHub
gortiz opened a new pull request, #11609: URL: https://github.com/apache/pinot/pull/11609 Long time ago, Apache Pinot repository included ThirdEye code. That code was moved to their own repository (https://github.com/project-thirdeye/thirdeye), but there some spurious files (mainly docker a