Jackie-Jiang commented on code in PR #11607:
URL: https://github.com/apache/pinot/pull/11607#discussion_r1329121619
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/AggregateOperator.java:
##########
@@ -325,57 +291,126 @@ private ExpressionContext
convertRexExpressionToExpressionContext(int aggIdx, in
return exprContext;
}
- // TODO: If the previous block is not mailbox received, this method is not
efficient. Then getDataBlock() will
- // convert the unserialized format to serialized format of BaseDataBlock.
Then it will convert it back to column
- // value primitive type.
- static Map<ExpressionContext, BlockValSet>
getBlockValSetMap(AggregationFunction aggFunction, TransferableBlock block,
- DataSchema inputDataSchema, Map<String, Integer> colNameToIndexMap, int
filterArgIdx) {
+ private int[] getGroupKeyIds(List<RexExpression> groupSet) {
Review Comment:
It is quite different though. One retrieves the expressions, one just for
the ids. I'll try to remove `convertRexExpressionToExpressionContext` in a
separate PR because that involves quite some change on the aggregation function
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
