jadami10 commented on code in PR #11608:
URL: https://github.com/apache/pinot/pull/11608#discussion_r1328719375
##########
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotSegmentRestletResource.java:
##########
@@ -782,7 +782,7 @@ public SuccessResponse reloadAllSegments(
LOGGER.error("Failed to add reload all segments job meta into
zookeeper for table: {}", tableNameWithType, e);
}
}
- return new SuccessResponse("Segment reload details: " +
JsonUtils.objectToString(perTableMsgData));
+ return new
SuccessResponse(JsonUtils.objectToPrettyString(perTableMsgData));
Review Comment:
it doesn't need to be, but what value is `Segment reload details:` to the
result of an endpoint that is clearly already the reload details. The impetus
for this change was to make it easier to parse the result in java/scala so you
don't have to go from request -> strip the prefix -> decode the json string ->
decode the json. You should be able to go from request -> json in 1 hop.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
