Jackie-Jiang commented on code in PR #11607:
URL: https://github.com/apache/pinot/pull/11607#discussion_r1329131350
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/block/DataBlockValSet.java:
##########
@@ -36,29 +36,28 @@
* TODO: Support MV
*/
public class DataBlockValSet implements BlockValSet {
- protected final FieldSpec.DataType _dataType;
- protected final DataBlock _dataBlock;
- protected final int _index;
- protected final RoaringBitmap _nullBitMap;
+ private final DataType _dataType;
Review Comment:
I would say there is no specific reason. Ideally we should move all
`BlockValSet` together, but currently they are spread over 3 places. Can be
done in a separate PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
