Jackie-Jiang commented on code in PR #11607:
URL: https://github.com/apache/pinot/pull/11607#discussion_r1329115153


##########
pinot-query-runtime/src/test/java/org/apache/pinot/query/runtime/operator/AggregateOperatorTest.java:
##########
@@ -79,7 +79,7 @@ public void shouldHandleUpstreamErrorBlocks() {
     DataSchema outSchema = new DataSchema(new String[]{"group", "sum"}, new 
ColumnDataType[]{INT, DOUBLE});
     AggregateOperator operator =
         new AggregateOperator(OperatorTestUtil.getDefaultContext(), _input, 
outSchema, inSchema, calls, group,
-            AggType.INTERMEDIATE, null, null);
+            AggType.DIRECT, Collections.singletonList(-1), null);

Review Comment:
   INTERMEDIATE is not testing the whole flow. I want to test the aggregate as 
well as the merge



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to