[GitHub] [pinot] KKcorps commented on a diff in pull request #10326: Provide results in CompletableFuture for java clients and expose metrics

2023-02-24 Thread via GitHub
KKcorps commented on code in PR #10326: URL: https://github.com/apache/pinot/pull/10326#discussion_r1117872339 ## pinot-clients/pinot-java-client/src/main/java/org/apache/pinot/client/JsonAsyncHttpPinotClientTransport.java: ## @@ -134,11 +137,23 @@ public Future executeQueryAsyn

[GitHub] [pinot] KKcorps commented on pull request #10326: Provide results in CompletableFuture for java clients and expose metrics

2023-02-24 Thread via GitHub
KKcorps commented on PR #10326: URL: https://github.com/apache/pinot/pull/10326#issuecomment-1445004652 For now, just add it in the PR description. We can add them to docs later on. Example should be of just using CompletableFuture to process pinot response along with handling error respons

[pinot] branch master updated: enable readonly access to controller UI for users without table restrictions (#10329)

2023-02-24 Thread apucher
This is an automated email from the ASF dual-hosted git repository. apucher pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 3772b55dc4 enable readonly access to controller

[GitHub] [pinot] apucher merged pull request #10329: enable readonly access to controller UI for users without table restrictions

2023-02-24 Thread via GitHub
apucher merged PR #10329: URL: https://github.com/apache/pinot/pull/10329 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apac

[GitHub] [pinot] andimiller commented on a diff in pull request #10328: Add HLL and Theta Aggregation support in Merge/Rollup

2023-02-24 Thread via GitHub
andimiller commented on code in PR #10328: URL: https://github.com/apache/pinot/pull/10328#discussion_r1117849079 ## pinot-core/src/main/java/org/apache/pinot/core/segment/processing/aggregator/ValueAggregatorFactory.java: ## @@ -40,6 +40,10 @@ public static ValueAggregator get

[GitHub] [pinot] andimiller commented on a diff in pull request #10328: Add Raw HLL and Raw Theta Aggregation support in Merge/Rollup

2023-02-24 Thread via GitHub
andimiller commented on code in PR #10328: URL: https://github.com/apache/pinot/pull/10328#discussion_r1117848213 ## pinot-core/src/main/java/org/apache/pinot/core/segment/processing/aggregator/ValueAggregatorFactory.java: ## @@ -40,6 +40,10 @@ public static ValueAggregator get

[GitHub] [pinot] andimiller commented on a diff in pull request #10328: Add Raw HLL and Raw Theta Aggregation support in Merge/Rollup

2023-02-24 Thread via GitHub
andimiller commented on code in PR #10328: URL: https://github.com/apache/pinot/pull/10328#discussion_r1117824208 ## pinot-core/src/main/java/org/apache/pinot/core/segment/processing/aggregator/ValueAggregatorFactory.java: ## @@ -40,6 +40,10 @@ public static ValueAggregator get

[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #10328: Add Raw HLL and Raw Theta Aggregation support in Merge/Rollup

2023-02-24 Thread via GitHub
Jackie-Jiang commented on code in PR #10328: URL: https://github.com/apache/pinot/pull/10328#discussion_r1117848009 ## pinot-core/src/main/java/org/apache/pinot/core/segment/processing/aggregator/ValueAggregatorFactory.java: ## @@ -40,6 +40,10 @@ public static ValueAggregator g

[pinot] branch master updated (1f726dc6fc -> e8c04d454c)

2023-02-24 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from 1f726dc6fc Fix the missing BIG_DECIMAL handling in range predicate evaluator (#10330) add e8c04d454c [multistage]

[GitHub] [pinot] Jackie-Jiang merged pull request #10340: [multistage] Fix Flaky OpChainSchedulerServiceTest

2023-02-24 Thread via GitHub
Jackie-Jiang merged PR #10340: URL: https://github.com/apache/pinot/pull/10340 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

[GitHub] [pinot] Jackie-Jiang closed issue #10339: [Flaky test] OpChainSchedulerServiceTest

2023-02-24 Thread via GitHub
Jackie-Jiang closed issue #10339: [Flaky test] OpChainSchedulerServiceTest URL: https://github.com/apache/pinot/issues/10339 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [pinot] codecov-commenter commented on pull request #10340: [multistage] Fix Flaky OpChainSchedulerServiceTest

2023-02-24 Thread via GitHub
codecov-commenter commented on PR #10340: URL: https://github.com/apache/pinot/pull/10340#issuecomment-1444796881 # [Codecov](https://codecov.io/gh/apache/pinot/pull/10340?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Soft

[GitHub] [pinot] andimiller commented on a diff in pull request #10328: Add Raw HLL and Raw Theta Aggregation support in Merge/Rollup

2023-02-24 Thread via GitHub
andimiller commented on code in PR #10328: URL: https://github.com/apache/pinot/pull/10328#discussion_r1117824798 ## pinot-core/src/main/java/org/apache/pinot/core/segment/processing/aggregator/ValueAggregatorFactory.java: ## @@ -40,6 +40,10 @@ public static ValueAggregator get

[GitHub] [pinot] andimiller commented on a diff in pull request #10328: Add Raw HLL and Raw Theta Aggregation support in Merge/Rollup

2023-02-24 Thread via GitHub
andimiller commented on code in PR #10328: URL: https://github.com/apache/pinot/pull/10328#discussion_r1117824208 ## pinot-core/src/main/java/org/apache/pinot/core/segment/processing/aggregator/ValueAggregatorFactory.java: ## @@ -40,6 +40,10 @@ public static ValueAggregator get

[GitHub] [pinot] ankitsultana opened a new pull request, #10340: [multistage] Fix Flaky OpChainSchedulerServiceTest | fixes #10339

2023-02-24 Thread via GitHub
ankitsultana opened a new pull request, #10340: URL: https://github.com/apache/pinot/pull/10340 The test occasionally fails because the deregister call is made after the cancellation, and we only wait for the cancel call to be completed. This also waits on the deregister call to be finished

[GitHub] [pinot] ankitsultana commented on issue #10339: [Flaky test] OpChainSchedulerServiceTest

2023-02-24 Thread via GitHub
ankitsultana commented on issue #10339: URL: https://github.com/apache/pinot/issues/10339#issuecomment-1444707082 Ack. Will take a look. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[GitHub] [pinot] Jackie-Jiang commented on issue #10339: [Flaky test] OpChainSchedulerServiceTest

2023-02-24 Thread via GitHub
Jackie-Jiang commented on issue #10339: URL: https://github.com/apache/pinot/issues/10339#issuecomment-1444699781 @61yao -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [pinot] Jackie-Jiang opened a new issue, #10339: [Flaky test] OpChainSchedulerServiceTest

2023-02-24 Thread via GitHub
Jackie-Jiang opened a new issue, #10339: URL: https://github.com/apache/pinot/issues/10339 Example run: https://github.com/apache/pinot/actions/runs/4266643576/jobs/7427410628 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [pinot] apucher commented on a diff in pull request #10329: enable readonly access to controller UI for users without table restrictions

2023-02-24 Thread via GitHub
apucher commented on code in PR #10329: URL: https://github.com/apache/pinot/pull/10329#discussion_r1117792305 ## pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotControllerAuthResource.java: ## @@ -74,6 +74,11 @@ public class PinotControllerAuthReso

[pinot] branch auth-enable-readonly-access-controller-ui updated (95b73d30fc -> fcf1114d1b)

2023-02-24 Thread apucher
This is an automated email from the ASF dual-hosted git repository. apucher pushed a change to branch auth-enable-readonly-access-controller-ui in repository https://gitbox.apache.org/repos/asf/pinot.git from 95b73d30fc enable readonly access to controller UI for users without table restric

[GitHub] [pinot] KKcorps commented on pull request #10337: Add Statistics grouped at Stage ID level in the V2 Engine Response

2023-02-24 Thread via GitHub
KKcorps commented on PR #10337: URL: https://github.com/apache/pinot/pull/10337#issuecomment-1444629390 > Excited to see this. @KKcorps : Can you confirm if this also uses `OpChainStats` in any way? I was wondering if we could also track queued time in these stats later. Not right no

[GitHub] [pinot] Jackie-Jiang commented on issue #10313: API for Rebalance Status

2023-02-24 Thread via GitHub
Jackie-Jiang commented on issue #10313: URL: https://github.com/apache/pinot/issues/10313#issuecomment-1444623797 > @Jackie-Jiang We can run a rebalance with `dryRun = true` and check the status when the API is invoked? That is possible, but there is also a corner case as following:

[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #10329: enable readonly access to controller UI for users without table restrictions

2023-02-24 Thread via GitHub
Jackie-Jiang commented on code in PR #10329: URL: https://github.com/apache/pinot/pull/10329#discussion_r1117782524 ## pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotControllerAuthResource.java: ## @@ -74,6 +74,11 @@ public class PinotControllerAut

[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #10234: Add support for multiple comparison columns (i.e. one comparison column per producer sinking to a table)

2023-02-24 Thread via GitHub
Jackie-Jiang commented on code in PR #10234: URL: https://github.com/apache/pinot/pull/10234#discussion_r1117748110 ## pinot-spi/src/main/java/org/apache/pinot/spi/config/table/UpsertConfig.java: ## @@ -154,10 +135,22 @@ public void setDefaultPartialUpsertStrategy(Strategy defa

[GitHub] [pinot] ankitsultana commented on pull request #10337: Add Statistics grouped at Stage ID level in the V2 Engine Response

2023-02-24 Thread via GitHub
ankitsultana commented on PR #10337: URL: https://github.com/apache/pinot/pull/10337#issuecomment-1444610934 Excited to see this. @KKcorps : Can you confirm if this also uses `OpChainStats` in any way? I was wondering if we could also track queued time in these stats later. -- This is an

[GitHub] [pinot] cbalci commented on a diff in pull request #10321: Refactor Spark Connector into two modules for reusability

2023-02-24 Thread via GitHub
cbalci commented on code in PR #10321: URL: https://github.com/apache/pinot/pull/10321#discussion_r1117753596 ## pinot-connectors/pinot-spark-common/src/main/java/org/apache/pinot/connector/spark/common/CaseInsensitiveStringMap.java: ## @@ -0,0 +1,201 @@ +/** Review Comment:

[GitHub] [pinot] cbalci commented on a diff in pull request #10321: Refactor Spark Connector into two modules for reusability

2023-02-24 Thread via GitHub
cbalci commented on code in PR #10321: URL: https://github.com/apache/pinot/pull/10321#discussion_r1117753596 ## pinot-connectors/pinot-spark-common/src/main/java/org/apache/pinot/connector/spark/common/CaseInsensitiveStringMap.java: ## @@ -0,0 +1,201 @@ +/** Review Comment:

[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #10328: Add Raw HLL and Raw Theta Aggregation support in Merge/Rollup

2023-02-24 Thread via GitHub
Jackie-Jiang commented on code in PR #10328: URL: https://github.com/apache/pinot/pull/10328#discussion_r1117743096 ## pinot-core/src/main/java/org/apache/pinot/core/segment/processing/aggregator/ValueAggregatorFactory.java: ## @@ -40,6 +40,10 @@ public static ValueAggregator g

[pinot] branch master updated: Fix the missing BIG_DECIMAL handling in range predicate evaluator (#10330)

2023-02-24 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 1f726dc6fc Fix the missing BIG_DECIMAL handling i

[GitHub] [pinot] Jackie-Jiang merged pull request #10330: Fix the missing BIG_DECIMAL handling in range predicate evaluator

2023-02-24 Thread via GitHub
Jackie-Jiang merged PR #10330: URL: https://github.com/apache/pinot/pull/10330 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

[GitHub] [pinot] somandal commented on a diff in pull request #10286: [multistage] Initial (phase 1) Query runtime for window functions - empty OVER() and OVER(PARTITION BY)

2023-02-24 Thread via GitHub
somandal commented on code in PR #10286: URL: https://github.com/apache/pinot/pull/10286#discussion_r1117709600 ## pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/WindowAggregateOperator.java: ## @@ -0,0 +1,436 @@ +/** + * Licensed to the Apache Softwar

[GitHub] [pinot] somandal commented on a diff in pull request #10286: [multistage] Initial (phase 1) Query runtime for window functions - empty OVER() and OVER(PARTITION BY)

2023-02-24 Thread via GitHub
somandal commented on code in PR #10286: URL: https://github.com/apache/pinot/pull/10286#discussion_r1117709259 ## pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/WindowAggregateOperator.java: ## @@ -0,0 +1,436 @@ +/** + * Licensed to the Apache Softwar

[GitHub] [pinot] somandal commented on a diff in pull request #10286: [multistage] Initial (phase 1) Query runtime for window functions - empty OVER() and OVER(PARTITION BY)

2023-02-24 Thread via GitHub
somandal commented on code in PR #10286: URL: https://github.com/apache/pinot/pull/10286#discussion_r1117708927 ## pinot-query-runtime/src/test/java/org/apache/pinot/query/runtime/QueryRunnerTestBase.java: ## @@ -364,6 +371,8 @@ public static class Query { public List> _o

[GitHub] [pinot] somandal commented on a diff in pull request #10286: [multistage] Initial (phase 1) Query runtime for window functions - empty OVER() and OVER(PARTITION BY)

2023-02-24 Thread via GitHub
somandal commented on code in PR #10286: URL: https://github.com/apache/pinot/pull/10286#discussion_r1117707764 ## pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/AggregateOperator.java: ## @@ -308,6 +303,20 @@ public Object merge(Object agg, Object val

[GitHub] [pinot] KKcorps commented on pull request #10337: Add Statistics grouped at Stage ID level in the V2 Engine Response

2023-02-24 Thread via GitHub
KKcorps commented on PR #10337: URL: https://github.com/apache/pinot/pull/10337#issuecomment-1444568672 I think **BrokerResponseStats** class can be made an extension of **BrokerResponseNative** class as well. Only differrence will be not having a resultTable plus having additional stage le

[GitHub] [pinot] ankitsultana closed pull request #9199: [colocated-join] Add Support for Deterministic Segment Assignment Strategy

2023-02-24 Thread via GitHub
ankitsultana closed pull request #9199: [colocated-join] Add Support for Deterministic Segment Assignment Strategy URL: https://github.com/apache/pinot/pull/9199 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[GitHub] [pinot] somandal commented on a diff in pull request #10286: [multistage] Initial (phase 1) Query runtime for window functions - empty OVER() and OVER(PARTITION BY)

2023-02-24 Thread via GitHub
somandal commented on code in PR #10286: URL: https://github.com/apache/pinot/pull/10286#discussion_r1117700153 ## pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/WindowAggregateOperator.java: ## @@ -0,0 +1,431 @@ +/** + * Licensed to the Apache Softwar

[GitHub] [pinot] ankitsultana commented on a diff in pull request #10286: [multistage] Initial (phase 1) Query runtime for window functions - empty OVER() and OVER(PARTITION BY)

2023-02-24 Thread via GitHub
ankitsultana commented on code in PR #10286: URL: https://github.com/apache/pinot/pull/10286#discussion_r1117697148 ## pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/WindowAggregateOperator.java: ## @@ -0,0 +1,431 @@ +/** + * Licensed to the Apache Sof

[GitHub] [pinot] somandal commented on a diff in pull request #10286: [multistage] Initial (phase 1) Query runtime for window functions - empty OVER() and OVER(PARTITION BY)

2023-02-24 Thread via GitHub
somandal commented on code in PR #10286: URL: https://github.com/apache/pinot/pull/10286#discussion_r1117685201 ## pinot-query-planner/src/main/java/org/apache/calcite/rel/rules/PinotWindowExchangeNodeInsertRule.java: ## @@ -160,6 +162,19 @@ private boolean isPartitionByOnlyQuer

[GitHub] [pinot] somandal commented on a diff in pull request #10286: [multistage] Initial (phase 1) Query runtime for window functions - empty OVER() and OVER(PARTITION BY)

2023-02-24 Thread via GitHub
somandal commented on code in PR #10286: URL: https://github.com/apache/pinot/pull/10286#discussion_r1117678564 ## pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/WindowAggregateOperator.java: ## @@ -0,0 +1,431 @@ +/** + * Licensed to the Apache Softwar

[GitHub] [pinot] cgenrich commented on pull request #10326: Provide results in CompletableFuture for java clients and expose metrics

2023-02-24 Thread via GitHub
cgenrich commented on PR #10326: URL: https://github.com/apache/pinot/pull/10326#issuecomment-156251 > Thanks a lot for the contribution! > > Can you also add an example in the PR on what changes a person should make to the caller code for better performance. Considering, the call

[GitHub] [pinot] cgenrich commented on a diff in pull request #10326: Provide results in CompletableFuture for java clients and expose metrics

2023-02-24 Thread via GitHub
cgenrich commented on code in PR #10326: URL: https://github.com/apache/pinot/pull/10326#discussion_r1117621491 ## pinot-clients/pinot-java-client/src/main/java/org/apache/pinot/client/JsonAsyncHttpPinotClientTransport.java: ## @@ -134,11 +137,23 @@ public Future executeQueryAsy

[GitHub] [pinot] cgenrich commented on a diff in pull request #10326: Provide results in CompletableFuture for java clients and expose metrics

2023-02-24 Thread via GitHub
cgenrich commented on code in PR #10326: URL: https://github.com/apache/pinot/pull/10326#discussion_r1117618131 ## pinot-clients/pinot-java-client/src/main/java/org/apache/pinot/client/PinotClientTransport.java: ## @@ -18,28 +18,38 @@ */ package org.apache.pinot.client; -im

[GitHub] [pinot] codecov-commenter commented on pull request #10338: [quickstart] configure the controller to schedule tasks when minion is enabled

2023-02-24 Thread via GitHub
codecov-commenter commented on PR #10338: URL: https://github.com/apache/pinot/pull/10338#issuecomment-1444306813 # [Codecov](https://codecov.io/gh/apache/pinot/pull/10338?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Soft

[GitHub] [pinot] somandal commented on a diff in pull request #10286: [multistage] Initial (phase 1) Query runtime for window functions - empty OVER() and OVER(PARTITION BY)

2023-02-24 Thread via GitHub
somandal commented on code in PR #10286: URL: https://github.com/apache/pinot/pull/10286#discussion_r1117478600 ## pinot-query-planner/src/main/java/org/apache/calcite/rel/rules/PinotWindowExchangeNodeInsertRule.java: ## @@ -160,6 +162,19 @@ private boolean isPartitionByOnlyQuer

[GitHub] [pinot] somandal commented on a diff in pull request #10286: [multistage] Initial (phase 1) Query runtime for window functions - empty OVER() and OVER(PARTITION BY)

2023-02-24 Thread via GitHub
somandal commented on code in PR #10286: URL: https://github.com/apache/pinot/pull/10286#discussion_r1117478600 ## pinot-query-planner/src/main/java/org/apache/calcite/rel/rules/PinotWindowExchangeNodeInsertRule.java: ## @@ -160,6 +162,19 @@ private boolean isPartitionByOnlyQuer

[GitHub] [pinot] zhtaoxiang opened a new pull request, #10338: [quickstart] configure the controller to schedule tasks when minion is enabled

2023-02-24 Thread via GitHub
zhtaoxiang opened a new pull request, #10338: URL: https://github.com/apache/pinot/pull/10338 Without this configuration, controller will not run cron jobs to schedule minion tasks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [pinot] walterddr commented on a diff in pull request #10286: [multistage] Initial (phase 1) Query runtime for window functions - empty OVER() and OVER(PARTITION BY)

2023-02-24 Thread via GitHub
walterddr commented on code in PR #10286: URL: https://github.com/apache/pinot/pull/10286#discussion_r1117427355 ## pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/AggregateOperator.java: ## @@ -308,6 +303,20 @@ public Object merge(Object agg, Object va

[GitHub] [pinot] KKcorps commented on pull request #10326: Provide results in CompletableFuture for java clients and expose metrics

2023-02-24 Thread via GitHub
KKcorps commented on PR #10326: URL: https://github.com/apache/pinot/pull/10326#issuecomment-1444152392 Thanks a lot for the contribution! Can you also add an example in the PR on what changes a person should make to the caller code for better performance. Considering, the caller now

[GitHub] [pinot] KKcorps commented on a diff in pull request #10326: Provide results in CompletableFuture for java clients and expose metrics

2023-02-24 Thread via GitHub
KKcorps commented on code in PR #10326: URL: https://github.com/apache/pinot/pull/10326#discussion_r1117408073 ## pinot-clients/pinot-java-client/src/main/java/org/apache/pinot/client/JsonAsyncHttpPinotClientTransport.java: ## @@ -134,11 +137,23 @@ public Future executeQueryAsyn

[GitHub] [pinot] KKcorps commented on a diff in pull request #10326: Provide results in CompletableFuture for java clients and expose metrics

2023-02-24 Thread via GitHub
KKcorps commented on code in PR #10326: URL: https://github.com/apache/pinot/pull/10326#discussion_r1117403802 ## pinot-clients/pinot-java-client/src/main/java/org/apache/pinot/client/PinotClientTransport.java: ## @@ -18,28 +18,38 @@ */ package org.apache.pinot.client; -imp

[GitHub] [pinot] codecov-commenter commented on pull request #10337: Add Statistics grouped at Stage ID level in the V2 Engine Response

2023-02-24 Thread via GitHub
codecov-commenter commented on PR #10337: URL: https://github.com/apache/pinot/pull/10337#issuecomment-1443768255 # [Codecov](https://codecov.io/gh/apache/pinot/pull/10337?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Soft

[GitHub] [pinot] KKcorps opened a new pull request, #10337: Add Statistics grouped at Stage ID level in the V2 Engine Response

2023-02-24 Thread via GitHub
KKcorps opened a new pull request, #10337: URL: https://github.com/apache/pinot/pull/10337 Currently, we only return aggregated statistics in the broker response. This already helps out in debugging performance issues. However, stats aggregated at stage level will be much more useful beca

[GitHub] [pinot] codecov-commenter commented on pull request #10336: [Multistage] Allow queries on multiple tables of same tenant to be executed from controller UI

2023-02-24 Thread via GitHub
codecov-commenter commented on PR #10336: URL: https://github.com/apache/pinot/pull/10336#issuecomment-1443428591 # [Codecov](https://codecov.io/gh/apache/pinot/pull/10336?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Soft

[GitHub] [pinot] codecov-commenter commented on pull request #10335: append UUID to segment name in SegmentGenerationAndPushTask

2023-02-24 Thread via GitHub
codecov-commenter commented on PR #10335: URL: https://github.com/apache/pinot/pull/10335#issuecomment-1443415319 # [Codecov](https://codecov.io/gh/apache/pinot/pull/10335?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Soft

[GitHub] [pinot] tibrewalpratik17 opened a new pull request, #10336: [Multistage] Allow queries on multiple tables of same tenant to be executed from controller UI

2023-02-24 Thread via GitHub
tibrewalpratik17 opened a new pull request, #10336: URL: https://github.com/apache/pinot/pull/10336 At present, via Controller UI we can only execute multistage queries on DefaultTenant. This patch checks if the tables queried are having atleast one common tenant and allows queries to be ex

[GitHub] [pinot] zhtaoxiang opened a new pull request, #10335: append UUID to segment name in SegmentGenerationAndPushTask

2023-02-24 Thread via GitHub
zhtaoxiang opened a new pull request, #10335: URL: https://github.com/apache/pinot/pull/10335 In SegmentGenerationAndPushTask, the SEQUENCE_ID used to identify each segment is only unique to each round of task generation. Across multiple rounds of task generation, the SEQUENCE_ID can be the

[GitHub] [pinot] npawar commented on pull request #10255: Allow replica group assignment support in tier configs

2023-02-24 Thread via GitHub
npawar commented on PR #10255: URL: https://github.com/apache/pinot/pull/10255#issuecomment-1443292650 > This PR adds support for specifying `instanceAssignmentConfig` within TierConfig to be able to assign segments honouring desired assignment configs when tiering them out. As of now, tier

[GitHub] [pinot] ankitsultana opened a new pull request, #10334: [multistage] Handle Table Names Without Type Suffix in Colocation

2023-02-24 Thread via GitHub
ankitsultana opened a new pull request, #10334: URL: https://github.com/apache/pinot/pull/10334 Previously we were skipping colocation in this case which caused a bit of confusion with some users. -- This is an automated message from the Apache Git Service. To respond to the message, plea