KKcorps commented on code in PR #10326:
URL: https://github.com/apache/pinot/pull/10326#discussion_r1117872339
##
pinot-clients/pinot-java-client/src/main/java/org/apache/pinot/client/JsonAsyncHttpPinotClientTransport.java:
##
@@ -134,11 +137,23 @@ public Future executeQueryAsyn
KKcorps commented on PR #10326:
URL: https://github.com/apache/pinot/pull/10326#issuecomment-1445004652
For now, just add it in the PR description. We can add them to docs later
on. Example should be of just using CompletableFuture to process pinot response
along with handling error respons
This is an automated email from the ASF dual-hosted git repository.
apucher pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 3772b55dc4 enable readonly access to controller
apucher merged PR #10329:
URL: https://github.com/apache/pinot/pull/10329
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apac
andimiller commented on code in PR #10328:
URL: https://github.com/apache/pinot/pull/10328#discussion_r1117849079
##
pinot-core/src/main/java/org/apache/pinot/core/segment/processing/aggregator/ValueAggregatorFactory.java:
##
@@ -40,6 +40,10 @@ public static ValueAggregator
get
andimiller commented on code in PR #10328:
URL: https://github.com/apache/pinot/pull/10328#discussion_r1117848213
##
pinot-core/src/main/java/org/apache/pinot/core/segment/processing/aggregator/ValueAggregatorFactory.java:
##
@@ -40,6 +40,10 @@ public static ValueAggregator
get
andimiller commented on code in PR #10328:
URL: https://github.com/apache/pinot/pull/10328#discussion_r1117824208
##
pinot-core/src/main/java/org/apache/pinot/core/segment/processing/aggregator/ValueAggregatorFactory.java:
##
@@ -40,6 +40,10 @@ public static ValueAggregator
get
Jackie-Jiang commented on code in PR #10328:
URL: https://github.com/apache/pinot/pull/10328#discussion_r1117848009
##
pinot-core/src/main/java/org/apache/pinot/core/segment/processing/aggregator/ValueAggregatorFactory.java:
##
@@ -40,6 +40,10 @@ public static ValueAggregator
g
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
from 1f726dc6fc Fix the missing BIG_DECIMAL handling in range predicate
evaluator (#10330)
add e8c04d454c [multistage]
Jackie-Jiang merged PR #10340:
URL: https://github.com/apache/pinot/pull/10340
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
Jackie-Jiang closed issue #10339: [Flaky test] OpChainSchedulerServiceTest
URL: https://github.com/apache/pinot/issues/10339
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
codecov-commenter commented on PR #10340:
URL: https://github.com/apache/pinot/pull/10340#issuecomment-1444796881
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/10340?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Soft
andimiller commented on code in PR #10328:
URL: https://github.com/apache/pinot/pull/10328#discussion_r1117824798
##
pinot-core/src/main/java/org/apache/pinot/core/segment/processing/aggregator/ValueAggregatorFactory.java:
##
@@ -40,6 +40,10 @@ public static ValueAggregator
get
andimiller commented on code in PR #10328:
URL: https://github.com/apache/pinot/pull/10328#discussion_r1117824208
##
pinot-core/src/main/java/org/apache/pinot/core/segment/processing/aggregator/ValueAggregatorFactory.java:
##
@@ -40,6 +40,10 @@ public static ValueAggregator
get
ankitsultana opened a new pull request, #10340:
URL: https://github.com/apache/pinot/pull/10340
The test occasionally fails because the deregister call is made after the
cancellation, and we only wait for the cancel call to be completed. This also
waits on the deregister call to be finished
ankitsultana commented on issue #10339:
URL: https://github.com/apache/pinot/issues/10339#issuecomment-1444707082
Ack. Will take a look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
Jackie-Jiang commented on issue #10339:
URL: https://github.com/apache/pinot/issues/10339#issuecomment-1444699781
@61yao
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
Jackie-Jiang opened a new issue, #10339:
URL: https://github.com/apache/pinot/issues/10339
Example run:
https://github.com/apache/pinot/actions/runs/4266643576/jobs/7427410628
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
apucher commented on code in PR #10329:
URL: https://github.com/apache/pinot/pull/10329#discussion_r1117792305
##
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotControllerAuthResource.java:
##
@@ -74,6 +74,11 @@ public class PinotControllerAuthReso
This is an automated email from the ASF dual-hosted git repository.
apucher pushed a change to branch auth-enable-readonly-access-controller-ui
in repository https://gitbox.apache.org/repos/asf/pinot.git
from 95b73d30fc enable readonly access to controller UI for users without
table restric
KKcorps commented on PR #10337:
URL: https://github.com/apache/pinot/pull/10337#issuecomment-1444629390
> Excited to see this. @KKcorps : Can you confirm if this also uses
`OpChainStats` in any way? I was wondering if we could also track queued time
in these stats later.
Not right no
Jackie-Jiang commented on issue #10313:
URL: https://github.com/apache/pinot/issues/10313#issuecomment-1444623797
> @Jackie-Jiang We can run a rebalance with `dryRun = true` and check the
status when the API is invoked?
That is possible, but there is also a corner case as following:
Jackie-Jiang commented on code in PR #10329:
URL: https://github.com/apache/pinot/pull/10329#discussion_r1117782524
##
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotControllerAuthResource.java:
##
@@ -74,6 +74,11 @@ public class PinotControllerAut
Jackie-Jiang commented on code in PR #10234:
URL: https://github.com/apache/pinot/pull/10234#discussion_r1117748110
##
pinot-spi/src/main/java/org/apache/pinot/spi/config/table/UpsertConfig.java:
##
@@ -154,10 +135,22 @@ public void setDefaultPartialUpsertStrategy(Strategy
defa
ankitsultana commented on PR #10337:
URL: https://github.com/apache/pinot/pull/10337#issuecomment-1444610934
Excited to see this. @KKcorps : Can you confirm if this also uses
`OpChainStats` in any way? I was wondering if we could also track queued time
in these stats later.
--
This is an
cbalci commented on code in PR #10321:
URL: https://github.com/apache/pinot/pull/10321#discussion_r1117753596
##
pinot-connectors/pinot-spark-common/src/main/java/org/apache/pinot/connector/spark/common/CaseInsensitiveStringMap.java:
##
@@ -0,0 +1,201 @@
+/**
Review Comment:
cbalci commented on code in PR #10321:
URL: https://github.com/apache/pinot/pull/10321#discussion_r1117753596
##
pinot-connectors/pinot-spark-common/src/main/java/org/apache/pinot/connector/spark/common/CaseInsensitiveStringMap.java:
##
@@ -0,0 +1,201 @@
+/**
Review Comment:
Jackie-Jiang commented on code in PR #10328:
URL: https://github.com/apache/pinot/pull/10328#discussion_r1117743096
##
pinot-core/src/main/java/org/apache/pinot/core/segment/processing/aggregator/ValueAggregatorFactory.java:
##
@@ -40,6 +40,10 @@ public static ValueAggregator
g
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 1f726dc6fc Fix the missing BIG_DECIMAL handling i
Jackie-Jiang merged PR #10330:
URL: https://github.com/apache/pinot/pull/10330
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
somandal commented on code in PR #10286:
URL: https://github.com/apache/pinot/pull/10286#discussion_r1117709600
##
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/WindowAggregateOperator.java:
##
@@ -0,0 +1,436 @@
+/**
+ * Licensed to the Apache Softwar
somandal commented on code in PR #10286:
URL: https://github.com/apache/pinot/pull/10286#discussion_r1117709259
##
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/WindowAggregateOperator.java:
##
@@ -0,0 +1,436 @@
+/**
+ * Licensed to the Apache Softwar
somandal commented on code in PR #10286:
URL: https://github.com/apache/pinot/pull/10286#discussion_r1117708927
##
pinot-query-runtime/src/test/java/org/apache/pinot/query/runtime/QueryRunnerTestBase.java:
##
@@ -364,6 +371,8 @@ public static class Query {
public List> _o
somandal commented on code in PR #10286:
URL: https://github.com/apache/pinot/pull/10286#discussion_r1117707764
##
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/AggregateOperator.java:
##
@@ -308,6 +303,20 @@ public Object merge(Object agg, Object val
KKcorps commented on PR #10337:
URL: https://github.com/apache/pinot/pull/10337#issuecomment-1444568672
I think **BrokerResponseStats** class can be made an extension of
**BrokerResponseNative** class as well. Only differrence will be not having a
resultTable plus having additional stage le
ankitsultana closed pull request #9199: [colocated-join] Add Support for
Deterministic Segment Assignment Strategy
URL: https://github.com/apache/pinot/pull/9199
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo
somandal commented on code in PR #10286:
URL: https://github.com/apache/pinot/pull/10286#discussion_r1117700153
##
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/WindowAggregateOperator.java:
##
@@ -0,0 +1,431 @@
+/**
+ * Licensed to the Apache Softwar
ankitsultana commented on code in PR #10286:
URL: https://github.com/apache/pinot/pull/10286#discussion_r1117697148
##
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/WindowAggregateOperator.java:
##
@@ -0,0 +1,431 @@
+/**
+ * Licensed to the Apache Sof
somandal commented on code in PR #10286:
URL: https://github.com/apache/pinot/pull/10286#discussion_r1117685201
##
pinot-query-planner/src/main/java/org/apache/calcite/rel/rules/PinotWindowExchangeNodeInsertRule.java:
##
@@ -160,6 +162,19 @@ private boolean isPartitionByOnlyQuer
somandal commented on code in PR #10286:
URL: https://github.com/apache/pinot/pull/10286#discussion_r1117678564
##
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/WindowAggregateOperator.java:
##
@@ -0,0 +1,431 @@
+/**
+ * Licensed to the Apache Softwar
cgenrich commented on PR #10326:
URL: https://github.com/apache/pinot/pull/10326#issuecomment-156251
> Thanks a lot for the contribution!
>
> Can you also add an example in the PR on what changes a person should make
to the caller code for better performance. Considering, the call
cgenrich commented on code in PR #10326:
URL: https://github.com/apache/pinot/pull/10326#discussion_r1117621491
##
pinot-clients/pinot-java-client/src/main/java/org/apache/pinot/client/JsonAsyncHttpPinotClientTransport.java:
##
@@ -134,11 +137,23 @@ public Future executeQueryAsy
cgenrich commented on code in PR #10326:
URL: https://github.com/apache/pinot/pull/10326#discussion_r1117618131
##
pinot-clients/pinot-java-client/src/main/java/org/apache/pinot/client/PinotClientTransport.java:
##
@@ -18,28 +18,38 @@
*/
package org.apache.pinot.client;
-im
codecov-commenter commented on PR #10338:
URL: https://github.com/apache/pinot/pull/10338#issuecomment-1444306813
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/10338?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Soft
somandal commented on code in PR #10286:
URL: https://github.com/apache/pinot/pull/10286#discussion_r1117478600
##
pinot-query-planner/src/main/java/org/apache/calcite/rel/rules/PinotWindowExchangeNodeInsertRule.java:
##
@@ -160,6 +162,19 @@ private boolean isPartitionByOnlyQuer
somandal commented on code in PR #10286:
URL: https://github.com/apache/pinot/pull/10286#discussion_r1117478600
##
pinot-query-planner/src/main/java/org/apache/calcite/rel/rules/PinotWindowExchangeNodeInsertRule.java:
##
@@ -160,6 +162,19 @@ private boolean isPartitionByOnlyQuer
zhtaoxiang opened a new pull request, #10338:
URL: https://github.com/apache/pinot/pull/10338
Without this configuration, controller will not run cron jobs to schedule
minion tasks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Gi
walterddr commented on code in PR #10286:
URL: https://github.com/apache/pinot/pull/10286#discussion_r1117427355
##
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/AggregateOperator.java:
##
@@ -308,6 +303,20 @@ public Object merge(Object agg, Object va
KKcorps commented on PR #10326:
URL: https://github.com/apache/pinot/pull/10326#issuecomment-1444152392
Thanks a lot for the contribution!
Can you also add an example in the PR on what changes a person should make
to the caller code for better performance. Considering, the caller now
KKcorps commented on code in PR #10326:
URL: https://github.com/apache/pinot/pull/10326#discussion_r1117408073
##
pinot-clients/pinot-java-client/src/main/java/org/apache/pinot/client/JsonAsyncHttpPinotClientTransport.java:
##
@@ -134,11 +137,23 @@ public Future executeQueryAsyn
KKcorps commented on code in PR #10326:
URL: https://github.com/apache/pinot/pull/10326#discussion_r1117403802
##
pinot-clients/pinot-java-client/src/main/java/org/apache/pinot/client/PinotClientTransport.java:
##
@@ -18,28 +18,38 @@
*/
package org.apache.pinot.client;
-imp
codecov-commenter commented on PR #10337:
URL: https://github.com/apache/pinot/pull/10337#issuecomment-1443768255
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/10337?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Soft
KKcorps opened a new pull request, #10337:
URL: https://github.com/apache/pinot/pull/10337
Currently, we only return aggregated statistics in the broker response. This
already helps out in debugging performance issues. However, stats aggregated
at stage level will be much more useful beca
codecov-commenter commented on PR #10336:
URL: https://github.com/apache/pinot/pull/10336#issuecomment-1443428591
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/10336?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Soft
codecov-commenter commented on PR #10335:
URL: https://github.com/apache/pinot/pull/10335#issuecomment-1443415319
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/10335?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Soft
tibrewalpratik17 opened a new pull request, #10336:
URL: https://github.com/apache/pinot/pull/10336
At present, via Controller UI we can only execute multistage queries on
DefaultTenant. This patch checks if the tables queried are having atleast one
common tenant and allows queries to be ex
zhtaoxiang opened a new pull request, #10335:
URL: https://github.com/apache/pinot/pull/10335
In SegmentGenerationAndPushTask, the SEQUENCE_ID used to identify each
segment is only unique to each round of task generation. Across multiple rounds
of task generation, the SEQUENCE_ID can be the
npawar commented on PR #10255:
URL: https://github.com/apache/pinot/pull/10255#issuecomment-1443292650
> This PR adds support for specifying `instanceAssignmentConfig` within
TierConfig to be able to assign segments honouring desired assignment configs
when tiering them out. As of now, tier
ankitsultana opened a new pull request, #10334:
URL: https://github.com/apache/pinot/pull/10334
Previously we were skipping colocation in this case which caused a bit of
confusion with some users.
--
This is an automated message from the Apache Git Service.
To respond to the message, plea
59 matches
Mail list logo