Jackie-Jiang commented on code in PR #10329: URL: https://github.com/apache/pinot/pull/10329#discussion_r1117782524
########## pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotControllerAuthResource.java: ########## @@ -74,6 +74,11 @@ public class PinotControllerAuthResource { public boolean verify(@ApiParam(value = "Table name without type") @QueryParam("tableName") String tableName, @ApiParam(value = "API access type") @QueryParam("accessType") AccessType accessType, @ApiParam(value = "Endpoint URL") @QueryParam("endpointUrl") String endpointUrl) { + + if (accessType == null) { Review Comment: Should we just add `@DefaultValue("READ")` to the `accessType` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org