somandal commented on code in PR #10286:
URL: https://github.com/apache/pinot/pull/10286#discussion_r1117707764
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/AggregateOperator.java:
##########
@@ -308,6 +303,20 @@ public Object merge(Object agg, Object value) {
}
}
+ private static class MergeCounts implements Merger {
+
+ @Override
+ public Object initialize(Object other, DataSchema.ColumnDataType dataType)
{
+ return other == null ? 0 : 1;
+ }
+
+ @Override
+ public Object merge(Object left, Object ignored) {
+ // TODO: COUNT(*) doesn't need to parse right object until we support
NULL
+ return ((Number) left).doubleValue() + 1;
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
