andimiller commented on code in PR #10328: URL: https://github.com/apache/pinot/pull/10328#discussion_r1117824208
########## pinot-core/src/main/java/org/apache/pinot/core/segment/processing/aggregator/ValueAggregatorFactory.java: ########## @@ -40,6 +40,10 @@ public static ValueAggregator getValueAggregator(AggregationFunctionType aggrega return new MaxValueAggregator(dataType); case SUM: return new SumValueAggregator(dataType); + case DISTINCTCOUNTRAWHLL: Review Comment: does that make sense? I thought these aggregators were for rolling up values in a column without changing types, so eg. `BYTES` -> `BYTES`, is it possible to change the column type here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org