somandal commented on code in PR #10286:
URL: https://github.com/apache/pinot/pull/10286#discussion_r1117685201
##########
pinot-query-planner/src/main/java/org/apache/calcite/rel/rules/PinotWindowExchangeNodeInsertRule.java:
##########
@@ -160,6 +162,19 @@ private boolean isPartitionByOnlyQuery(Window.Group
windowGroup) {
Set<Integer> partitionByKeyList = new
HashSet<>(windowGroup.keys.toList());
Set<Integer> orderByKeyList = new
HashSet<>(windowGroup.orderKeys.getKeys());
isPartitionByOnly = partitionByKeyList.equals(orderByKeyList);
+ if (isPartitionByOnly) {
Review Comment:
@walterddr should I go ahead and remove this check?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
