[pinot] branch master updated (10ebfa51ef -> 93fa0e72e5)

This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from 10ebfa51ef adding rows with error to docker metrics config (#10075) add 93fa0e72e5 Fixing the issue that S3PinotF

[GitHub] [pinot] xiangfu0 merged pull request #10078: Fixing the issue that S3PinotFS cannot open a file > 2GB

xiangfu0 merged PR #10078: URL: https://github.com/apache/pinot/pull/10078 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apa

[GitHub] [pinot] elonazoulay commented on issue #10073: Segment build fails with null value for time column

elonazoulay commented on issue #10073: URL: https://github.com/apache/pinot/issues/10073#issuecomment-1374349611 Thanks for responding @Jackie-Jiang ! I tried that and create segment is fine but upload segment still invokes the check regardless. lmk what you think: would it be worth it to

[GitHub] [pinot] deemoliu commented on a diff in pull request #10052: Add an API to download validDocIdsSnapshots from peer servers

deemoliu commented on code in PR #10052: URL: https://github.com/apache/pinot/pull/10052#discussion_r1063933545 ## pinot-server/src/main/java/org/apache/pinot/server/api/resources/TablesResource.java: ## @@ -423,6 +414,83 @@ public Response downloadSegment( } } + /**

[GitHub] [pinot] deemoliu commented on a diff in pull request #10052: Add an API to download validDocIdsSnapshots from peer servers

deemoliu commented on code in PR #10052: URL: https://github.com/apache/pinot/pull/10052#discussion_r1063933578 ## pinot-server/src/main/java/org/apache/pinot/server/api/resources/TablesResource.java: ## @@ -423,6 +411,74 @@ public Response downloadSegment( } } + /**

[GitHub] [pinot] deemoliu commented on a diff in pull request #10052: Add an API to download validDocIdsSnapshots from peer servers

deemoliu commented on code in PR #10052: URL: https://github.com/apache/pinot/pull/10052#discussion_r1063933449 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/indexsegment/immutable/ImmutableSegmentImpl.java: ## @@ -150,7 +150,7 @@ public void deleteValidDoc

[GitHub] [pinot] npawar commented on a diff in pull request #10071: fix(ui): show query result along with error message if both exist

npawar commented on code in PR #10071: URL: https://github.com/apache/pinot/pull/10071#discussion_r1063927607 ## pinot-controller/src/main/resources/app/utils/PinotMethodUtils.ts: ## @@ -272,15 +272,13 @@ const getQueryResults = (params) => { // if sql api throws error, han

[GitHub] [pinot] klsince commented on a diff in pull request #10077: Add an option to reduce random access by caching fields of visited nodes when doing BFS over StarTree index

klsince commented on code in PR #10077: URL: https://github.com/apache/pinot/pull/10077#discussion_r1063925350 ## pinot-spi/src/main/java/org/apache/pinot/spi/utils/CommonConstants.java: ## @@ -280,6 +280,7 @@ public static class QueryOptionKey { public static final Str

[GitHub] [pinot] klsince commented on a diff in pull request #10077: Add an option to reduce random access by caching fields of visited nodes when doing BFS over StarTree index

klsince commented on code in PR #10077: URL: https://github.com/apache/pinot/pull/10077#discussion_r1063925289 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/startree/OffHeapStarTreeNode.java: ## @@ -39,11 +39,13 @@ public class OffHeapStarTreeNode implement

[GitHub] [pinot] Jackie-Jiang commented on issue #10073: Segment build fails with null value for time column

Jackie-Jiang commented on issue #10073: URL: https://github.com/apache/pinot/issues/10073#issuecomment-1374324677 One workaround would be to turn the validation off (there is a flag in table config). But in regular case people should not ingest records with timestamp in 1970. The underlying

[GitHub] [pinot] codecov-commenter commented on pull request #10078: Fixing the issue that S3PinotFS cannot open a file > 2GB

codecov-commenter commented on PR #10078: URL: https://github.com/apache/pinot/pull/10078#issuecomment-1374318148 # [Codecov](https://codecov.io/gh/apache/pinot/pull/10078?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Soft

[GitHub] [pinot] elonazoulay commented on issue #10073: Segment build fails with null value for time column

elonazoulay commented on issue #10073: URL: https://github.com/apache/pinot/issues/10073#issuecomment-1374312345 Ah ok, thanks! So how does someone insert values where the epoch milli is 0? It fails the validation. -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #10074: add realtime consumption exception to LL consumer data manager metrics

Jackie-Jiang commented on code in PR #10074: URL: https://github.com/apache/pinot/pull/10074#discussion_r1063906583 ## pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/LLRealtimeSegmentDataManager.java: ## @@ -420,6 +423,9 @@ protected boolean consumeLoop()

[GitHub] [pinot] Jackie-Jiang commented on issue #10073: Segment build fails with null value for time column

Jackie-Jiang commented on issue #10073: URL: https://github.com/apache/pinot/issues/10073#issuecomment-1374299266 It is intentional to prevent users from putting the wrong time unit. E.g. if the time value is `daysSinceEpoch`, but user mistakenly put `MILLISECONDS` as the time unit, this

[GitHub] [pinot] joshigaurava commented on a diff in pull request #10071: fix(ui): show query result along with error message if both exist

joshigaurava commented on code in PR #10071: URL: https://github.com/apache/pinot/pull/10071#discussion_r1063902631 ## pinot-controller/src/main/resources/app/utils/PinotMethodUtils.ts: ## @@ -272,15 +272,13 @@ const getQueryResults = (params) => { // if sql api throws erro

[GitHub] [pinot] joshigaurava commented on pull request #10071: fix(ui): show query result along with error message if both exist

joshigaurava commented on PR #10071: URL: https://github.com/apache/pinot/pull/10071#issuecomment-1374288227 Ok, so code wise exception is at the top (first thing handled) except that the logic seems to be display nothing else if there is an exception. Let's keep that structure and also ref

[GitHub] [pinot] joshigaurava commented on pull request #10071: fix(ui): show query result along with error message if both exist

joshigaurava commented on PR #10071: URL: https://github.com/apache/pinot/pull/10071#issuecomment-1374285557 @jayeshchoudhary what happens if there are multiple rows to be displayed in the result? 1) Is that a valid use case? 2. If yes, is there a chance that the exception gets pushed down

[GitHub] [pinot] mcvsubbu commented on a diff in pull request #9994: [feature] Add a Tracker class to support aggregate-worst case consumption delay…

mcvsubbu commented on code in PR #9994: URL: https://github.com/apache/pinot/pull/9994#discussion_r1063872683 ## pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/IngestionDelayTracker.java: ## @@ -0,0 +1,371 @@ +/** + * Licensed to the Apache Software Foundat

[GitHub] [pinot] richardstartin commented on a diff in pull request #8764: Vectorize predicates over full col filter scans

richardstartin commented on code in PR #8764: URL: https://github.com/apache/pinot/pull/8764#discussion_r880647573 ## pinot-core/src/main/java/org/apache/pinot/core/operator/dociditerators/SVScanDocIdIterator.java: ## @@ -55,6 +58,33 @@ public SVScanDocIdIterator(PredicateEvalua

[GitHub] [pinot] klsince commented on a diff in pull request #10077: Add an option to cache fields of visited nodes while doing BFS over StarTree index

klsince commented on code in PR #10077: URL: https://github.com/apache/pinot/pull/10077#discussion_r1063863732 ## pinot-spi/src/main/java/org/apache/pinot/spi/utils/CommonConstants.java: ## @@ -280,6 +280,7 @@ public static class QueryOptionKey { public static final Str

[GitHub] [pinot] klsince commented on a diff in pull request #10077: Add an option to cache fields of visited nodes while doing BFS over StarTree index

klsince commented on code in PR #10077: URL: https://github.com/apache/pinot/pull/10077#discussion_r1063862763 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/startree/OffHeapStarTreeNode.java: ## @@ -39,11 +39,13 @@ public class OffHeapStarTreeNode implement

[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #10047: [WIP] Add upsert ttl configs for Pinot upsert optimizations

Jackie-Jiang commented on code in PR #10047: URL: https://github.com/apache/pinot/pull/10047#discussion_r1063860563 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/BasePartitionUpsertMetadataManager.java: ## @@ -217,6 +226,17 @@ public void replaceSegm

[GitHub] [pinot] codecov-commenter commented on pull request #10077: Add an option to cache fields of visited nodes while doing BFS over StarTree index

codecov-commenter commented on PR #10077: URL: https://github.com/apache/pinot/pull/10077#issuecomment-1374228184 # [Codecov](https://codecov.io/gh/apache/pinot/pull/10077?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Soft

[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #10052: Add an API to download validDocIdsSnapshots from peer servers

Jackie-Jiang commented on code in PR #10052: URL: https://github.com/apache/pinot/pull/10052#discussion_r1063848896 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/indexsegment/immutable/ImmutableSegmentImpl.java: ## @@ -150,7 +150,7 @@ public void deleteVali

[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #10077: Add an option to cache fields of visited nodes while doing BFS over StarTree index

Jackie-Jiang commented on code in PR #10077: URL: https://github.com/apache/pinot/pull/10077#discussion_r1063842531 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/startree/CachedStarTreeNode.java: ## @@ -0,0 +1,114 @@ +/** + * Licensed to the Apache Software

[GitHub] [pinot] klsince opened a new pull request, #10077: Add an option to cache fields of visited nodes while doing BFS over StarTree index

klsince opened a new pull request, #10077: URL: https://github.com/apache/pinot/pull/10077 Add a query option `scanStarTreeNodesOnHeap` to turn on/off whether to cache the tree node's fields in object fields when traversing the StarTree index. Caching node's fields can avoid probing the und

[GitHub] [pinot] mcvsubbu commented on a diff in pull request #9994: [feature] Add a Tracker class to support aggregate-worst case consumption delay…

mcvsubbu commented on code in PR #9994: URL: https://github.com/apache/pinot/pull/9994#discussion_r1063836862 ## pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/ConsumptionDelayTracker.java: ## @@ -0,0 +1,361 @@ +/** + * Licensed to the Apache Software Found

[GitHub] [pinot] shwin commented on issue #7130: Add a partialResults flag in Response metadata

shwin commented on issue #7130: URL: https://github.com/apache/pinot/issues/7130#issuecomment-1374145632 I think this would be helpful for us too, assuming that (2) would also cover the case in which segments have been generated and pushed, but servers are still downloading (or whatever the

[GitHub] [pinot] shwin opened a new issue, #10076: Indicate Partial Response when Servers have not loaded all

shwin opened a new issue, #10076: URL: https://github.com/apache/pinot/issues/10076 We have observed the following behavior: 1. We have an OFFLINE table 2. We load 1000 segments via the SegmentGenerationAndPush minion-based task; they are about 500MB each 3. The minions finish all t

[GitHub] [pinot] Jackie-Jiang commented on issue #10069: Add a controller API to reflect whether force commit is finished

Jackie-Jiang commented on issue #10069: URL: https://github.com/apache/pinot/issues/10069#issuecomment-1374107384 @sajjad-moradi This is a good work around, and I think we should make this check automatic so that user doesn't need to implement this extra logic. This logic is very similar to

[GitHub] [pinot] snleee commented on issue #10070: [Question] Is it possible to insert thrift data into pinot through stream ingestion?

snleee commented on issue #10070: URL: https://github.com/apache/pinot/issues/10070#issuecomment-1374073928 @ruhz3 We currently have the message decoder implementation for CSV, AVRO, JSON, PROTOBUF. Is it an option for you to change your Kafka stream to be based on one of formats that we su

[pinot] branch master updated: adding rows with error to docker metrics config (#10075)

This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 10ebfa51ef adding rows with error to docker metri

[GitHub] [pinot] Jackie-Jiang merged pull request #10075: [metric] adding rows with error to docker metrics config

Jackie-Jiang merged PR #10075: URL: https://github.com/apache/pinot/pull/10075 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

[pinot] branch range-index-equals-queries updated (f9c51af191 -> 37899aa054)

This is an automated email from the ASF dual-hosted git repository. richardstartin pushed a change to branch range-index-equals-queries in repository https://gitbox.apache.org/repos/asf/pinot.git omit f9c51af191 move predicate evaluators to shorten class names omit c3ae06a99c refinements

[GitHub] [pinot] walterddr commented on a diff in pull request #10074: add realtime consumption exception to LL consumer data manager metrics

walterddr commented on code in PR #10074: URL: https://github.com/apache/pinot/pull/10074#discussion_r106371 ## pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/LLRealtimeSegmentDataManager.java: ## @@ -489,6 +489,9 @@ protected boolean consumeLoop()

[pinot] branch master updated: upgrade to RoaringBitmap 0.9.38 (#10072)

This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 04d09e5986 upgrade to RoaringBitmap 0.9.38 (#1007

[GitHub] [pinot] Jackie-Jiang merged pull request #10072: upgrade to RoaringBitmap 0.9.38

Jackie-Jiang merged PR #10072: URL: https://github.com/apache/pinot/pull/10072 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #10074: add realtime consumption exception to LL consumer data manager metrics

Jackie-Jiang commented on code in PR #10074: URL: https://github.com/apache/pinot/pull/10074#discussion_r1063707998 ## pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/LLRealtimeSegmentDataManager.java: ## @@ -489,6 +489,9 @@ protected boolean consumeLoop()

[GitHub] [pinot] codecov-commenter commented on pull request #10074: add realtime consumption exception to LL consumer data manager metrics

codecov-commenter commented on PR #10074: URL: https://github.com/apache/pinot/pull/10074#issuecomment-1374003582 # [Codecov](https://codecov.io/gh/apache/pinot/pull/10074?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Soft

[pinot] branch master updated (782c3c2df5 -> 2a9c8b61ca)

This is an automated email from the ASF dual-hosted git repository. siddteotia pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from 782c3c2df5 Remove ConvertToRawIndexTask (#10068) add 2a9c8b61ca Optimize TableRebalancer to not always recompu

[GitHub] [pinot] siddharthteotia merged pull request #10031: Optimize TableRebalancer to not always recompute target assignment when IS changes

siddharthteotia merged PR #10031: URL: https://github.com/apache/pinot/pull/10031 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pi

[GitHub] [pinot] siddharthteotia commented on a diff in pull request #10054: Add DistinctSum aggregation function

siddharthteotia commented on code in PR #10054: URL: https://github.com/apache/pinot/pull/10054#discussion_r1063680461 ## pinot-core/src/test/java/org/apache/pinot/queries/InterSegmentAggregationSingleValueQueriesTest.java: ## @@ -568,4 +568,32 @@ public void testNumGroupsLimit(

[GitHub] [pinot] elonazoulay opened a new issue, #10073: Segment build fails with null value for time column

elonazoulay opened a new issue, #10073: URL: https://github.com/apache/pinot/issues/10073 Happy New Year! We noticed that creating a segment fails due to TimeUtils.VALID_MIN_TIME_MILLIS being 1971/01/01 instead of 1970/01/01, i.e. 0 epoch millis. Is this intended? Context: The

[GitHub] [pinot] codecov-commenter commented on pull request #10072: upgrade to RoaringBitmap 0.9.38

codecov-commenter commented on PR #10072: URL: https://github.com/apache/pinot/pull/10072#issuecomment-1373940043 # [Codecov](https://codecov.io/gh/apache/pinot/pull/10072?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Soft

[GitHub] [pinot] richardstartin opened a new pull request, #10072: upgrade to RoaringBitmap 0.9.38

richardstartin opened a new pull request, #10072: URL: https://github.com/apache/pinot/pull/10072 Contains a bug fix for the timestamp index, see release notes https://github.com/RoaringBitmap/RoaringBitmap/releases/tag/0.9.38 -- This is an automated message from the Apache Git Service. T

[pinot] branch upgrade-roaringbitmap created (now 9dfefe1e3a)

This is an automated email from the ASF dual-hosted git repository. richardstartin pushed a change to branch upgrade-roaringbitmap in repository https://gitbox.apache.org/repos/asf/pinot.git at 9dfefe1e3a upgrade to RoaringBitmap 0.9.38 This branch includes the following new commits:

[pinot] 01/01: upgrade to RoaringBitmap 0.9.38

This is an automated email from the ASF dual-hosted git repository. richardstartin pushed a commit to branch upgrade-roaringbitmap in repository https://gitbox.apache.org/repos/asf/pinot.git commit 9dfefe1e3afbdff222bc9632bbfaef51d2a89ca3 Author: Richard Startin AuthorDate: Fri Jan 6 16:57:17 20

[GitHub] [pinot] walterddr commented on a diff in pull request #10045: add checkpointing support to flink connector

walterddr commented on code in PR #10045: URL: https://github.com/apache/pinot/pull/10045#discussion_r1063605992 ## pinot-connectors/pinot-flink-connector/src/main/java/org/apache/pinot/connector/flink/sink/PinotSinkFunction.java: ## @@ -117,31 +123,22 @@ public void close()

[GitHub] [pinot] walterddr commented on a diff in pull request #10045: add checkpointing support to flink connector

walterddr commented on code in PR #10045: URL: https://github.com/apache/pinot/pull/10045#discussion_r1063605992 ## pinot-connectors/pinot-flink-connector/src/main/java/org/apache/pinot/connector/flink/sink/PinotSinkFunction.java: ## @@ -117,31 +123,22 @@ public void close()

[GitHub] [pinot] walterddr commented on a diff in pull request #10045: add checkpointing support to flink connector

walterddr commented on code in PR #10045: URL: https://github.com/apache/pinot/pull/10045#discussion_r1063604999 ## pinot-connectors/pinot-flink-connector/src/main/java/org/apache/pinot/connector/flink/sink/PinotSinkFunction.java: ## @@ -117,31 +123,22 @@ public void close()

[GitHub] [pinot] walterddr commented on a diff in pull request #10045: add checkpointing support to flink connector

walterddr commented on code in PR #10045: URL: https://github.com/apache/pinot/pull/10045#discussion_r1063598717 ## pinot-connectors/pinot-flink-connector/src/main/java/org/apache/pinot/connector/flink/sink/PinotSinkFunction.java: ## @@ -151,4 +148,18 @@ private void flush()

[GitHub] [pinot] walterddr commented on a diff in pull request #10045: add checkpointing support to flink connector

walterddr commented on code in PR #10045: URL: https://github.com/apache/pinot/pull/10045#discussion_r1063598717 ## pinot-connectors/pinot-flink-connector/src/main/java/org/apache/pinot/connector/flink/sink/PinotSinkFunction.java: ## @@ -151,4 +148,18 @@ private void flush()

[GitHub] [pinot] walterddr commented on a diff in pull request #10045: add checkpointing support to flink connector

walterddr commented on code in PR #10045: URL: https://github.com/apache/pinot/pull/10045#discussion_r1063598717 ## pinot-connectors/pinot-flink-connector/src/main/java/org/apache/pinot/connector/flink/sink/PinotSinkFunction.java: ## @@ -151,4 +148,18 @@ private void flush()

[GitHub] [pinot] snleee commented on a diff in pull request #10045: add checkpointing support to flink connector

snleee commented on code in PR #10045: URL: https://github.com/apache/pinot/pull/10045#discussion_r1063592772 ## pinot-connectors/pinot-flink-connector/src/main/java/org/apache/pinot/connector/flink/sink/PinotSinkFunction.java: ## @@ -151,4 +148,18 @@ private void flush()

[pinot] branch master updated: Remove ConvertToRawIndexTask (#10068)

This is an automated email from the ASF dual-hosted git repository. snlee pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 782c3c2df5 Remove ConvertToRawIndexTask (#10068) 7

[GitHub] [pinot] snleee merged pull request #10068: [Cleanup] Remove ConvertToRawIndexTask

snleee merged PR #10068: URL: https://github.com/apache/pinot/pull/10068 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apach

[GitHub] [pinot] codecov-commenter commented on pull request #10071: fix(ui): show query result along with error message if both exist

codecov-commenter commented on PR #10071: URL: https://github.com/apache/pinot/pull/10071#issuecomment-1373819500 # [Codecov](https://codecov.io/gh/apache/pinot/pull/10071?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Soft

[GitHub] [pinot] jayeshchoudhary opened a new pull request, #10071: fix(ui): show query result along with error message if both exist

jayeshchoudhary opened a new pull request, #10071: URL: https://github.com/apache/pinot/pull/10071 ### Issue - when running a sql query, if the api result contains both `exceptions` as well as `resultTable` then ideally UI should show both - instead UI is showing only exceptions -

[GitHub] [pinot] bobby-richard commented on a diff in pull request #10045: add checkpointing support to flink connector

bobby-richard commented on code in PR #10045: URL: https://github.com/apache/pinot/pull/10045#discussion_r1063467126 ## pinot-connectors/pinot-flink-connector/src/main/java/org/apache/pinot/connector/flink/sink/PinotSinkFunction.java: ## @@ -151,4 +148,18 @@ private void flush()

[GitHub] [pinot] bobby-richard commented on a diff in pull request #10045: add checkpointing support to flink connector

bobby-richard commented on code in PR #10045: URL: https://github.com/apache/pinot/pull/10045#discussion_r1063463950 ## pinot-connectors/pinot-flink-connector/src/main/java/org/apache/pinot/connector/flink/sink/PinotSinkFunction.java: ## @@ -117,31 +123,22 @@ public void close()

[GitHub] [pinot] bobby-richard commented on a diff in pull request #10045: add checkpointing support to flink connector

bobby-richard commented on code in PR #10045: URL: https://github.com/apache/pinot/pull/10045#discussion_r1063462740 ## pinot-connectors/pinot-flink-connector/src/main/java/org/apache/pinot/connector/flink/sink/PinotSinkFunction.java: ## @@ -117,31 +123,22 @@ public void close()

[GitHub] [pinot] richardstartin commented on a diff in pull request #10043: evaluate EQ queries against range index when available

richardstartin commented on code in PR #10043: URL: https://github.com/apache/pinot/pull/10043#discussion_r1063374698 ## pinot-core/src/main/java/org/apache/pinot/core/operator/filter/RangeIndexBasedFilterOperator.java: ## @@ -124,38 +137,102 @@ public List getChildOperators() {

[GitHub] [pinot] richardstartin commented on a diff in pull request #10043: evaluate EQ queries against range index when available

richardstartin commented on code in PR #10043: URL: https://github.com/apache/pinot/pull/10043#discussion_r1063363939 ## pinot-core/src/main/java/org/apache/pinot/core/operator/filter/RangeIndexBasedFilterOperator.java: ## @@ -131,27 +139,75 @@ public String toExplainString() {

[pinot] branch range-index-equals-queries updated (c3ae06a99c -> f9c51af191)

This is an automated email from the ASF dual-hosted git repository. richardstartin pushed a change to branch range-index-equals-queries in repository https://gitbox.apache.org/repos/asf/pinot.git from c3ae06a99c refinements add f9c51af191 move predicate evaluators to shorten class names

[GitHub] [pinot] richardstartin commented on a diff in pull request #10043: evaluate EQ queries against range index when available

richardstartin commented on code in PR #10043: URL: https://github.com/apache/pinot/pull/10043#discussion_r1063353961 ## pinot-core/src/main/java/org/apache/pinot/core/operator/filter/RangeIndexBasedFilterOperator.java: ## @@ -131,27 +139,75 @@ public String toExplainString() {

[pinot] branch range-index-equals-queries updated (23c977d613 -> c3ae06a99c)

This is an automated email from the ASF dual-hosted git repository. richardstartin pushed a change to branch range-index-equals-queries in repository https://gitbox.apache.org/repos/asf/pinot.git omit 23c977d613 refinements add c3ae06a99c refinements This update added new revisions aft

[pinot] branch range-index-equals-queries updated (96ea1bfa13 -> 23c977d613)

This is an automated email from the ASF dual-hosted git repository. richardstartin pushed a change to branch range-index-equals-queries in repository https://gitbox.apache.org/repos/asf/pinot.git from 96ea1bfa13 evaluate EQ queries against range index when available add 23c977d613 refin

[GitHub] [pinot] richardstartin commented on a diff in pull request #10043: evaluate EQ queries against range index when available

richardstartin commented on code in PR #10043: URL: https://github.com/apache/pinot/pull/10043#discussion_r1063272372 ## pinot-core/src/main/java/org/apache/pinot/core/operator/filter/RangeIndexBasedFilterOperator.java: ## @@ -131,27 +139,75 @@ public String toExplainString() {

[GitHub] [pinot] richardstartin commented on a diff in pull request #10043: evaluate EQ queries against range index when available

richardstartin commented on code in PR #10043: URL: https://github.com/apache/pinot/pull/10043#discussion_r1063271581 ## pinot-core/src/main/java/org/apache/pinot/core/operator/filter/RangeIndexBasedFilterOperator.java: ## @@ -131,27 +139,75 @@ public String toExplainString() {

[GitHub] [pinot] richardstartin commented on a diff in pull request #10043: evaluate EQ queries against range index when available

richardstartin commented on code in PR #10043: URL: https://github.com/apache/pinot/pull/10043#discussion_r1063269463 ## pinot-core/src/main/java/org/apache/pinot/core/operator/filter/RangeIndexBasedFilterOperator.java: ## @@ -131,27 +139,75 @@ public String toExplainString() {

[GitHub] [pinot] richardstartin commented on pull request #10044: push utf8 comparison down into ValueReader

richardstartin commented on PR #10044: URL: https://github.com/apache/pinot/pull/10044#issuecomment-1373383973 > > I think @klsince's question needs addressing - what happens when there are two invalid UTF8 sequences at the mismatch, can we return 0 spuriously, I'll address that before merg