siddharthteotia commented on code in PR #10054:
URL: https://github.com/apache/pinot/pull/10054#discussion_r1063680461
##########
pinot-core/src/test/java/org/apache/pinot/queries/InterSegmentAggregationSingleValueQueriesTest.java:
##########
@@ -568,4 +568,32 @@ public void testNumGroupsLimit() {
InstancePlanMakerImplV2.DEFAULT_GROUPBY_TRIM_THRESHOLD));
assertTrue(brokerResponse.isNumGroupsLimitReached());
}
+
+ @Test
+ public void testDistinctSum() {
+ String query = "select DISTINCTSUM(column1) as v1, DISTINCTSUM(column3) as
v2 from testTable";
+
+ // Without filter, query should be answered by
DictionaryBasedAggregationOperator (numEntriesScannedPostFilter = 0)
Review Comment:
Can you add a test for EXPLAIN PLAN as well using this function especially
for the dictionary based case ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
