Jackie-Jiang commented on code in PR #10074:
URL: https://github.com/apache/pinot/pull/10074#discussion_r1063707998
##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/LLRealtimeSegmentDataManager.java:
##########
@@ -489,6 +489,9 @@ protected boolean consumeLoop()
}
if (_numRowsErrored > 0) {
+
_serverMetrics.addMeteredGlobalValue(ServerMeter.REALTIME_CONSUMPTION_EXCEPTIONS,
_numRowsErrored);
Review Comment:
I don't think this is the correct place to update the meter. This meter is
used to track the consume exception, `_numRowsErrored` is used to track the
invalid rows. IMO we should update the meter under the catch on line 422 and 425
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
