walterddr commented on code in PR #10045:
URL: https://github.com/apache/pinot/pull/10045#discussion_r1063605992
##########
pinot-connectors/pinot-flink-connector/src/main/java/org/apache/pinot/connector/flink/sink/PinotSinkFunction.java:
##########
@@ -117,31 +123,22 @@ public void close()
@Override
public void invoke(T value, Context context)
throws Exception {
- _segmentWriter.collect(_recordConverter.convertToRow(value));
+ GenericRow row = _recordConverter.convertToRow(value);
+ _pendingRows.add(row);
+ _segmentWriter.collect(row);
Review Comment:
yeah. i misspoke. i meant to use "clearer" not "easier". it is definitely
not easier to implement as you mentioned. let's keep it this way. but we should
document that the rows are dual copied inside the PinotSinkFunction.
and potentially fix in follow ups, so we don't have 2 copies of the same row
in memory
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
