[GitHub] [pinot] klsince commented on a diff in pull request #10077: Add an option to reduce random access by caching fields of visited nodes when doing BFS over StarTree index

[GitBox]

klsince commented on code in PR #10077:
URL: https://github.com/apache/pinot/pull/10077#discussion_r1063925289


##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/startree/OffHeapStarTreeNode.java:
##########
@@ -39,11 +39,13 @@ public class OffHeapStarTreeNode implements StarTreeNode {
   private final PinotDataBuffer _dataBuffer;
   private final int _nodeId;
   private final int _firstChildId;
+  private final int _lastChildId;

Review Comment:
   Looks like _lastChildId is needed to keep the abstraction clean to delegate 
calls from CachedStarTreeNode to OffHeapStarTreeNode. This extra int field 
doesn't add more overhead considering the object memory layout.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org