npawar commented on code in PR #10071:
URL: https://github.com/apache/pinot/pull/10071#discussion_r1063927607
##########
pinot-controller/src/main/resources/app/utils/PinotMethodUtils.ts:
##########
@@ -272,15 +272,13 @@ const getQueryResults = (params) => {
// if sql api throws error, handle here
if(typeof queryResponse === 'string'){
errorStr = queryResponse;
- } else if (queryResponse && queryResponse.exceptions &&
queryResponse.exceptions.length) {
+ }
+ if (queryResponse && queryResponse.exceptions &&
queryResponse.exceptions.length) {
errorStr = JSON.stringify(queryResponse.exceptions, null, 2);
Review Comment:
wouldnt say it's intentional.But i'm guessing it is done so, because 1)
there can be multiple exceptions in this list 2) we also want to display error
code. But if a better UX is possible here without losing all these, that works
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
