[GitHub] [pinot] codecov-commenter commented on pull request #8725: Cache polygon h3 cells as it is expensive

2022-05-17 Thread GitBox
codecov-commenter commented on PR #8725: URL: https://github.com/apache/pinot/pull/8725#issuecomment-1129637224 # [Codecov](https://codecov.io/gh/apache/pinot/pull/8725?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Softwar

[GitHub] [pinot] KKcorps opened a new issue, #8726: Null data in derived columns after Table config update

2022-05-17 Thread GitBox
KKcorps opened a new issue, #8726: URL: https://github.com/apache/pinot/issues/8726 Steps to reproduce - 1. Add schema ``` { "schemaName": "tSCalibrationRecord", "dimensionFieldSpecs": [ { "name": "deviceId", "dataType": "STRING"

[GitHub] [pinot] saurabhd336 commented on a diff in pull request #8663: Realtime table consumption resume API

2022-05-17 Thread GitBox
saurabhd336 commented on code in PR #8663: URL: https://github.com/apache/pinot/pull/8663#discussion_r875514876 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java: ## @@ -1147,13 +1155,34 @@ IdealState ensureAllP

[GitHub] [pinot] WangCHX opened a new pull request, #8725: Cache polygon h3 cells as it is expensive

2022-05-17 Thread GitBox
WangCHX opened a new pull request, #8725: URL: https://github.com/apache/pinot/pull/8725 Instructions: 1. The PR has to be tagged with at least one of the following labels (*): `enhancement` -- This is an automated message from the Apache Git Service. To respond to the message

[GitHub] [pinot] npawar commented on issue #8409: Aggregation functions fail on String columns with unfriendly error messages

2022-05-17 Thread GitBox
npawar commented on issue #8409: URL: https://github.com/apache/pinot/issues/8409#issuecomment-1129616141 Picking this up (making the error message friendly part). While this fix (checking on broker side) may not be able to handle scalar functions case, I think it is still better than hav

[GitHub] [pinot] saurabhd336 commented on a diff in pull request #8663: Realtime table consumption resume API

2022-05-17 Thread GitBox
saurabhd336 commented on code in PR #8663: URL: https://github.com/apache/pinot/pull/8663#discussion_r875487714 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java: ## @@ -1069,6 +1073,10 @@ IdealState ensureAllPa

[GitHub] [pinot] saurabhd336 commented on a diff in pull request #8663: Realtime table consumption resume API

2022-05-17 Thread GitBox
saurabhd336 commented on code in PR #8663: URL: https://github.com/apache/pinot/pull/8663#discussion_r875483709 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java: ## @@ -862,7 +863,9 @@ private Map getLatestSeg

[GitHub] [pinot] saurabhd336 commented on a diff in pull request #8663: Realtime table consumption resume API

2022-05-17 Thread GitBox
saurabhd336 commented on code in PR #8663: URL: https://github.com/apache/pinot/pull/8663#discussion_r875482662 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java: ## @@ -862,7 +863,9 @@ private Map getLatestSeg

[GitHub] [pinot] saumya2700 commented on issue #8717: Data not getting consumed from all Kafka partitions

2022-05-17 Thread GitBox
saumya2700 commented on issue #8717: URL: https://github.com/apache/pinot/issues/8717#issuecomment-1129573667 I checked the server logs and not getting this kind of issues anywhere: _`[Consumer clientId=consumer-null-12, groupId=null] Fetch position FetchPosition{offset=5011308265, of

[GitHub] [pinot] Jackie-Jiang commented on pull request #8722: Improve the range evaluation for raw values without range index

2022-05-17 Thread GitBox
Jackie-Jiang commented on PR #8722: URL: https://github.com/apache/pinot/pull/8722#issuecomment-1129525090 Solved with `Math.nextUp()` and `Math.nextDown()` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[pinot] branch master updated: Ingestion Aggregation Feature (#8611)

2022-05-17 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new ae02ecefa4 Ingestion Aggregation Feature (#8611)

[GitHub] [pinot] Jackie-Jiang merged pull request #8611: Ingestion Aggregation Feature

2022-05-17 Thread GitBox
Jackie-Jiang merged PR #8611: URL: https://github.com/apache/pinot/pull/8611 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.a

[GitHub] [pinot] Jackie-Jiang commented on pull request #8722: Improve the range evaluation for raw values without range index

2022-05-17 Thread GitBox
Jackie-Jiang commented on PR #8722: URL: https://github.com/apache/pinot/pull/8722#issuecomment-1129471595 Seems it can cause wrong result for floating point values because `1.0 + Double.MIN_VALUE == 1.0` (lose precision). For the inclusive range we might need to allow some delta for floati

[GitHub] [pinot] jasperjiaguo opened a new pull request, #8724: [WIP]Add histogram aggregation function `feature`

2022-05-17 Thread GitBox
jasperjiaguo opened a new pull request, #8724: URL: https://github.com/apache/pinot/pull/8724 https://github.com/apache/pinot/issues/8493 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[pinot] branch master updated: Fix dimension table load when server restart or reload table (#8721)

2022-05-17 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new d2396dd983 Fix dimension table load when server r

[GitHub] [pinot] Jackie-Jiang merged pull request #8721: Fix dimension table load when server restart or reload table

2022-05-17 Thread GitBox
Jackie-Jiang merged PR #8721: URL: https://github.com/apache/pinot/pull/8721 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.a

[GitHub] [pinot] xiangfu0 opened a new issue, #8723: Make Pinot minion stateless service

2022-05-17 Thread GitBox
xiangfu0 opened a new issue, #8723: URL: https://github.com/apache/pinot/issues/8723 Ideally minion should be a K8s deployment instead of statefulset. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [pinot] codecov-commenter commented on pull request #8722: Improve the range evaluation for raw values without range index

2022-05-17 Thread GitBox
codecov-commenter commented on PR #8722: URL: https://github.com/apache/pinot/pull/8722#issuecomment-1129426088 # [Codecov](https://codecov.io/gh/apache/pinot/pull/8722?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Softwar

[GitHub] [pinot] navina commented on a diff in pull request #8721: Fix dimension table load when server restart or reload table

2022-05-17 Thread GitBox
navina commented on code in PR #8721: URL: https://github.com/apache/pinot/pull/8721#discussion_r875355439 ## pinot-core/src/main/java/org/apache/pinot/core/data/manager/offline/DimensionTableDataManager.java: ## @@ -128,25 +128,26 @@ private void loadLookupTable() } while

[GitHub] [pinot] npawar commented on issue #8641: "Failed to generate Pinot segment for file" didn't throw an exception

2022-05-17 Thread GitBox
npawar commented on issue #8641: URL: https://github.com/apache/pinot/issues/8641#issuecomment-1129419117 @xingyc15 @kkrugler are either of you planning to pick this up? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [pinot] Jackie-Jiang opened a new pull request, #8722: Improve the range evaluation for raw values without range index

2022-05-17 Thread GitBox
Jackie-Jiang opened a new pull request, #8722: URL: https://github.com/apache/pinot/pull/8722 Borrow the same idea as in #8703, we can reflect the inclusiveness of the value bound through the comparison value to avoid extra per value if check. Also, if the lower bound comparison already fai

[pinot] branch helix-1.0 updated (d6a7135b75 -> 296e39f74f)

2022-05-17 Thread jlli
This is an automated email from the ASF dual-hosted git repository. jlli pushed a change to branch helix-1.0 in repository https://gitbox.apache.org/repos/asf/pinot.git discard d6a7135b75 Upgrade Helix to 1.0.2 add e788a0afc6 Fix when there're two index filter operator h3 inclusion index

[GitHub] [pinot] npawar commented on issue #8638: Buffer overflow exception in `VarByteChunkSVForwardIndexWriter` of Spark data push flow

2022-05-17 Thread GitBox
npawar commented on issue #8638: URL: https://github.com/apache/pinot/issues/8638#issuecomment-1129396574 @jasperjiaguo were you able to try with the fix? is this resolved for you? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[GitHub] [pinot] noon-stripe commented on a diff in pull request #8611: Ingestion Aggregation Feature

2022-05-17 Thread GitBox
noon-stripe commented on code in PR #8611: URL: https://github.com/apache/pinot/pull/8611#discussion_r875323123 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/utils/TableConfigUtils.java: ## @@ -306,15 +311,71 @@ public static void validateIngestionConfig(Ta

[GitHub] [pinot] Jackie-Jiang commented on pull request #8713: Allow table name with dots by a PinotConfiguration switch

2022-05-17 Thread GitBox
Jackie-Jiang commented on PR #8713: URL: https://github.com/apache/pinot/pull/8713#issuecomment-1129380053 Agree on using dot to connect db/namespace and table name and column name (this is the standard SQL syntax). The problem here is that we don't support db/namespace concept natively i

[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #8721: Fix dimension table load when server restart or reload table

2022-05-17 Thread GitBox
Jackie-Jiang commented on code in PR #8721: URL: https://github.com/apache/pinot/pull/8721#discussion_r875303678 ## pinot-core/src/main/java/org/apache/pinot/core/data/manager/offline/DimensionTableDataManager.java: ## @@ -128,25 +128,26 @@ private void loadLookupTable() }

[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #8611: Ingestion Aggregation Feature

2022-05-17 Thread GitBox
Jackie-Jiang commented on code in PR #8611: URL: https://github.com/apache/pinot/pull/8611#discussion_r875301392 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/utils/TableConfigUtils.java: ## @@ -306,15 +311,71 @@ public static void validateIngestionConfig(T

[GitHub] [pinot] apucher commented on pull request #8713: Allow table name with dots by a PinotConfiguration switch

2022-05-17 Thread GitBox
apucher commented on PR #8713: URL: https://github.com/apache/pinot/pull/8713#issuecomment-1129364660 There's precedence for using dots as separators across databases/schemas in MySQL, MSSQL, and others. It's tricky in the sense that underscores are much more commonly used in name tables. B

[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #8663: Realtime table consumption resume API

2022-05-17 Thread GitBox
Jackie-Jiang commented on code in PR #8663: URL: https://github.com/apache/pinot/pull/8663#discussion_r875297466 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java: ## @@ -1069,6 +1073,10 @@ IdealState ensureAllP

[pinot] 02/09: Add pinot-query-planner module (#8340)

2022-05-17 Thread rongr
This is an automated email from the ASF dual-hosted git repository. rongr pushed a commit to branch multi_stage_query_engine in repository https://gitbox.apache.org/repos/asf/pinot.git commit 8c8380005b6d833ee9d20ad83487aac1439e0019 Author: Rong Rong AuthorDate: Thu Mar 24 21:13:51 2022 -0700

[pinot] 09/09: [hotfix] multi stage engine serde (#8689)

2022-05-17 Thread rongr
This is an automated email from the ASF dual-hosted git repository. rongr pushed a commit to branch multi_stage_query_engine in repository https://gitbox.apache.org/repos/asf/pinot.git commit fa2b2fa7cfa5410b2d5d5451942d1404ab72209e Author: Rong Rong AuthorDate: Thu May 12 15:00:54 2022 -0700

[pinot] 06/09: fix rebase issue after PQL deprecation (#8652)

2022-05-17 Thread rongr
This is an automated email from the ASF dual-hosted git repository. rongr pushed a commit to branch multi_stage_query_engine in repository https://gitbox.apache.org/repos/asf/pinot.git commit 30bc434343aa5e662081a7a51d63d5003e0860b7 Author: Rong Rong AuthorDate: Fri May 6 09:33:34 2022 -0700

[pinot] 08/09: row/columnar compatible block (#8583)

2022-05-17 Thread rongr
This is an automated email from the ASF dual-hosted git repository. rongr pushed a commit to branch multi_stage_query_engine in repository https://gitbox.apache.org/repos/asf/pinot.git commit 2c07cb04e25c9fc506b144b157756bca9ee612ac Author: Rong Rong AuthorDate: Tue May 10 14:30:46 2022 -0700

[pinot] 05/09: add support for project/filter pushdown (#8558)

2022-05-17 Thread rongr
This is an automated email from the ASF dual-hosted git repository. rongr pushed a commit to branch multi_stage_query_engine in repository https://gitbox.apache.org/repos/asf/pinot.git commit 3b01b2dec835267abb7db59559270e427e8b3b7c Author: Rong Rong AuthorDate: Fri Apr 22 08:57:29 2022 -0700

[pinot] branch multi_stage_query_engine updated (08da4ee9e7 -> fa2b2fa7cf)

2022-05-17 Thread rongr
This is an automated email from the ASF dual-hosted git repository. rongr pushed a change to branch multi_stage_query_engine in repository https://gitbox.apache.org/repos/asf/pinot.git omit 08da4ee9e7 [hotfix] multi stage engine serde (#8689) omit 77b59bf9db row/columnar compatible block

[pinot] 04/09: Use proto for query plan serialization (#8479)

2022-05-17 Thread rongr
This is an automated email from the ASF dual-hosted git repository. rongr pushed a commit to branch multi_stage_query_engine in repository https://gitbox.apache.org/repos/asf/pinot.git commit c06bbfbaf3b357edb6b3a9d9e7d7c5284f8706dc Author: Rong Rong AuthorDate: Fri Apr 15 14:24:38 2022 -0700

[pinot] 01/09: make github action trigger on multi_stage_query_engine branch (#8342)

2022-05-17 Thread rongr
This is an automated email from the ASF dual-hosted git repository. rongr pushed a commit to branch multi_stage_query_engine in repository https://gitbox.apache.org/repos/asf/pinot.git commit 90e722a6b05e993f770451209d1ee08cae0b2e48 Author: Rong Rong AuthorDate: Mon Mar 14 10:02:56 2022 -0700

[pinot] 07/09: [hotfix] fix server discovery (#8664)

2022-05-17 Thread rongr
This is an automated email from the ASF dual-hosted git repository. rongr pushed a commit to branch multi_stage_query_engine in repository https://gitbox.apache.org/repos/asf/pinot.git commit 4d77924e5943c9b3d3ab5f7413a50eadbff7a169 Author: Rong Rong AuthorDate: Mon May 9 20:20:03 2022 -0700

[GitHub] [pinot] codecov-commenter commented on pull request #8721: Fix dimension table load when server restart or reload table

2022-05-17 Thread GitBox
codecov-commenter commented on PR #8721: URL: https://github.com/apache/pinot/pull/8721#issuecomment-1129348268 # [Codecov](https://codecov.io/gh/apache/pinot/pull/8721?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Softwar

[GitHub] [pinot] navina commented on a diff in pull request #8721: Fix dimension table load when server restart or reload table

2022-05-17 Thread GitBox
navina commented on code in PR #8721: URL: https://github.com/apache/pinot/pull/8721#discussion_r875264972 ## pinot-core/src/main/java/org/apache/pinot/core/data/manager/offline/DimensionTableDataManager.java: ## @@ -128,25 +128,26 @@ private void loadLookupTable() } while

[GitHub] [pinot] Jackie-Jiang commented on pull request #8713: Allow table name with dots by a PinotConfiguration switch

2022-05-17 Thread GitBox
Jackie-Jiang commented on PR #8713: URL: https://github.com/apache/pinot/pull/8713#issuecomment-1129335759 > it should be easy to parse the table name since it needs to be present in the FROM clause. I think the `.` convention is from the connector, and we don't have the database con

[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #8601: Add support for indexes during offline segment creation

2022-05-17 Thread GitBox
Jackie-Jiang commented on code in PR #8601: URL: https://github.com/apache/pinot/pull/8601#discussion_r875258083 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/creator/impl/SegmentColumnarIndexCreator.java: ## @@ -134,6 +139,20 @@ public void init(Se

[GitHub] [pinot] Jackie-Jiang opened a new pull request, #8721: Fix dimension table load when server restart or reload table

2022-05-17 Thread GitBox
Jackie-Jiang opened a new pull request, #8721: URL: https://github.com/apache/pinot/pull/8721 Currently `DimensionTableDataManager` overrides the `addSegment(File indexDir, IndexLoadingConfig indexLoadingConfig)` method to reload the lookup table, but this method is not always invoked when

[GitHub] [pinot] npawar commented on issue #8604: Getting Jackson infinite recursion error after sometime when using complexTypeConfig( FiledsTounnest)

2022-05-17 Thread GitBox
npawar commented on issue #8604: URL: https://github.com/apache/pinot/issues/8604#issuecomment-1129264331 what is the latest set of configs you're trying with? Have you added default value to the JSONPATHSTRING functions? When you reload segments, the transform function will break on older

[GitHub] [pinot] npawar commented on issue #8717: Data not getting consumed from all Kafka partitions

2022-05-17 Thread GitBox
npawar commented on issue #8717: URL: https://github.com/apache/pinot/issues/8717#issuecomment-1129258178 Neither of the PRs linked fix it cleanly. I think we should go with the 2nd approach https://github.com/apache/pinot/pull/8321/files but see if we can catch the exception and do it only

[GitHub] [pinot] npawar commented on issue #8717: Data not getting consumed from all Kafka partitions

2022-05-17 Thread GitBox
npawar commented on issue #8717: URL: https://github.com/apache/pinot/issues/8717#issuecomment-1129253444 @KKcorps this sounds similar to https://github.com/apache/pinot/issues/8219. This had happened because the server was down/consumption was lagging and the offset expired before it could

[GitHub] [pinot] saurabhd336 commented on a diff in pull request #8663: Realtime table consumption resume API

2022-05-17 Thread GitBox
saurabhd336 commented on code in PR #8663: URL: https://github.com/apache/pinot/pull/8663#discussion_r875180222 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java: ## @@ -1385,4 +1386,89 @@ public void uploadToDe

[pinot] branch master updated: Add pluggable client auth provider (#8670)

2022-05-17 Thread apucher
This is an automated email from the ASF dual-hosted git repository. apucher pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 2c3813bb97 Add pluggable client auth provider (#

[GitHub] [pinot] apucher merged pull request #8670: Add pluggable client auth provider

2022-05-17 Thread GitBox
apucher merged PR #8670: URL: https://github.com/apache/pinot/pull/8670 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache

[GitHub] [pinot] sajjad-moradi commented on a diff in pull request #8663: Realtime table consumption resume API

2022-05-17 Thread GitBox
sajjad-moradi commented on code in PR #8663: URL: https://github.com/apache/pinot/pull/8663#discussion_r875169202 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java: ## @@ -1385,4 +1386,89 @@ public void uploadTo

[GitHub] [pinot] codecov-commenter commented on pull request #8720: Merge Multistage Engine back to main

2022-05-17 Thread GitBox
codecov-commenter commented on PR #8720: URL: https://github.com/apache/pinot/pull/8720#issuecomment-1129197751 # [Codecov](https://codecov.io/gh/apache/pinot/pull/8720?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Softwar

[GitHub] [pinot] apucher commented on pull request #8713: Allow table name with dots by a PinotConfiguration switch

2022-05-17 Thread GitBox
apucher commented on PR #8713: URL: https://github.com/apache/pinot/pull/8713#issuecomment-1129190289 it should be easy to parse the table name since it needs to be present in the FROM clause. are nested field selects a thing yet? -- This is an automated message from the Apache Git

[GitHub] [pinot] Jackie-Jiang commented on pull request #8713: Allow table name with dots by a PinotConfiguration switch

2022-05-17 Thread GitBox
Jackie-Jiang commented on PR #8713: URL: https://github.com/apache/pinot/pull/8713#issuecomment-1129180510 @apucher Good point. Let me list down the things we are trying to handle with `.` and discuss a solution: - `SELECT ... FROM .` - `SELECT . FROM ...` In the future, we also wan

[GitHub] [pinot] noon-stripe commented on a diff in pull request #8611: Ingestion Aggregation Feature

2022-05-17 Thread GitBox
noon-stripe commented on code in PR #8611: URL: https://github.com/apache/pinot/pull/8611#discussion_r875133037 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/utils/TableConfigUtils.java: ## @@ -363,6 +424,25 @@ public static void validateIngestionConfig(Tab

[pinot] branch master updated: Remove big-decimal getters for lower/upper bound (#8712)

2022-05-17 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 3bbae6ef61 Remove big-decimal getters for lower/u

[GitHub] [pinot] Jackie-Jiang merged pull request #8712: Remove big-decimal getters for lower/upper bound

2022-05-17 Thread GitBox
Jackie-Jiang merged PR #8712: URL: https://github.com/apache/pinot/pull/8712 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.a

[GitHub] [pinot] saurabhd336 commented on a diff in pull request #8663: Realtime table consumption resume API

2022-05-17 Thread GitBox
saurabhd336 commented on code in PR #8663: URL: https://github.com/apache/pinot/pull/8663#discussion_r875073346 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java: ## @@ -1385,4 +1386,89 @@ public void uploadToDe

[GitHub] [pinot] noon-stripe commented on a diff in pull request #8611: Ingestion Aggregation Feature

2022-05-17 Thread GitBox
noon-stripe commented on code in PR #8611: URL: https://github.com/apache/pinot/pull/8611#discussion_r875071563 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/utils/TableConfigUtils.java: ## @@ -306,15 +311,71 @@ public static void validateIngestionConfig(Ta

[GitHub] [pinot] saurabhd336 commented on a diff in pull request #8663: Realtime table consumption resume API

2022-05-17 Thread GitBox
saurabhd336 commented on code in PR #8663: URL: https://github.com/apache/pinot/pull/8663#discussion_r875070916 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java: ## @@ -1385,4 +1386,89 @@ public void uploadToDe

[GitHub] [pinot] noon-stripe commented on a diff in pull request #8611: Ingestion Aggregation Feature

2022-05-17 Thread GitBox
noon-stripe commented on code in PR #8611: URL: https://github.com/apache/pinot/pull/8611#discussion_r875070266 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/utils/TableConfigUtils.java: ## @@ -306,15 +311,71 @@ public static void validateIngestionConfig(Ta

[GitHub] [pinot] noon-stripe commented on a diff in pull request #8611: Ingestion Aggregation Feature

2022-05-17 Thread GitBox
noon-stripe commented on code in PR #8611: URL: https://github.com/apache/pinot/pull/8611#discussion_r875068654 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/utils/TableConfigUtils.java: ## @@ -306,15 +311,71 @@ public static void validateIngestionConfig(Ta

[GitHub] [pinot] noon-stripe commented on a diff in pull request #8611: Ingestion Aggregation Feature

2022-05-17 Thread GitBox
noon-stripe commented on code in PR #8611: URL: https://github.com/apache/pinot/pull/8611#discussion_r875045890 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/indexsegment/mutable/MutableSegmentImpl.java: ## @@ -533,6 +556,37 @@ private void addNewRow(int do

[GitHub] [pinot] noon-stripe commented on a diff in pull request #8611: Ingestion Aggregation Feature

2022-05-17 Thread GitBox
noon-stripe commented on code in PR #8611: URL: https://github.com/apache/pinot/pull/8611#discussion_r875044425 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/indexsegment/mutable/MutableSegmentImpl.java: ## @@ -1098,6 +1200,61 @@ void updateMVEntry(int numV

[GitHub] [pinot] noon-stripe commented on a diff in pull request #8611: Ingestion Aggregation Feature

2022-05-17 Thread GitBox
noon-stripe commented on code in PR #8611: URL: https://github.com/apache/pinot/pull/8611#discussion_r875044235 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/indexsegment/mutable/MutableSegmentImpl.java: ## @@ -1125,7 +1284,8 @@ private class IndexContainer

[GitHub] [pinot] noon-stripe commented on a diff in pull request #8611: Ingestion Aggregation Feature

2022-05-17 Thread GitBox
noon-stripe commented on code in PR #8611: URL: https://github.com/apache/pinot/pull/8611#discussion_r875043785 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/indexsegment/mutable/MutableSegmentImpl.java: ## @@ -336,10 +353,15 @@ public long getLatestIngesti

[GitHub] [pinot] npawar commented on a diff in pull request #8663: Realtime table consumption resume API

2022-05-17 Thread GitBox
npawar commented on code in PR #8663: URL: https://github.com/apache/pinot/pull/8663#discussion_r875040716 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java: ## @@ -1385,4 +1386,89 @@ public void uploadToDeepSto

[GitHub] [pinot] noon-stripe commented on a diff in pull request #8611: Ingestion Aggregation Feature

2022-05-17 Thread GitBox
noon-stripe commented on code in PR #8611: URL: https://github.com/apache/pinot/pull/8611#discussion_r875040530 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/indexsegment/mutable/MutableSegmentImpl.java: ## @@ -20,6 +20,7 @@ import com.google.common.base

[GitHub] [pinot] richardstartin commented on pull request #8719: add primitive indexOf overloads to Dictionary interface

2022-05-17 Thread GitBox
richardstartin commented on PR #8719: URL: https://github.com/apache/pinot/pull/8719#issuecomment-1129033896 Having got a profile from @WangCHX this isn't very critical, but it would be nice not to convert the `h3Id` to a string just to parse it again. -- This is an automated message from

[GitHub] [pinot] codecov-commenter commented on pull request #8719: add primitive indexOf overloads to Dictionary interface

2022-05-17 Thread GitBox
codecov-commenter commented on PR #8719: URL: https://github.com/apache/pinot/pull/8719#issuecomment-1128961344 # [Codecov](https://codecov.io/gh/apache/pinot/pull/8719?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Softwar

[GitHub] [pinot] walterddr opened a new pull request, #8720: Pr merge back

2022-05-17 Thread GitBox
walterddr opened a new pull request, #8720: URL: https://github.com/apache/pinot/pull/8720 This is the merge back for multi-stage query engine. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [pinot] zhixun-luy commented on issue #4334: Pinot datasets not showing in thirdye UI

2022-05-17 Thread GitBox
zhixun-luy commented on issue #4334: URL: https://github.com/apache/pinot/issues/4334#issuecomment-1128706246 ``` # Please put the mock data source as the first in this configuration. dataSourceConfigs: - className: org.apache.pinot.thirdeye.datasource.pinot.PinotThirdEyeDataSourc

[GitHub] [pinot] zhixun-luy commented on issue #8698: Difference between repo and docs

2022-05-17 Thread GitBox
zhixun-luy commented on issue #8698: URL: https://github.com/apache/pinot/issues/8698#issuecomment-1128664547 On the slack, it's saying this repo link. ``` 1. my use-case is to detect anomaly in my data and create an alert. 2. In the document you shared, there isn't detailed exam

[GitHub] [pinot] xiangfu0 opened a new issue, #8718: Reduce docker image size

2022-05-17 Thread GitBox
xiangfu0 opened a new issue, #8718: URL: https://github.com/apache/pinot/issues/8718 The current pinot docker image size is pretty large, 1GB after 0.10.0 release. This is majorly due to the shaded plugins. ``` 144K plugins/pinot-batch-ingestion/pinot-batch-ingestion-standalone 144K

[GitHub] [pinot] saurabhd336 commented on a diff in pull request #8663: Realtime table consumption resume API

2022-05-17 Thread GitBox
saurabhd336 commented on code in PR #8663: URL: https://github.com/apache/pinot/pull/8663#discussion_r874602234 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java: ## @@ -1385,4 +1386,78 @@ public void uploadToDe

[GitHub] [pinot] saurabhd336 commented on pull request #8663: Realtime table consumption resume API

2022-05-17 Thread GitBox
saurabhd336 commented on PR #8663: URL: https://github.com/apache/pinot/pull/8663#issuecomment-1128643993 @npawar @Jackie-Jiang @sajjad-moradi I've updated the PR as per the comments. Please have a look. -- This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] [pinot] KKcorps commented on issue #8717: Data not getting consumed from all Kafka partitions

2022-05-17 Thread GitBox
KKcorps commented on issue #8717: URL: https://github.com/apache/pinot/issues/8717#issuecomment-1128591663 Offset of last record produced in Partition 2 - 1085 Start offset of segment consuming from partition 2 - 891 -- This is an automated message from the Apache Git Service. To respon

[GitHub] [pinot] richardstartin commented on issue #8222: OfflineClusterIntegrationTest.testInvertedIndexTriggering is flaky

2022-05-17 Thread GitBox
richardstartin commented on issue #8222: URL: https://github.com/apache/pinot/issues/8222#issuecomment-1128549003 https://github.com/apache/pinot/runs/6453127269?check_suite_focus=true#step:5:30195 -- This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [pinot] saurabhd336 commented on a diff in pull request #8663: Realtime table consumption resume API

2022-05-17 Thread GitBox
saurabhd336 commented on code in PR #8663: URL: https://github.com/apache/pinot/pull/8663#discussion_r874487906 ## pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotSegmentStateResource.java: ## @@ -0,0 +1,52 @@ +/** + * Licensed to the Apache Softwar

[GitHub] [pinot] saurabhd336 commented on a diff in pull request #8663: Realtime table consumption resume API

2022-05-17 Thread GitBox
saurabhd336 commented on code in PR #8663: URL: https://github.com/apache/pinot/pull/8663#discussion_r874487585 ## pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotSegmentStateResource.java: ## @@ -0,0 +1,52 @@ +/** + * Licensed to the Apache Softwar

[GitHub] [pinot] saurabhd336 commented on a diff in pull request #8663: Realtime table consumption resume API

2022-05-17 Thread GitBox
saurabhd336 commented on code in PR #8663: URL: https://github.com/apache/pinot/pull/8663#discussion_r874487351 ## pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotSegmentStateResource.java: ## @@ -0,0 +1,52 @@ +/** + * Licensed to the Apache Softwar

[GitHub] [pinot] KKcorps commented on issue #8717: Data not getting consumed from all Kafka partitions

2022-05-17 Thread GitBox
KKcorps commented on issue #8717: URL: https://github.com/apache/pinot/issues/8717#issuecomment-1128490995 @Jackie-Jiang @npawar what can be going on here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [pinot] KKcorps opened a new issue, #8717: Data not getting consumed from all partitions

2022-05-17 Thread GitBox
KKcorps opened a new issue, #8717: URL: https://github.com/apache/pinot/issues/8717 Issue currently being faced one of our users. ``` Topic as 3 partitions Data getting pushed to all 3 partitions When table was created, it was consuming data from all 3 partitions

[pinot] branch master updated: Disable Groovy function by default (#8711)

2022-05-17 Thread snlee
This is an automated email from the ASF dual-hosted git repository. snlee pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new b672af1b9f Disable Groovy function by default (#87

[GitHub] [pinot] snleee merged pull request #8711: Disable Groovy function by default

2022-05-17 Thread GitBox
snleee merged PR #8711: URL: https://github.com/apache/pinot/pull/8711 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.