saurabhd336 commented on code in PR #8663:
URL: https://github.com/apache/pinot/pull/8663#discussion_r875483709
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java:
##########
@@ -862,7 +863,9 @@ private Map<Integer, SegmentZKMetadata>
getLatestSegmentZKMetadataMap(String rea
* TODO: We need to find a place to detect and update a gauge for
nonConsumingPartitionsCount for a table, and
* reset it to 0 at the end of validateLLC
*/
- public void ensureAllPartitionsConsuming(TableConfig tableConfig,
PartitionLevelStreamConfig streamConfig) {
+ // TODO(saurabh) : We can reduce critical section by having tableName level
locks?
+ public synchronized void ensureAllPartitionsConsuming(TableConfig
tableConfig,
+ PartitionLevelStreamConfig streamConfig, boolean enforcedByAdmin) {
Review Comment:
The idea here is to (possibly) add more such cases that'll need to be
handled conditionally, exclusively via the API, or other callers.
https://github.com/apache/pinot/pull/8663#discussion_r872885669
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
