noon-stripe commented on code in PR #8611:
URL: https://github.com/apache/pinot/pull/8611#discussion_r875070266
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/utils/TableConfigUtils.java:
##########
@@ -306,15 +311,71 @@ public static void validateIngestionConfig(TableConfig
tableConfig, @Nullable Sc
}
}
+ // Aggregation configs
+ List<AggregationConfig> aggregationConfigs =
ingestionConfig.getAggregationConfigs();
+ Set<String> aggregationSourceColumns = new HashSet<>();
+ if (aggregationConfigs != null) {
+ Preconditions.checkState(
+ !tableConfig.getIndexingConfig().isAggregateMetrics(),
+ "aggregateMetrics cannot be set with AggregationConfig");
+ Set<String> aggregationColumns = new HashSet<>();
+ for (AggregationConfig aggregationConfig : aggregationConfigs) {
+ String columnName = aggregationConfig.getColumnName();
+ if (schema != null) {
Review Comment:
Which check? I believe these are in the correct order, right?
```
FieldSpec fieldSpec = schema.getFieldSpecFor(columnName);
Preconditions.checkState(fieldSpec != null, "The destination
column '" + columnName
+ "' of the aggregation function must be present in the
schema");
Preconditions.checkState(fieldSpec.getFieldType() ==
FieldSpec.FieldType.METRIC,
"The destination column '" + columnName + "' of the
aggregation function must be a metric column");
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
