Jackie-Jiang opened a new pull request, #8721:
URL: https://github.com/apache/pinot/pull/8721

   Currently `DimensionTableDataManager` overrides the `addSegment(File 
indexDir, IndexLoadingConfig indexLoadingConfig)` method to reload the lookup 
table, but this method is not always invoked when adding the segment. Fix the 
issue by overriding `addSegment(ImmutableSegment immutableSegment)` which is 
always invoked when adding the segment.
   
   Other changes:
   - Enhance the validation for schema and primary key and fail with proper 
exception message
   - Enhance the test to mimic the actual flow of reloading the segment


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to