noon-stripe commented on code in PR #8611:
URL: https://github.com/apache/pinot/pull/8611#discussion_r875133037
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/utils/TableConfigUtils.java:
##########
@@ -363,6 +424,25 @@ public static void validateIngestionConfig(TableConfig
tableConfig, @Nullable Sc
}
}
+ /**
+ * Currently only, ValueAggregators with fixed width types are allowed, so
MIN, MAX, SUM, and COUNT. The reason
+ * is that only the {@link
org.apache.pinot.segment.local.realtime.impl.forward.FixedByteSVMutableForwardIndex}
+ * supports random inserts and lookups. The
+ * {@link
org.apache.pinot.segment.local.realtime.impl.forward.VarByteSVMutableForwardIndex
only supports
+ * sequential inserts.
+ */
+ public static void validateIngestionAggregation(String name) {
+ List<AggregationFunctionType> allowed =
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
