npawar commented on issue #8409: URL: https://github.com/apache/pinot/issues/8409#issuecomment-1129616141
Picking this up (making the error message friendly part). While this fix (checking on broker side) may not be able to handle scalar functions case, I think it is still better than having no checking. We would catch majority cases with it. Other option - I could fix this at every operator level on a case by case (e.g. inside getMaxValue and getMinValue methods in NoScanBasedAggregationOperator for dictionary + aggregation case, etc). But I don't know if that would be a comprehensive fix either (e.g. how would we catch this for https://github.com/apache/pinot/issues/8290 until we get to combine) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
