xiangfu0 commented on code in PR #8467:
URL: https://github.com/apache/pinot/pull/8467#discussion_r850918760
##
pinot-clients/pinot-java-client/src/main/java/org/apache/pinot/client/UpdatableBrokerCache.java:
##
@@ -0,0 +1,34 @@
+/**
+ * Licensed to the Apache Software Foundatio
WangCHX commented on code in PR #8498:
URL: https://github.com/apache/pinot/pull/8498#discussion_r851047468
##
pinot-core/src/main/java/org/apache/pinot/core/operator/filter/H3InclusionIndexFilterOperator.java:
##
@@ -0,0 +1,128 @@
+/**
+ * Licensed to the Apache Software Founda
WangCHX commented on code in PR #8498:
URL: https://github.com/apache/pinot/pull/8498#discussion_r851047468
##
pinot-core/src/main/java/org/apache/pinot/core/operator/filter/H3InclusionIndexFilterOperator.java:
##
@@ -0,0 +1,128 @@
+/**
+ * Licensed to the Apache Software Founda
WangCHX opened a new issue, #8547:
URL: https://github.com/apache/pinot/issues/8547
see title.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: comm
WangCHX commented on code in PR #8498:
URL: https://github.com/apache/pinot/pull/8498#discussion_r851044182
##
pinot-core/src/main/java/org/apache/pinot/core/operator/filter/H3InclusionIndexFilterOperator.java:
##
@@ -0,0 +1,128 @@
+/**
+ * Licensed to the Apache Software Founda
yupeng9 commented on code in PR #8498:
URL: https://github.com/apache/pinot/pull/8498#discussion_r851031667
##
pinot-core/src/main/java/org/apache/pinot/core/operator/filter/H3InclusionIndexFilterOperator.java:
##
@@ -0,0 +1,128 @@
+/**
+ * Licensed to the Apache Software Founda
dongxiaoman commented on code in PR #8506:
URL: https://github.com/apache/pinot/pull/8506#discussion_r850928592
##
pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/HelixZNodeSizeLimitTest.java:
##
@@ -0,0 +1,91 @@
+/**
+ * Licensed to the Apache Software
jackjlli commented on code in PR #8506:
URL: https://github.com/apache/pinot/pull/8506#discussion_r850920845
##
pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/HelixZNodeSizeLimitTest.java:
##
@@ -0,0 +1,91 @@
+/**
+ * Licensed to the Apache Software Fou
xiangfu0 commented on code in PR #8467:
URL: https://github.com/apache/pinot/pull/8467#discussion_r850913123
##
pinot-spi/pom.xml:
##
@@ -149,6 +149,20 @@
org.reflections
reflections
+
Review Comment:
Please also apply the same pom changes for
https:
xiangfu0 commented on code in PR #8467:
URL: https://github.com/apache/pinot/pull/8467#discussion_r850911012
##
pinot-clients/pinot-java-client/src/main/java/org/apache/pinot/client/ControllerURLUtils.java:
##
@@ -0,0 +1,35 @@
+/**
+ * Licensed to the Apache Software Foundation
richardstartin commented on code in PR #8513:
URL: https://github.com/apache/pinot/pull/8513#discussion_r850854605
##
pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/index/reader/RangeIndexReader.java:
##
@@ -26,6 +26,51 @@
* @param
*/
public interface RangeIn
walterddr commented on code in PR #8513:
URL: https://github.com/apache/pinot/pull/8513#discussion_r850853486
##
pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/index/reader/RangeIndexReader.java:
##
@@ -26,6 +26,51 @@
* @param
*/
public interface RangeIndexRe
richardstartin commented on code in PR #8513:
URL: https://github.com/apache/pinot/pull/8513#discussion_r850844404
##
pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/index/reader/RangeIndexReader.java:
##
@@ -26,6 +26,51 @@
* @param
*/
public interface RangeIn
richardstartin commented on code in PR #8513:
URL: https://github.com/apache/pinot/pull/8513#discussion_r850843713
##
pinot-core/src/main/java/org/apache/pinot/core/operator/filter/RangeIndexBasedFilterOperator.java:
##
@@ -145,10 +127,178 @@ public List getChildOperators() {
walterddr commented on code in PR #8513:
URL: https://github.com/apache/pinot/pull/8513#discussion_r850830798
##
pinot-core/src/main/java/org/apache/pinot/core/operator/filter/RangeIndexBasedFilterOperator.java:
##
@@ -145,10 +127,178 @@ public List getChildOperators() {
@O
Jackie-Jiang commented on code in PR #7358:
URL: https://github.com/apache/pinot/pull/7358#discussion_r850814130
##
pinot-plugins/pinot-input-format/pinot-avro-base/src/main/java/org/apache/pinot/plugin/inputformat/avro/AvroRecordExtractor.java:
##
@@ -33,14 +35,19 @@
/**
-
richardstartin commented on code in PR #8523:
URL: https://github.com/apache/pinot/pull/8523#discussion_r850814317
##
pinot-core/src/main/java/org/apache/pinot/core/plan/CombinePlanNode.java:
##
@@ -185,4 +136,84 @@ public List callJob() {
return new DistinctCombineOperat
richardstartin commented on code in PR #8523:
URL: https://github.com/apache/pinot/pull/8523#discussion_r850814317
##
pinot-core/src/main/java/org/apache/pinot/core/plan/CombinePlanNode.java:
##
@@ -185,4 +136,84 @@ public List callJob() {
return new DistinctCombineOperat
richardstartin commented on code in PR #8523:
URL: https://github.com/apache/pinot/pull/8523#discussion_r850813387
##
pinot-core/src/main/java/org/apache/pinot/core/plan/CombinePlanNode.java:
##
@@ -185,4 +136,84 @@ public List callJob() {
return new DistinctCombineOperat
Jackie-Jiang commented on code in PR #8523:
URL: https://github.com/apache/pinot/pull/8523#discussion_r850808333
##
pinot-core/src/main/java/org/apache/pinot/core/plan/CombinePlanNode.java:
##
@@ -185,4 +136,84 @@ public List callJob() {
return new DistinctCombineOperator
amrishlal commented on code in PR #8518:
URL: https://github.com/apache/pinot/pull/8518#discussion_r850793054
##
pinot-common/src/main/java/org/apache/pinot/pql/parsers/pql2/ast/FilterKind.java:
##
@@ -39,13 +41,26 @@ public enum FilterKind {
TEXT_MATCH,
JSON_MATCH;
+ p
xiangfu0 commented on code in PR #8545:
URL: https://github.com/apache/pinot/pull/8545#discussion_r850790979
##
pinot-common/src/main/java/org/apache/pinot/common/controller/ControllerRequestClient.java:
##
@@ -16,7 +16,7 @@
* specific language governing permissions and limita
Jackie-Jiang commented on issue #8418:
URL: https://github.com/apache/pinot/issues/8418#issuecomment-1099604467
I think the reason for the 38 precision digits is that we can use 128 bits
to represent the value. If we know the digits after the decimal point (e.g.
`DECIMAL(38, 10)`), we don't
nizarhejazi commented on code in PR #8503:
URL: https://github.com/apache/pinot/pull/8503#discussion_r850790282
##
pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/JsonExtractScalarTransformFunction.java:
##
@@ -301,7 +313,7 @@ private String[]
transfo
nizarhejazi commented on code in PR #8503:
URL: https://github.com/apache/pinot/pull/8503#discussion_r850788721
##
pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/BaseTransformFunction.java:
##
@@ -55,6 +58,7 @@ public abstract class BaseTransformFunct
walterddr commented on code in PR #8545:
URL: https://github.com/apache/pinot/pull/8545#discussion_r850780320
##
pinot-common/src/main/java/org/apache/pinot/common/controller/ControllerRequestClient.java:
##
@@ -16,7 +16,7 @@
* specific language governing permissions and limit
siddharthteotia merged PR #8544:
URL: https://github.com/apache/pinot/pull/8544
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pino
xiangfu0 commented on code in PR #8545:
URL: https://github.com/apache/pinot/pull/8545#discussion_r850775547
##
pinot-common/src/main/java/org/apache/pinot/common/controller/ControllerRequestClient.java:
##
@@ -16,7 +16,7 @@
* specific language governing permissions and limita
This is an automated email from the ASF dual-hosted git repository.
siddteotia pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
from fe7247fb96 create task queue as needed for adhoc task (#8540)
add d503d505b2 Only discover public methods anno
walterddr commented on code in PR #8545:
URL: https://github.com/apache/pinot/pull/8545#discussion_r850773595
##
pinot-common/src/main/java/org/apache/pinot/common/controller/ControllerRequestClient.java:
##
@@ -16,7 +16,7 @@
* specific language governing permissions and limit
richardstartin commented on PR #8535:
URL: https://github.com/apache/pinot/pull/8535#issuecomment-1099568551
Can we get this merged then? @Jackie-Jiang @walterddr
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
Jackie-Jiang commented on issue #8418:
URL: https://github.com/apache/pinot/issues/8418#issuecomment-1099563171
Currently we store `BigDecimal` as bytes, but because the ordering of
`BigDecimal` is different from bytes, we might have to introduce the
`BigDecimal` into the data representatio
walterddr commented on code in PR #8535:
URL: https://github.com/apache/pinot/pull/8535#discussion_r850747579
##
pinot-common/src/main/java/org/apache/pinot/common/function/scalar/DataTypeConversionFunctions.java:
##
@@ -32,6 +39,33 @@ public class DataTypeConversionFunctions {
walterddr commented on code in PR #8535:
URL: https://github.com/apache/pinot/pull/8535#discussion_r850742106
##
pinot-common/src/main/java/org/apache/pinot/common/function/scalar/DataTypeConversionFunctions.java:
##
@@ -32,6 +39,33 @@ public class DataTypeConversionFunctions {
richardstartin commented on code in PR #8535:
URL: https://github.com/apache/pinot/pull/8535#discussion_r850746889
##
pinot-common/src/main/java/org/apache/pinot/common/function/scalar/DataTypeConversionFunctions.java:
##
@@ -32,6 +39,33 @@ public class DataTypeConversionFunctio
richardstartin commented on code in PR #8535:
URL: https://github.com/apache/pinot/pull/8535#discussion_r850745869
##
pinot-core/src/test/java/org/apache/pinot/queries/CastQueriesTest.java:
##
@@ -0,0 +1,171 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
Jackie-Jiang commented on issue #8418:
URL: https://github.com/apache/pinot/issues/8418#issuecomment-109978
Link the PR: #8503
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
walterddr commented on PR #8535:
URL: https://github.com/apache/pinot/pull/8535#issuecomment-1099554115
> and we should add some queries test to ensure it works end-to-end and
covers ingestion, compilation, aggregation and post-aggregation. I'd suggest
first adding the basic support for SV,
xiangfu0 opened a new pull request, #8545:
URL: https://github.com/apache/pinot/pull/8545
Refactor ControllerRequestClient from `pinot-controller` to `pinot-common`
module
E.g. Broker can use this client to submit minion tasks.
--
This is an automated message from the Apa
walterddr commented on issue #8424:
URL: https://github.com/apache/pinot/issues/8424#issuecomment-1099552719
> I doubt the cause is the absence of a scalar function then. The motivation
of that PR is to ensure casts in filters don’t prevent index use.
for the purpose of index use i th
walterddr commented on code in PR #8535:
URL: https://github.com/apache/pinot/pull/8535#discussion_r850742106
##
pinot-common/src/main/java/org/apache/pinot/common/function/scalar/DataTypeConversionFunctions.java:
##
@@ -32,6 +39,33 @@ public class DataTypeConversionFunctions {
walterddr commented on code in PR #8535:
URL: https://github.com/apache/pinot/pull/8535#discussion_r850740019
##
pinot-core/src/test/java/org/apache/pinot/queries/CastQueriesTest.java:
##
@@ -0,0 +1,171 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * o
Jackie-Jiang closed issue #5904: Support for a fixed precision Decimal column
type
URL: https://github.com/apache/pinot/issues/5904
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comme
Jackie-Jiang commented on issue #5904:
URL: https://github.com/apache/pinot/issues/5904#issuecomment-1099546031
`SumPrecision` aggregation function introduced in #6053 solves the basic
requirement
#8418 is adding the native BIG_DECIMAL data type into Pinot. Closing this
issue and use tha
richardstartin commented on issue #8424:
URL: https://github.com/apache/pinot/issues/8424#issuecomment-1099545422
I doubt the cause is the absence of a scalar function then. The motivation
of that PR is to ensure casts in filters don’t prevent index use.
--
This is an automated message fr
Jackie-Jiang commented on code in PR #8503:
URL: https://github.com/apache/pinot/pull/8503#discussion_r850664743
##
pinot-core/src/main/java/org/apache/pinot/core/common/evaluators/DefaultJsonPathEvaluator.java:
##
@@ -38,8 +41,13 @@
public final class DefaultJsonPathEvaluato
walterddr commented on issue #8424:
URL: https://github.com/apache/pinot/issues/8424#issuecomment-1099533365
checked out the PR and tested. still doesn't work. let me poke around.
thanks for the info @richardstartin
--
This is an automated message from the Apache Git Service.
To respond
richardstartin commented on code in PR #8518:
URL: https://github.com/apache/pinot/pull/8518#discussion_r850721889
##
pinot-common/src/main/java/org/apache/pinot/pql/parsers/pql2/ast/FilterKind.java:
##
@@ -39,13 +41,26 @@ public enum FilterKind {
TEXT_MATCH,
JSON_MATCH;
kishoreg commented on PR #8543:
URL: https://github.com/apache/pinot/pull/8543#issuecomment-1099505941
+1 on supporting this call on the broker
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
npawar commented on code in PR #8539:
URL: https://github.com/apache/pinot/pull/8539#discussion_r850688941
##
pinot-tools/src/main/java/org/apache/pinot/tools/perf/QueryRunner.java:
##
@@ -416,42 +422,49 @@ public static QuerySummary
multiThreadedQueryRunner(PerfBenchmarkDriver
amrishlal commented on code in PR #8518:
URL: https://github.com/apache/pinot/pull/8518#discussion_r850680318
##
pinot-common/src/main/java/org/apache/pinot/pql/parsers/pql2/ast/FilterKind.java:
##
@@ -39,13 +41,26 @@ public enum FilterKind {
TEXT_MATCH,
JSON_MATCH;
+ p
richardstartin commented on issue #8424:
URL: https://github.com/apache/pinot/issues/8424#issuecomment-1099473370
> new finding is that
>
> ```
> select
> playerID,
> cast((hits - runs) as long) AS hitMinusRun
> from baseballStats
> ```
>
> will work. thus
walterddr commented on issue #8424:
URL: https://github.com/apache/pinot/issues/8424#issuecomment-1099469841
new finding is that
```
select
playerID,
cast((hits - runs) as long) AS hitMinusRun
from baseballStats
```
will work. thus the CAST functionKind exist, jus
richardstartin commented on PR #8544:
URL: https://github.com/apache/pinot/pull/8544#issuecomment-1099458599
It appears illegal reflective access is relied on even internally
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
codecov-commenter commented on PR #8544:
URL: https://github.com/apache/pinot/pull/8544#issuecomment-1099456915
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/8544?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Softwar
This is an automated email from the ASF dual-hosted git repository.
jlli pushed a change to branch minimize-instance-movement
in repository https://gitbox.apache.org/repos/asf/pinot.git
omit e54fb59b85 Reuse InstanceReplicaGroupPartitionSelector
add 8c3afa9883 Reuse InstanceReplicaGroup
This is an automated email from the ASF dual-hosted git repository.
jlli pushed a change to branch minimize-instance-movement
in repository https://gitbox.apache.org/repos/asf/pinot.git
discard 24fbc0cc44 Reuse InstanceReplicaGroupPartitionSelector
add e54fb59b85 Reuse InstanceReplicaGroup
xiangfu0 commented on PR #8543:
URL: https://github.com/apache/pinot/pull/8543#issuecomment-1099402997
Good point. I'm testing it from the UI, so it's simpler to put the logic in
controller. The same logic can definitely be moved to broker request handler.
Just the controller call nee
richardstartin opened a new pull request, #8544:
URL: https://github.com/apache/pinot/pull/8544
Experiment to disallow discovery of private scalar functions to avoid
unpredictable illegal reflective acces
--
This is an automated message from the Apache Git Service.
To respond to the messa
amrishlal commented on PR #8543:
URL: https://github.com/apache/pinot/pull/8543#issuecomment-1099393573
This query appears to be processed on the Controller side. Would the query
still work if it is sent to Broker API? If not, then can the Broker forward the
query to the controller for proc
ddcprg commented on code in PR #7358:
URL: https://github.com/apache/pinot/pull/7358#discussion_r850331077
##
pinot-plugins/pinot-input-format/pinot-avro-base/src/main/java/org/apache/pinot/plugin/inputformat/avro/AvroRecordExtractor.java:
##
@@ -107,4 +121,25 @@ protected Objec
richardstartin commented on code in PR #8539:
URL: https://github.com/apache/pinot/pull/8539#discussion_r850312126
##
pinot-tools/src/main/java/org/apache/pinot/tools/perf/QueryRunner.java:
##
@@ -416,42 +422,49 @@ public static QuerySummary
multiThreadedQueryRunner(PerfBenchma
richardstartin commented on issue #8529:
URL: https://github.com/apache/pinot/issues/8529#issuecomment-1099019879
Remaining blockers to running on JDK17 are:
* illegal reflective access in `FunctionInvoker` which blindly makes
discovered methods accessible. This could be easily replac
richardstartin commented on PR #8535:
URL: https://github.com/apache/pinot/pull/8535#issuecomment-1098905816
Dropped MV support.
Testing for:
* unit
* calcite sql compilation
* use post aggregation, in filters
* consistency with transform function used for projections
ddcprg commented on PR #7358:
URL: https://github.com/apache/pinot/pull/7358#issuecomment-1098874275
Thanks @Jackie-Jiang in that case I'll add more unit tests around record
extractor. I'll squash all the commits into one after that
--
This is an automated message from the Apache Git Serv
xiangfu0 opened a new pull request, #8543:
URL: https://github.com/apache/pinot/pull/8543
Support INSERT INTO table FROM inputDirURI statement
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
xiangfu0 merged PR #8540:
URL: https://github.com/apache/pinot/pull/8540
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apach
This is an automated email from the ASF dual-hosted git repository.
xiangfu pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new fe7247fb96 create task queue as needed for adhoc
richardstartin commented on code in PR #8535:
URL: https://github.com/apache/pinot/pull/8535#discussion_r850189997
##
pinot-common/src/main/java/org/apache/pinot/common/function/scalar/DataTypeConversionFunctions.java:
##
@@ -32,6 +36,51 @@ public class DataTypeConversionFunctio
richardstartin commented on code in PR #8535:
URL: https://github.com/apache/pinot/pull/8535#discussion_r850189527
##
pinot-common/src/main/java/org/apache/pinot/common/function/scalar/DataTypeConversionFunctions.java:
##
@@ -32,6 +36,51 @@ public class DataTypeConversionFunctio
richardstartin commented on code in PR #8535:
URL: https://github.com/apache/pinot/pull/8535#discussion_r850188589
##
pinot-common/src/test/java/org/apache/pinot/common/function/scalar/DataTypeConversionFunctionsTest.java:
##
@@ -0,0 +1,71 @@
+/**
+ * Licensed to the Apache Soft
richardstartin commented on PR #8535:
URL: https://github.com/apache/pinot/pull/8535#issuecomment-1098822932
> Some thoughts:
>
> 1. one option may be to drop the cast function if it is casting something
to a numeric type. For example `intColumn > cast(10.3 as long)` could just be
re
richardstartin commented on PR #8535:
URL: https://github.com/apache/pinot/pull/8535#issuecomment-1098820054
> Currently `CastTransformFunction` doesn't support multi-valued column
casting. We should keep the scalar function and transform function consistent
(either both support MV or both
richardstartin commented on code in PR #8523:
URL: https://github.com/apache/pinot/pull/8523#discussion_r850184819
##
pinot-core/src/main/java/org/apache/pinot/core/plan/CombinePlanNode.java:
##
@@ -185,4 +136,84 @@ public List callJob() {
return new DistinctCombineOperat
KKcorps opened a new pull request, #8542:
URL: https://github.com/apache/pinot/pull/8542
- Upgrading Spark Version to 3.2.1 from 2.4.0
-
- Requires upgrade of Scala to 2.12
-
- Also, requires upgrade of Jackson libraries otherwise it throws
-
- `Scala module 2.12.3 requi
richardstartin merged PR #8530:
URL: https://github.com/apache/pinot/pull/8530
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
This is an automated email from the ASF dual-hosted git repository.
richardstartin pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new aadd0cddcf make ConfigUtils testable with
Akshay2Agarwal commented on issue #8541:
URL: https://github.com/apache/pinot/issues/8541#issuecomment-1098779444
I realized schema was missing my bad.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
Akshay2Agarwal closed issue #8541: Query fails due to error in long conversion
of millisecond time column in WHERE clause
URL: https://github.com/apache/pinot/issues/8541
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use th
79 matches
Mail list logo
