richardstartin commented on code in PR #8535: URL: https://github.com/apache/pinot/pull/8535#discussion_r850746889
########## pinot-common/src/main/java/org/apache/pinot/common/function/scalar/DataTypeConversionFunctions.java: ########## @@ -32,6 +39,33 @@ public class DataTypeConversionFunctions { private DataTypeConversionFunctions() { } + @ScalarFunction + public static Object cast(Object value, String targetTypeLiteral) { Review Comment: This this works fine when invoked in a filter to handle the case this PR targets - compile time replacement. You're right that it's not getting invoked after aggregation functions though. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org