richardstartin commented on code in PR #8523:
URL: https://github.com/apache/pinot/pull/8523#discussion_r850814317


##########
pinot-core/src/main/java/org/apache/pinot/core/plan/CombinePlanNode.java:
##########
@@ -185,4 +136,84 @@ public List<Operator> callJob() {
       return new DistinctCombineOperator(operators, _queryContext, 
_executorService);
     }
   }
+
+  private List<Operator> getOperatorsSingleThreaded() {
+    List<Operator> operators = new ArrayList<>(_planNodes.size());
+    for (PlanNode planNode : _planNodes) {
+      operators.add(planNode.run());
+    }
+    return operators;
+  }
+
+  private List<Operator> getOperatorsMultiThreaded(int numThreads) {

Review Comment:
   the actual implementation ensures that this some would propagate into the 
thread pool for lineage purposes, so any scope created within the thread pool 
would have the right parent, if that's what you want to achieve



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to