walterddr commented on code in PR #8535:
URL: https://github.com/apache/pinot/pull/8535#discussion_r850742106
##########
pinot-common/src/main/java/org/apache/pinot/common/function/scalar/DataTypeConversionFunctions.java:
##########
@@ -32,6 +39,33 @@ public class DataTypeConversionFunctions {
private DataTypeConversionFunctions() {
}
+ @ScalarFunction
+ public static Object cast(Object value, String targetTypeLiteral) {
Review Comment:
ScalarFunction / FunctionInvoker doesn't provide a dynamic return type
resolution at runtime --> e.g. determine what's being returned based on the
argument passed in. which is exactly what's needed here.
The SQL in the non-literal test cases are actually compiled into
`CastTransformFunction` which does support result metadata --> that's
dynamically determined.
What's missing here is a "CAST" that's not a transform function, which
require changes to function invoker.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
