richardstartin commented on code in PR #8513: URL: https://github.com/apache/pinot/pull/8513#discussion_r850844404
########## pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/index/reader/RangeIndexReader.java: ########## @@ -26,6 +26,51 @@ * @param <T> */ public interface RangeIndexReader<T> extends Closeable { + + /** + * @return true if the results are exact and don't need refinement by scanning. + * This means {@see getPartiallyMatchingDocIds} will return null. + */ + default boolean isExact() { + return true; Review Comment: There are two implementations, the first one was inexact and could be up to 10x slower than the one which is exact. If we implement another range index, we will want it to be exact. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org