walterddr commented on code in PR #8513:
URL: https://github.com/apache/pinot/pull/8513#discussion_r850853486
##########
pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/index/reader/RangeIndexReader.java:
##########
@@ -26,6 +26,51 @@
* @param <T>
*/
public interface RangeIndexReader<T> extends Closeable {
+
+ /**
+ * @return true if the results are exact and don't need refinement by
scanning.
+ * This means {@see getPartiallyMatchingDocIds} will return null.
+ */
+ default boolean isExact() {
+ return true;
Review Comment:
oh yes. what I meant is we should not implement a default --> whether the
implementation is exact or not cannot be determined in the interface level -
e.g. if I accidentally deleted the override in `RangeIndexReaderImpl` i will
get no compile time error until i run into test failures.
is the intent here to not allow any non-exact impl in the future?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
