[GitHub] [incubator-pinot] codecov-commenter edited a comment on pull request #6998: Support json path expressions in query.

codecov-commenter edited a comment on pull request #6998: URL: https://github.com/apache/incubator-pinot/pull/6998#issuecomment-852478013 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6998?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr

[GitHub] [incubator-pinot] codecov-commenter edited a comment on pull request #6424: Make Pinot JDK 11 Compilable

codecov-commenter edited a comment on pull request #6424: URL: https://github.com/apache/incubator-pinot/pull/6424#issuecomment-828596486 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6424?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr

[GitHub] [incubator-pinot] xiangfu0 commented on a change in pull request #6424: Make Pinot JDK 11 Compilable

xiangfu0 commented on a change in pull request #6424: URL: https://github.com/apache/incubator-pinot/pull/6424#discussion_r648779267 ## File path: pinot-clients/pinot-java-client/src/test/java/org/apache/pinot/client/ExternalViewReaderTest.java ## @@ -75,7 +75,7 @@ public void

[GitHub] [incubator-pinot] xiangfu0 commented on a change in pull request #6424: Make Pinot JDK 11 Compilable

xiangfu0 commented on a change in pull request #6424: URL: https://github.com/apache/incubator-pinot/pull/6424#discussion_r648778915 ## File path: pinot-common/src/test/java/org/apache/pinot/common/utils/PinotDataTypeTest.java ## @@ -105,6 +105,7 @@ public void testBytes() {

[incubator-pinot] branch master updated (2de40fd -> 9299255)

This is an automated email from the ASF dual-hosted git repository. siddteotia pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from 2de40fd improve robustness of basic auth (tls) realtime integration tests (#7038) add 9299255 Fi

[GitHub] [incubator-pinot] siddharthteotia merged pull request #7031: Changes in QueryInvertedSortedIndexRecommender to handle non-dimension columns for sorted and inverted index(#7018)

siddharthteotia merged pull request #7031: URL: https://github.com/apache/incubator-pinot/pull/7031 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #7031: Changes in QueryInvertedSortedIndexRecommender to handle non-dimension columns for sorted and inverted index(#70

siddharthteotia commented on a change in pull request #7031: URL: https://github.com/apache/incubator-pinot/pull/7031#discussion_r648767241 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/recommender/io/InputManager.java ## @@ -236,39 +236,28 @@ privat

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #7031: Changes in QueryInvertedSortedIndexRecommender to handle non-dimension columns for sorted and inverted index(#70

siddharthteotia commented on a change in pull request #7031: URL: https://github.com/apache/incubator-pinot/pull/7031#discussion_r648766944 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/recommender/io/InputManager.java ## @@ -539,7 +528,7 @@ public i

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #6424: Make Pinot JDK 11 Compilable

Jackie-Jiang commented on a change in pull request #6424: URL: https://github.com/apache/incubator-pinot/pull/6424#discussion_r648746685 ## File path: pinot-clients/pinot-java-client/src/test/java/org/apache/pinot/client/ExternalViewReaderTest.java ## @@ -75,7 +75,7 @@ public

[GitHub] [incubator-pinot] xiangfu0 closed pull request #6691: Upgrade jdk to 11

xiangfu0 closed pull request #6691: URL: https://github.com/apache/incubator-pinot/pull/6691 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this servic

[GitHub] [incubator-pinot] GSharayu commented on a change in pull request #7031: Changes in QueryInvertedSortedIndexRecommender to handle non-dimension columns for sorted and inverted index(#7018)

GSharayu commented on a change in pull request #7031: URL: https://github.com/apache/incubator-pinot/pull/7031#discussion_r648721597 ## File path: pinot-controller/src/test/java/org/apache/pinot/controller/recommender/TestConfigEngine.java ## @@ -144,9 +156,9 @@ void testQuery

[GitHub] [incubator-pinot] GSharayu commented on a change in pull request #7031: Changes in QueryInvertedSortedIndexRecommender to handle non-dimension columns for sorted and inverted index(#7018)

GSharayu commented on a change in pull request #7031: URL: https://github.com/apache/incubator-pinot/pull/7031#discussion_r648717419 ## File path: pinot-controller/src/test/java/org/apache/pinot/controller/recommender/TestConfigEngine.java ## @@ -125,6 +125,18 @@ void testInve

[GitHub] [incubator-pinot] GSharayu commented on a change in pull request #7031: Changes in QueryInvertedSortedIndexRecommender to handle non-dimension columns for sorted and inverted index(#7018)

GSharayu commented on a change in pull request #7031: URL: https://github.com/apache/incubator-pinot/pull/7031#discussion_r648716954 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/recommender/io/InputManager.java ## @@ -237,11 +237,16 @@ private void

[GitHub] [incubator-pinot] GSharayu commented on a change in pull request #7031: Changes in QueryInvertedSortedIndexRecommender to handle non-dimension columns for sorted and inverted index(#7018)

GSharayu commented on a change in pull request #7031: URL: https://github.com/apache/incubator-pinot/pull/7031#discussion_r648716954 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/recommender/io/InputManager.java ## @@ -237,11 +237,16 @@ private void

[GitHub] [incubator-pinot] GSharayu commented on a change in pull request #7031: Changes in QueryInvertedSortedIndexRecommender to handle non-dimension columns for sorted and inverted index(#7018)

GSharayu commented on a change in pull request #7031: URL: https://github.com/apache/incubator-pinot/pull/7031#discussion_r648716916 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/recommender/io/InputManager.java ## @@ -237,11 +237,16 @@ private void

[GitHub] [incubator-pinot] GSharayu commented on a change in pull request #7031: Changes in QueryInvertedSortedIndexRecommender to handle non-dimension columns for sorted and inverted index(#7018)

GSharayu commented on a change in pull request #7031: URL: https://github.com/apache/incubator-pinot/pull/7031#discussion_r648716779 ## File path: pinot-controller/src/test/resources/recommenderInput/SortedInvertedIndexInputWithDateTimeColumn.json ## @@ -0,0 +1,87 @@ +{ + "sc

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #7031: Changes in QueryInvertedSortedIndexRecommender to handle non-dimension columns for sorted and inverted index(#70

siddharthteotia commented on a change in pull request #7031: URL: https://github.com/apache/incubator-pinot/pull/7031#discussion_r648649571 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/recommender/io/InputManager.java ## @@ -237,11 +237,16 @@ privat

[incubator-pinot] branch master updated: improve robustness of basic auth (tls) realtime integration tests (#7038)

This is an automated email from the ASF dual-hosted git repository. apucher pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/master by this push: new 2de40fd improve robustness of basic a

[GitHub] [incubator-pinot] apucher merged pull request #7038: improve robustness of basic auth (tls) realtime integration tests

apucher merged pull request #7038: URL: https://github.com/apache/incubator-pinot/pull/7038 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service

[incubator-pinot] branch master updated (176cb85 -> b0ff258)

This is an automated email from the ASF dual-hosted git repository. jlli pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from 176cb85 mark PinotFS.move as not final (#7032) add b0ff258 Include null check for setting minion tag. (

[GitHub] [incubator-pinot] jackjlli merged pull request #7033: Include null check for setting minion tag.

jackjlli merged pull request #7033: URL: https://github.com/apache/incubator-pinot/pull/7033 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this servic

[GitHub] [incubator-pinot] codecov-commenter edited a comment on pull request #7037: Switch to using 'authority' instead of 'host' when building parent URI in PinotFS::move

codecov-commenter edited a comment on pull request #7037: URL: https://github.com/apache/incubator-pinot/pull/7037#issuecomment-858092963 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/7037?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr

[GitHub] [incubator-pinot] codecov-commenter edited a comment on pull request #7026: Add Apache Pulsar low level and high level connector

codecov-commenter edited a comment on pull request #7026: URL: https://github.com/apache/incubator-pinot/pull/7026#issuecomment-855347878 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/7026?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr

[GitHub] [incubator-pinot] GSharayu commented on a change in pull request #7031: Changes in QueryInvertedSortedIndexRecommender to handle non-dimension columns for sorted and inverted index(#7018)

GSharayu commented on a change in pull request #7031: URL: https://github.com/apache/incubator-pinot/pull/7031#discussion_r648682173 ## File path: pinot-controller/src/test/java/org/apache/pinot/controller/recommender/TestConfigEngine.java ## @@ -125,6 +125,18 @@ void testInve

[GitHub] [incubator-pinot] GSharayu commented on a change in pull request #7031: Changes in QueryInvertedSortedIndexRecommender to handle non-dimension columns for sorted and inverted index(#7018)

GSharayu commented on a change in pull request #7031: URL: https://github.com/apache/incubator-pinot/pull/7031#discussion_r648681479 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/recommender/io/InputManager.java ## @@ -237,11 +237,16 @@ private void

[GitHub] [incubator-pinot] codecov-commenter commented on pull request #7037: Switch to using 'authority' instead of 'host' when building parent URI in PinotFS::move

codecov-commenter commented on pull request #7037: URL: https://github.com/apache/incubator-pinot/pull/7037#issuecomment-858092963 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/7037?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+commen

[GitHub] [incubator-pinot] codecov-commenter edited a comment on pull request #7026: Add Apache Pulsar low level and high level connector

codecov-commenter edited a comment on pull request #7026: URL: https://github.com/apache/incubator-pinot/pull/7026#issuecomment-855347878 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/7026?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #7031: Changes in QueryInvertedSortedIndexRecommender to handle non-dimension columns for sorted and inverted index(#70

siddharthteotia commented on a change in pull request #7031: URL: https://github.com/apache/incubator-pinot/pull/7031#discussion_r648672633 ## File path: pinot-controller/src/test/java/org/apache/pinot/controller/recommender/TestConfigEngine.java ## @@ -125,6 +125,18 @@ void t

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #7031: Changes in QueryInvertedSortedIndexRecommender to handle non-dimension columns for sorted and inverted index(#70

siddharthteotia commented on a change in pull request #7031: URL: https://github.com/apache/incubator-pinot/pull/7031#discussion_r648670818 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/recommender/io/InputManager.java ## @@ -259,14 +264,6 @@ private

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #7031: Changes in QueryInvertedSortedIndexRecommender to handle non-dimension columns for sorted and inverted index(#70

siddharthteotia commented on a change in pull request #7031: URL: https://github.com/apache/incubator-pinot/pull/7031#discussion_r648668898 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/recommender/io/InputManager.java ## @@ -237,11 +237,16 @@ privat

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #7031: Changes in QueryInvertedSortedIndexRecommender to handle non-dimension columns for sorted and inverted index(#70

siddharthteotia commented on a change in pull request #7031: URL: https://github.com/apache/incubator-pinot/pull/7031#discussion_r648668319 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/recommender/io/InputManager.java ## @@ -237,11 +237,16 @@ privat

[GitHub] [incubator-pinot] codecov-commenter commented on pull request #7038: improve robustness of basic auth (tls) realtime integration tests

codecov-commenter commented on pull request #7038: URL: https://github.com/apache/incubator-pinot/pull/7038#issuecomment-858065977 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/7038?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+commen

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #7031: Changes in QueryInvertedSortedIndexRecommender to handle non-dimension columns for sorted and inverted index(#70

siddharthteotia commented on a change in pull request #7031: URL: https://github.com/apache/incubator-pinot/pull/7031#discussion_r648649571 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/recommender/io/InputManager.java ## @@ -237,11 +237,16 @@ privat

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #7031: Changes in QueryInvertedSortedIndexRecommender to handle non-dimension columns for sorted and inverted index(#70

siddharthteotia commented on a change in pull request #7031: URL: https://github.com/apache/incubator-pinot/pull/7031#discussion_r648628454 ## File path: pinot-controller/src/test/resources/recommenderInput/SortedInvertedIndexInputWithDateTimeColumn.json ## @@ -0,0 +1,87 @@ +{

[GitHub] [incubator-pinot] KKcorps commented on a change in pull request #7026: Add Apache Pulsar low level and high level connector

KKcorps commented on a change in pull request #7026: URL: https://github.com/apache/incubator-pinot/pull/7026#discussion_r648616146 ## File path: pinot-plugins/pinot-stream-ingestion/pinot-pulsar/src/main/java/org/apache/pinot/plugin/stream/pulsar/MessageIdStreamOffset.java ##

[GitHub] [incubator-pinot] KKcorps commented on a change in pull request #7026: Add Apache Pulsar low level and high level connector

KKcorps commented on a change in pull request #7026: URL: https://github.com/apache/incubator-pinot/pull/7026#discussion_r648616022 ## File path: pinot-plugins/pinot-stream-ingestion/pinot-pulsar/src/test/java/org/apache/pinot/plugin/stream/pulsar/PulsarStandaloneCluster.java

[GitHub] [incubator-pinot] KKcorps commented on a change in pull request #7026: Add Apache Pulsar low level and high level connector

KKcorps commented on a change in pull request #7026: URL: https://github.com/apache/incubator-pinot/pull/7026#discussion_r648614370 ## File path: pinot-plugins/pinot-stream-ingestion/pinot-pulsar/src/test/java/org/apache/pinot/plugin/stream/pulsar/PulsarStandaloneCluster.java

[GitHub] [incubator-pinot] cbalci edited a comment on pull request #7032: mark PinotFS.move as not final

cbalci edited a comment on pull request #7032: URL: https://github.com/apache/incubator-pinot/pull/7032#issuecomment-857962205 @Jackie-Jiang @chenboat ptal #7037 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [incubator-pinot] cbalci commented on pull request #7032: mark PinotFS.move as not final

cbalci commented on pull request #7032: URL: https://github.com/apache/incubator-pinot/pull/7032#issuecomment-857962205 @Jackie-Jiang @chenboat ptal https://github.com/apache/incubator-pinot/pull/7037/files -- This is an automated message from the Apache Git Service. To respond to the me

[GitHub] [incubator-pinot] johighley opened a new issue #7039: More control of realtime segments- topic partitions .

johighley opened a new issue #7039: URL: https://github.com/apache/incubator-pinot/issues/7039 We had some kind of issue with a Kafka topic such that the most recent offsets changed (to lower values). The realtime table is not processing any new messages to the topic now. The consumers s

[GitHub] [incubator-pinot] apucher opened a new pull request #7038: improve robustness of basic auth (tls) realtime integration tests

apucher opened a new pull request #7038: URL: https://github.com/apache/incubator-pinot/pull/7038 ## Description Add checked wait to BasicAuth(Tls)RealtimeIntegrationTest to reduce flakiness on slow environments. ## Upgrade Notes Does this PR prevent a zero down-time upgrade? (

[GitHub] [incubator-pinot] cbalci opened a new pull request #7037: Switch to using 'authority' instead of 'host' when building parent URI in PinotFS::move

cbalci opened a new pull request #7037: URL: https://github.com/apache/incubator-pinot/pull/7037 ## Description Switch to using 'authority' instead of 'host' when building parent URI in PinotFS:move method. This fixes a bug when a FileSystem implementation uses URI with ports. Using

[incubator-pinot] branch basic-auth-tls-realtime-integration-stability created (now 9d0143b)

This is an automated email from the ASF dual-hosted git repository. apucher pushed a change to branch basic-auth-tls-realtime-integration-stability in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. at 9d0143b improve robustness of basic auth (tls) realtime integration

[incubator-pinot] 01/01: improve robustness of basic auth (tls) realtime integration tests

This is an automated email from the ASF dual-hosted git repository. apucher pushed a commit to branch basic-auth-tls-realtime-integration-stability in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git commit 9d0143bc359660944c36c06639d135b7e94ca961 Author: Alexander Pucher Autho

[incubator-pinot] branch master updated (6aac7dd -> 176cb85)

This is an automated email from the ASF dual-hosted git repository. yupeng pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from 6aac7dd fixing pinot-hadoop and pinot-spark test (#7030) add 176cb85 mark PinotFS.move as not final (

[GitHub] [incubator-pinot] yupeng9 merged pull request #7032: mark PinotFS.move as not final

yupeng9 merged pull request #7032: URL: https://github.com/apache/incubator-pinot/pull/7032 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service

[GitHub] [incubator-pinot] yupeng9 commented on pull request #7032: mark PinotFS.move as not final

yupeng9 commented on pull request #7032: URL: https://github.com/apache/incubator-pinot/pull/7032#issuecomment-857923147 Will merge based on the conv -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #6991: Introduce in-Segment Trim for GroupBy OrderBy Query

Jackie-Jiang commented on a change in pull request #6991: URL: https://github.com/apache/incubator-pinot/pull/6991#discussion_r648527466 ## File path: pinot-core/src/test/java/org/apache/pinot/core/query/aggregation/groupby/GroupByInSegmentTrimTest.java ## @@ -0,0 +1,292 @@ +/

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #6998: Support json path expressions in query.

siddharthteotia commented on a change in pull request #6998: URL: https://github.com/apache/incubator-pinot/pull/6998#discussion_r648426337 ## File path: pinot-core/src/test/java/org/apache/pinot/core/query/optimizer/statement/JsonStatementOptimizerTest.java ## @@ -0,0 +1,201

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #6998: Support json path expressions in query.

siddharthteotia commented on a change in pull request #6998: URL: https://github.com/apache/incubator-pinot/pull/6998#discussion_r648409105 ## File path: pinot-core/src/test/java/org/apache/pinot/core/query/optimizer/statement/JsonStatementOptimizerTest.java ## @@ -0,0 +1,201

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #6998: Support json path expressions in query.

siddharthteotia commented on a change in pull request #6998: URL: https://github.com/apache/incubator-pinot/pull/6998#discussion_r648425602 ## File path: pinot-core/src/test/java/org/apache/pinot/core/query/optimizer/statement/JsonStatementOptimizerTest.java ## @@ -0,0 +1,201

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #6998: Support json path expressions in query.

siddharthteotia commented on a change in pull request #6998: URL: https://github.com/apache/incubator-pinot/pull/6998#discussion_r648423868 ## File path: pinot-core/src/main/java/org/apache/pinot/core/query/optimizer/statement/JsonStatementOptimizer.java ## @@ -0,0 +1,436 @@ +

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #6998: Support json path expressions in query.

siddharthteotia commented on a change in pull request #6998: URL: https://github.com/apache/incubator-pinot/pull/6998#discussion_r648415813 ## File path: pinot-core/src/main/java/org/apache/pinot/core/query/optimizer/statement/JsonStatementOptimizer.java ## @@ -0,0 +1,436 @@ +

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #6998: Support json path expressions in query.

siddharthteotia commented on a change in pull request #6998: URL: https://github.com/apache/incubator-pinot/pull/6998#discussion_r648422408 ## File path: pinot-core/src/test/java/org/apache/pinot/core/query/optimizer/statement/JsonStatementOptimizerTest.java ## @@ -0,0 +1,201

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #6998: Support json path expressions in query.

siddharthteotia commented on a change in pull request #6998: URL: https://github.com/apache/incubator-pinot/pull/6998#discussion_r648420886 ## File path: pinot-core/src/main/java/org/apache/pinot/core/query/optimizer/statement/JsonStatementOptimizer.java ## @@ -0,0 +1,436 @@ +

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #6998: Support json path expressions in query.

siddharthteotia commented on a change in pull request #6998: URL: https://github.com/apache/incubator-pinot/pull/6998#discussion_r648417499 ## File path: pinot-core/src/main/java/org/apache/pinot/core/query/optimizer/statement/JsonStatementOptimizer.java ## @@ -0,0 +1,436 @@ +

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #6998: Support json path expressions in query.

siddharthteotia commented on a change in pull request #6998: URL: https://github.com/apache/incubator-pinot/pull/6998#discussion_r648415813 ## File path: pinot-core/src/main/java/org/apache/pinot/core/query/optimizer/statement/JsonStatementOptimizer.java ## @@ -0,0 +1,436 @@ +

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #6998: Support json path expressions in query.

siddharthteotia commented on a change in pull request #6998: URL: https://github.com/apache/incubator-pinot/pull/6998#discussion_r648413653 ## File path: pinot-core/src/test/java/org/apache/pinot/core/query/optimizer/statement/JsonStatementOptimizerTest.java ## @@ -0,0 +1,201

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #6998: Support json path expressions in query.

siddharthteotia commented on a change in pull request #6998: URL: https://github.com/apache/incubator-pinot/pull/6998#discussion_r648413653 ## File path: pinot-core/src/test/java/org/apache/pinot/core/query/optimizer/statement/JsonStatementOptimizerTest.java ## @@ -0,0 +1,201

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #6998: Support json path expressions in query.

siddharthteotia commented on a change in pull request #6998: URL: https://github.com/apache/incubator-pinot/pull/6998#discussion_r648409105 ## File path: pinot-core/src/test/java/org/apache/pinot/core/query/optimizer/statement/JsonStatementOptimizerTest.java ## @@ -0,0 +1,201

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #6998: Support json path expressions in query.

siddharthteotia commented on a change in pull request #6998: URL: https://github.com/apache/incubator-pinot/pull/6998#discussion_r648409045 ## File path: pinot-core/src/test/java/org/apache/pinot/core/query/optimizer/statement/JsonStatementOptimizerTest.java ## @@ -0,0 +1,201

[GitHub] [incubator-pinot] codecov-commenter edited a comment on pull request #7033: Include null check for setting minion tag.

codecov-commenter edited a comment on pull request #7033: URL: https://github.com/apache/incubator-pinot/pull/7033#issuecomment-857129444 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/7033?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr

[GitHub] [incubator-pinot] KKcorps commented on pull request #7026: Add Apache Pulsar low level and high level connector

KKcorps commented on pull request #7026: URL: https://github.com/apache/incubator-pinot/pull/7026#issuecomment-857459232 @snleee @npawar Looking into the embedded test implementation for pulsar. If that doesn't work out, will switch to using mocks for unit-tests atleast. -- This is an au

[GitHub] [incubator-pinot] KKcorps commented on a change in pull request #7026: Add Apache Pulsar low level and high level connector

KKcorps commented on a change in pull request #7026: URL: https://github.com/apache/incubator-pinot/pull/7026#discussion_r648040234 ## File path: pinot-plugins/pinot-stream-ingestion/pinot-pulsar/src/main/java/org/apache/pinot/plugin/stream/pulsar/PulsarStreamLevelConsumerManager.java

[GitHub] [incubator-pinot] KKcorps commented on a change in pull request #7026: Add Apache Pulsar low level and high level connector

KKcorps commented on a change in pull request #7026: URL: https://github.com/apache/incubator-pinot/pull/7026#discussion_r648039745 ## File path: pinot-plugins/pinot-stream-ingestion/pinot-pulsar/src/main/java/org/apache/pinot/plugin/stream/pulsar/PulsarPartitionLevelConsumer.java ###

[GitHub] [incubator-pinot] KKcorps commented on a change in pull request #7026: Add Apache Pulsar low level and high level connector

KKcorps commented on a change in pull request #7026: URL: https://github.com/apache/incubator-pinot/pull/7026#discussion_r648039321 ## File path: pinot-plugins/pinot-stream-ingestion/pinot-pulsar/src/main/java/org/apache/pinot/plugin/stream/pulsar/PulsarConfig.java ## @@ -0,0