xiangfu0 commented on a change in pull request #6424: URL: https://github.com/apache/incubator-pinot/pull/6424#discussion_r648778915
########## File path: pinot-common/src/test/java/org/apache/pinot/common/utils/PinotDataTypeTest.java ########## @@ -105,6 +105,7 @@ public void testBytes() { @Test public void testTimestamp() { Timestamp timestamp = Timestamp.valueOf(LocalDateTime.now()); + timestamp.setNanos(0); Review comment: yes, java11 uses nano by default, Pinot converter doesn't keep the nano part. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org