GSharayu commented on a change in pull request #7031:
URL: https://github.com/apache/incubator-pinot/pull/7031#discussion_r648721597



##########
File path: 
pinot-controller/src/test/java/org/apache/pinot/controller/recommender/TestConfigEngine.java
##########
@@ -144,9 +156,9 @@ void testQueryInvertedSortedIndexRecommender()
             .build();
 
     Set<String> results = new HashSet<String>() {{
-      add("[[PredicateParseResult{dims{[1]}, AND, BITMAP, nESI=1.568, 
selected=0.068, nESIWithIdx=0.618}, PredicateParseResult{dims{[0]}, AND, 
BITMAP, nESI=1.568, selected=0.068, nESIWithIdx=0.767}, 
PredicateParseResult{dims{[]}, AND, NESTED, nESI=1.568, selected=0.068, 
nESIWithIdx=1.568}]]");
-      add("[[PredicateParseResult{dims{[5]}, AND, BITMAP, nESI=0.150, 
selected=0.015, nESIWithIdx=0.058}, PredicateParseResult{dims{[]}, AND, NESTED, 
nESI=0.150, selected=0.015, nESIWithIdx=0.150}], [PredicateParseResult{dims{[3, 
7]}, AND, BITMAP, nESI=12.000, selected=0.500, nESIWithIdx=4.000}, 
PredicateParseResult{dims{[]}, AND, NESTED, nESI=12.000, selected=0.500, 
nESIWithIdx=12.000}]]");
-      add("[[PredicateParseResult{dims{[0, 2]}, AND, BITMAP, nESI=7.250, 
selected=0.047, nESIWithIdx=1.122}, PredicateParseResult{dims{[]}, AND, NESTED, 
nESI=7.250, selected=0.047, nESIWithIdx=7.250}]]");
+      add("[[PredicateParseResult{dims{[3]}, AND, BITMAP, nESI=1.645, 
selected=0.034, nESIWithIdx=0.695}, PredicateParseResult{dims{[2]}, AND, 
BITMAP, nESI=1.645, selected=0.034, nESIWithIdx=0.835}, 
PredicateParseResult{dims{[]}, AND, NESTED, nESI=1.645, selected=0.034, 
nESIWithIdx=1.645}]]");

Review comment:
       These values will be updated because of changes to how Atomic number to 
column map generation is refactored in InputManager




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to