siddharthteotia commented on a change in pull request #7031:
URL: https://github.com/apache/incubator-pinot/pull/7031#discussion_r648668898
##########
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/recommender/io/InputManager.java
##########
@@ -237,11 +237,16 @@ private void reorderDimsAndBuildMap()
_colNameToIntMap = new HashMap<>();
_dimNamesInvertedSortedIndexApplicable = new HashSet<>(_dimNames);
+ _dimNamesInvertedSortedIndexApplicable.addAll(_metricNames);
Review comment:
Also suggest renaming this to
`_columnNamesInvertedSortedIndexApplicable` since this PR removes the
restriction that it has to be a dimension
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
