siddharthteotia commented on a change in pull request #7031:
URL: https://github.com/apache/incubator-pinot/pull/7031#discussion_r648672633
##########
File path:
pinot-controller/src/test/java/org/apache/pinot/controller/recommender/TestConfigEngine.java
##########
@@ -125,6 +125,18 @@ void testInvertedSortedIndexJointRule()
assertEquals(output.getIndexConfig().getSortedColumn(), "c");
}
+ @Test
Review comment:
There is an existing test `testInvertedSortedIndexJointRule()`
Between that and this newly added test, can we ensure that recommendation is
covered for dimensions, metrics, timeSpec (deprecated) and dateTimes. I think
metric is not covered. Rest seems to be covered ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
