[GitHub] [incubator-pinot] GSharayu commented on a change in pull request #7031: Changes in QueryInvertedSortedIndexRecommender to handle non-dimension columns for sorted and inverted index(#7018)

[GitBox]

GSharayu commented on a change in pull request #7031:
URL: https://github.com/apache/incubator-pinot/pull/7031#discussion_r648681479



##########
File path: 
pinot-controller/src/main/java/org/apache/pinot/controller/recommender/io/InputManager.java
##########
@@ -237,11 +237,16 @@ private void reorderDimsAndBuildMap()
     _colNameToIntMap = new HashMap<>();
 
     _dimNamesInvertedSortedIndexApplicable = new HashSet<>(_dimNames);
+    _dimNamesInvertedSortedIndexApplicable.addAll(_metricNames);
+    _dimNamesInvertedSortedIndexApplicable.addAll(_dateTimeNames);
+
     _dimNamesInvertedSortedIndexApplicable.remove(sortedColumn);
     _dimNamesInvertedSortedIndexApplicable.removeAll(invertedIndexColumns);
     _dimNamesInvertedSortedIndexApplicable.removeAll(noDictionaryColumns);
 
     HashSet<String> dimNamesInveredSortedIndexNotApplicable = new 
HashSet<>(_dimNames);
+    dimNamesInveredSortedIndexNotApplicable.addAll(_metricNames);

Review comment:
       right, we can write it in clean way

##########
File path: 
pinot-controller/src/main/java/org/apache/pinot/controller/recommender/io/InputManager.java
##########
@@ -259,14 +264,6 @@ private void reorderDimsAndBuildMap()
     LOGGER.debug("_dimNames{}", _dimNames);
     LOGGER.debug("_metricNames{}", _metricNames);
     LOGGER.debug("_dateTimeNames{}", _dateTimeNames);
-    _metricNames.forEach(name -> {

Review comment:
       yes




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org