[GitHub] [incubator-pinot] troywinter opened a new issue #6981: Support groovy UDF transform in post-aggregation

2021-05-25 Thread GitBox
troywinter opened a new issue #6981: URL: https://github.com/apache/incubator-pinot/issues/6981 Currently only scalar UDF is supported for post-aggregation transform, when user want to transform an aggregation result, user need to create a scalar UDF for every case. Pinot need to su

[GitHub] [incubator-pinot] chenboat commented on issue #6639: Support Pinot as a DataSource in Grafana plugin

2021-05-25 Thread GitBox
chenboat commented on issue #6639: URL: https://github.com/apache/incubator-pinot/issues/6639#issuecomment-848507022 @cbalci ^^ I think Caner has done something similar but he uses Presto interface with Grafana. -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #6973: Implement PassThroughTransformOperator to optimize select queries(#6972)

2021-05-25 Thread GitBox
Jackie-Jiang commented on a change in pull request #6973: URL: https://github.com/apache/incubator-pinot/pull/6973#discussion_r639430374 ## File path: pinot-core/src/main/java/org/apache/pinot/core/operator/transform/PassThroughTransformOperator.java ## @@ -0,0 +1,52 @@ +/** +

[GitHub] [incubator-pinot] codecov-commenter commented on pull request #6980: Unify the minion plug-in package regex path

2021-05-25 Thread GitBox
codecov-commenter commented on pull request #6980: URL: https://github.com/apache/incubator-pinot/pull/6980#issuecomment-848472522 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6980?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+commen

[incubator-pinot] branch master updated: Fix deep store directory structure (#6976)

2021-05-25 Thread tingchen
This is an automated email from the ASF dual-hosted git repository. tingchen pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/master by this push: new b8a92c4 Fix deep store directory str

[GitHub] [incubator-pinot] chenboat merged pull request #6976: Fix deep store directory structure

2021-05-25 Thread GitBox
chenboat merged pull request #6976: URL: https://github.com/apache/incubator-pinot/pull/6976 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this servic

[GitHub] [incubator-pinot] Jackie-Jiang commented on pull request #6980: Unify the minion plug-in package regex path

2021-05-25 Thread GitBox
Jackie-Jiang commented on pull request #6980: URL: https://github.com/apache/incubator-pinot/pull/6980#issuecomment-848451168 @jackjlli Please review this PR. It fixes the regex path for `MinionEventObserverFactory`, which is missed in #6618 -- This is an automated message from the Apach

[GitHub] [incubator-pinot] Jackie-Jiang opened a new pull request #6980: Unify the minion plug-in package regex path

2021-05-25 Thread GitBox
Jackie-Jiang opened a new pull request #6980: URL: https://github.com/apache/incubator-pinot/pull/6980 ## Description Unify minion pluggable class (`PinotTaskGenerator`, `PinotTaskExecutorFactory`, `MinionEventObserverFactory`) package regex path to `org.apache.pinot.*.plugin.minion.tas

[GitHub] [incubator-pinot] codecov-commenter edited a comment on pull request #6976: Fix deep store directory structure

2021-05-25 Thread GitBox
codecov-commenter edited a comment on pull request #6976: URL: https://github.com/apache/incubator-pinot/pull/6976#issuecomment-848375181 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6976?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr

[incubator-pinot] branch master updated: Support null value fields in generic row ser/de (#6968)

2021-05-25 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/master by this push: new c76ce2a Support null value fields in g

[GitHub] [incubator-pinot] Jackie-Jiang merged pull request #6968: Support null value fields in generic row ser/de

2021-05-25 Thread GitBox
Jackie-Jiang merged pull request #6968: URL: https://github.com/apache/incubator-pinot/pull/6968 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this se

[GitHub] [incubator-pinot] codecov-commenter edited a comment on pull request #6976: Fix deep store directory structure

2021-05-25 Thread GitBox
codecov-commenter edited a comment on pull request #6976: URL: https://github.com/apache/incubator-pinot/pull/6976#issuecomment-848375181 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6976?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr

[GitHub] [incubator-pinot] codecov-commenter edited a comment on pull request #6968: Support null value fields in generic row ser/de

2021-05-25 Thread GitBox
codecov-commenter edited a comment on pull request #6968: URL: https://github.com/apache/incubator-pinot/pull/6968#issuecomment-847623166 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6968?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr

[GitHub] [incubator-pinot] chenboat commented on a change in pull request #6976: Fix deep store directory structure

2021-05-25 Thread GitBox
chenboat commented on a change in pull request #6976: URL: https://github.com/apache/incubator-pinot/pull/6976#discussion_r639353978 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotSegmentUploadDownloadRestletResource.java ## @@ -386

[GitHub] [incubator-pinot] codecov-commenter edited a comment on pull request #6977: Enhance debug endpoint for table debugging.

2021-05-25 Thread GitBox
codecov-commenter edited a comment on pull request #6977: URL: https://github.com/apache/incubator-pinot/pull/6977#issuecomment-848396506 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6977?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr

[GitHub] [incubator-pinot] sajjad-moradi commented on a change in pull request #6976: Fix deep store directory structure

2021-05-25 Thread GitBox
sajjad-moradi commented on a change in pull request #6976: URL: https://github.com/apache/incubator-pinot/pull/6976#discussion_r639348521 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotSegmentUploadDownloadRestletResource.java ## @@

[GitHub] [incubator-pinot] sajjad-moradi commented on a change in pull request #6976: Fix deep store directory structure

2021-05-25 Thread GitBox
sajjad-moradi commented on a change in pull request #6976: URL: https://github.com/apache/incubator-pinot/pull/6976#discussion_r639350491 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotSegmentUploadDownloadRestletResource.java ## @@

[GitHub] [incubator-pinot] chenboat commented on a change in pull request #6976: Fix deep store directory structure

2021-05-25 Thread GitBox
chenboat commented on a change in pull request #6976: URL: https://github.com/apache/incubator-pinot/pull/6976#discussion_r639348735 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotSegmentUploadDownloadRestletResource.java ## @@ -386

[GitHub] [incubator-pinot] sajjad-moradi commented on a change in pull request #6976: Fix deep store directory structure

2021-05-25 Thread GitBox
sajjad-moradi commented on a change in pull request #6976: URL: https://github.com/apache/incubator-pinot/pull/6976#discussion_r639348521 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotSegmentUploadDownloadRestletResource.java ## @@

[GitHub] [incubator-pinot] chenboat commented on a change in pull request #6976: Fix deep store directory structure

2021-05-25 Thread GitBox
chenboat commented on a change in pull request #6976: URL: https://github.com/apache/incubator-pinot/pull/6976#discussion_r639348510 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotSegmentUploadDownloadRestletResource.java ## @@ -386

[GitHub] [incubator-pinot] codecov-commenter edited a comment on pull request #6976: Fix deep store directory structure

2021-05-25 Thread GitBox
codecov-commenter edited a comment on pull request #6976: URL: https://github.com/apache/incubator-pinot/pull/6976#issuecomment-848375181 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6976?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr

[GitHub] [incubator-pinot] codecov-commenter commented on pull request #6977: Enhance debug endpoint for table debugging.

2021-05-25 Thread GitBox
codecov-commenter commented on pull request #6977: URL: https://github.com/apache/incubator-pinot/pull/6977#issuecomment-848396506 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6977?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+commen

[GitHub] [incubator-pinot] codecov-commenter edited a comment on pull request #6968: Support null value fields in generic row ser/de

2021-05-25 Thread GitBox
codecov-commenter edited a comment on pull request #6968: URL: https://github.com/apache/incubator-pinot/pull/6968#issuecomment-847623166 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6968?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr

[GitHub] [incubator-pinot] snleee commented on a change in pull request #6976: Fix deep store directory structure

2021-05-25 Thread GitBox
snleee commented on a change in pull request #6976: URL: https://github.com/apache/incubator-pinot/pull/6976#discussion_r639344529 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotSegmentUploadDownloadRestletResource.java ## @@ -386,1

[GitHub] [incubator-pinot] snleee commented on issue #6979: Time partition support for SegmentProcessorFramework

2021-05-25 Thread GitBox
snleee commented on issue #6979: URL: https://github.com/apache/incubator-pinot/issues/6979#issuecomment-848387224 1. `SegmentProcessorFramework` does not need to know about the time buckets or start time. The only input config that we need is `timeGranularity (e.g. daily, monthly...etc)`

[GitHub] [incubator-pinot] jtao15 opened a new issue #6979: Time partition support for SegmentProcessorFramework

2021-05-25 Thread GitBox
jtao15 opened a new issue #6979: URL: https://github.com/apache/incubator-pinot/issues/6979 Result segments need to be time aligned for some minion tasks (e.g. backfill support for merge/rollup), it will be good if we can add time partition support based on the time window/bucket. T

[GitHub] [incubator-pinot] sajjad-moradi commented on a change in pull request #6976: Fix deep store directory structure

2021-05-25 Thread GitBox
sajjad-moradi commented on a change in pull request #6976: URL: https://github.com/apache/incubator-pinot/pull/6976#discussion_r639334269 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotSegmentUploadDownloadRestletResource.java ## @@

[GitHub] [incubator-pinot] siddharthteotia commented on issue #6978: Support SQL EXPLAIN PLAN FOR

2021-05-25 Thread GitBox
siddharthteotia commented on issue #6978: URL: https://github.com/apache/incubator-pinot/issues/6978#issuecomment-848380852 We have started working on this. Will be sharing design/details etc with the community. -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [incubator-pinot] siddharthteotia opened a new issue #6978: Support SQL EXPLAIN PLAN FOR

2021-05-25 Thread GitBox
siddharthteotia opened a new issue #6978: URL: https://github.com/apache/incubator-pinot/issues/6978 **Background** Standard SQL supports EXPLAIN plan functionality. The output of EXPLAIN is the physical execution plan (in a tree format) giving overview of the physical relational op

[GitHub] [incubator-pinot] jackjlli commented on a change in pull request #6976: Fix deep store directory structure

2021-05-25 Thread GitBox
jackjlli commented on a change in pull request #6976: URL: https://github.com/apache/incubator-pinot/pull/6976#discussion_r639329944 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotSegmentUploadDownloadRestletResource.java ## @@ -292

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #6976: Fix deep store directory structure

2021-05-25 Thread GitBox
mcvsubbu commented on a change in pull request #6976: URL: https://github.com/apache/incubator-pinot/pull/6976#discussion_r639328469 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotSegmentUploadDownloadRestletResource.java ## @@ -292

[GitHub] [incubator-pinot] codecov-commenter commented on pull request #6976: Fix deep store directory structure

2021-05-25 Thread GitBox
codecov-commenter commented on pull request #6976: URL: https://github.com/apache/incubator-pinot/pull/6976#issuecomment-848375181 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6976?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+commen

[GitHub] [incubator-pinot] sajjad-moradi commented on a change in pull request #6976: Fix deep store directory structure

2021-05-25 Thread GitBox
sajjad-moradi commented on a change in pull request #6976: URL: https://github.com/apache/incubator-pinot/pull/6976#discussion_r639324094 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotSegmentUploadDownloadRestletResource.java ## @@

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #6976: Fix deep store directory structure

2021-05-25 Thread GitBox
mcvsubbu commented on a change in pull request #6976: URL: https://github.com/apache/incubator-pinot/pull/6976#discussion_r639319875 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotSegmentUploadDownloadRestletResource.java ## @@ -292

[GitHub] [incubator-pinot] mayankshriv opened a new pull request #6977: Enhance debug endpoint for table debugging.

2021-05-25 Thread GitBox
mayankshriv opened a new pull request #6977: URL: https://github.com/apache/incubator-pinot/pull/6977 Enhanced the existing endpoint for table deugging on controller as well as server to include segment state transition and consumption related errors and information. Note: This i

[GitHub] [incubator-pinot] sajjad-moradi opened a new pull request #6976: Fix deep store directory structure

2021-05-25 Thread GitBox
sajjad-moradi opened a new pull request #6976: URL: https://github.com/apache/incubator-pinot/pull/6976 ## Description This PR is the fix for the issue described in #6966. Basically it reverts the changes recently made to deep store directory structure. ## Testing Done Deployed loc

[GitHub] [incubator-pinot] liuchang0520 commented on a change in pull request #6778: upload missing LLC segment to segment store by controller periodic task

2021-05-25 Thread GitBox
liuchang0520 commented on a change in pull request #6778: URL: https://github.com/apache/incubator-pinot/pull/6778#discussion_r639302238 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java ## @@ -603,

[GitHub] [incubator-pinot] codecov-commenter edited a comment on pull request #6778: upload missing LLC segment to segment store by controller periodic task

2021-05-25 Thread GitBox
codecov-commenter edited a comment on pull request #6778: URL: https://github.com/apache/incubator-pinot/pull/6778#issuecomment-823815012 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6778?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #6969: Fix partial comparison for realtime table and allow keep cluster on failure

2021-05-25 Thread GitBox
mcvsubbu commented on a change in pull request #6969: URL: https://github.com/apache/incubator-pinot/pull/6969#discussion_r639012635 ## File path: compatibility-verifier/README.md ## @@ -32,7 +32,13 @@ dir and output the path, which can be used in step 2. ### Step 2: run com

[GitHub] [incubator-pinot] codecov-commenter edited a comment on pull request #6778: upload missing LLC segment to segment store by controller periodic task

2021-05-25 Thread GitBox
codecov-commenter edited a comment on pull request #6778: URL: https://github.com/apache/incubator-pinot/pull/6778#issuecomment-823815012 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6778?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr

[GitHub] [incubator-pinot] liuchang0520 commented on a change in pull request #6778: upload missing LLC segment to segment store by controller periodic task

2021-05-25 Thread GitBox
liuchang0520 commented on a change in pull request #6778: URL: https://github.com/apache/incubator-pinot/pull/6778#discussion_r639256711 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java ## @@ -1214

[GitHub] [incubator-pinot] siddharthteotia closed issue #6972: Implement PassThroughTransformOperator to optimize select queries

2021-05-25 Thread GitBox
siddharthteotia closed issue #6972: URL: https://github.com/apache/incubator-pinot/issues/6972 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this serv

[GitHub] [incubator-pinot] siddharthteotia commented on issue #6972: Implement PassThroughTransformOperator to optimize select queries

2021-05-25 Thread GitBox
siddharthteotia commented on issue #6972: URL: https://github.com/apache/incubator-pinot/issues/6972#issuecomment-848317500 Resolved by PR https://github.com/apache/incubator-pinot/pull/6973 -- This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [incubator-pinot] chenboat commented on pull request #6974: Revert deep store directory structure changes after introducing upsert

2021-05-25 Thread GitBox
chenboat commented on pull request #6974: URL: https://github.com/apache/incubator-pinot/pull/6974#issuecomment-848315156 Is this PR intended to be merged to Master? @sajjad-moradi ? Just saw @snleee merged this PR to another branch. How about filing a PR to fix forward in the maste

[GitHub] [incubator-pinot] codecov-commenter commented on pull request #6975: Merge rollup executor enhancement

2021-05-25 Thread GitBox
codecov-commenter commented on pull request #6975: URL: https://github.com/apache/incubator-pinot/pull/6975#issuecomment-848278058 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6975?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+commen

[GitHub] [incubator-pinot] npawar commented on a change in pull request #6968: Support null value fields in generic row ser/de

2021-05-25 Thread GitBox
npawar commented on a change in pull request #6968: URL: https://github.com/apache/incubator-pinot/pull/6968#discussion_r639170675 ## File path: pinot-core/src/main/java/org/apache/pinot/core/segment/processing/serde/GenericRowSerializer.java ## @@ -0,0 +1,228 @@ +/** + * Lice

[incubator-pinot] branch master updated (3c7dfcd -> 0185482)

2021-05-25 Thread siddteotia
This is an automated email from the ASF dual-hosted git repository. siddteotia pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from 3c7dfcd Optimize TIME_CONVERT/DATE_TIME_CONVERT predicates (#6957) add 0185482 Implement PassThro

[GitHub] [incubator-pinot] siddharthteotia merged pull request #6973: Implement PassThroughTransformOperator to optimize select queries(#6972)

2021-05-25 Thread GitBox
siddharthteotia merged pull request #6973: URL: https://github.com/apache/incubator-pinot/pull/6973 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[GitHub] [incubator-pinot] Jackie-Jiang commented on pull request #6968: Support null value fields in generic row ser/de

2021-05-25 Thread GitBox
Jackie-Jiang commented on pull request #6968: URL: https://github.com/apache/incubator-pinot/pull/6968#issuecomment-848215710 > > > For null value support, does this still require enabling null via config? > > > > > > Yes. The `nullValueFields` are set in `GenericRow` only when t

[incubator-pinot] branch deep.store.dir.structure updated: Revert deep store directory structure changes after introducing upsert (#6974)

2021-05-25 Thread snlee
This is an automated email from the ASF dual-hosted git repository. snlee pushed a commit to branch deep.store.dir.structure in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/deep.store.dir.structure by this push: new 48d

[GitHub] [incubator-pinot] snleee merged pull request #6974: Revert deep store directory structure changes after introducing upsert

2021-05-25 Thread GitBox
snleee merged pull request #6974: URL: https://github.com/apache/incubator-pinot/pull/6974 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [incubator-pinot] yupeng9 commented on pull request #6968: Support null value fields in generic row ser/de

2021-05-25 Thread GitBox
yupeng9 commented on pull request #6968: URL: https://github.com/apache/incubator-pinot/pull/6968#issuecomment-848189794 > > For null value support, does this still require enabling null via config? > > Yes. The `nullValueFields` are set in `GenericRow` only when the null value is en

[GitHub] [incubator-pinot] jtao15 opened a new pull request #6975: Merge rollup executor enhancement

2021-05-25 Thread GitBox
jtao15 opened a new pull request #6975: URL: https://github.com/apache/incubator-pinot/pull/6975 Part of #2715, depends on #6932. Merge/Rollup task executor enhancement: 1. Wire SegmentProcessorFramework 2. Wire segment replacement protocol 3. Write bucket granul

[GitHub] [incubator-pinot] Jackie-Jiang commented on pull request #6968: Support null value fields in generic row ser/de

2021-05-25 Thread GitBox
Jackie-Jiang commented on pull request #6968: URL: https://github.com/apache/incubator-pinot/pull/6968#issuecomment-848178745 > For null value support, does this still require enabling null via config? Yes. The `nullValueFields` are set in `GenericRow` only when the null value is ena

[GitHub] [incubator-pinot] codecov-commenter commented on pull request #6973: Implement PassThroughTransformOperator to optimize select queries(#6972)

2021-05-25 Thread GitBox
codecov-commenter commented on pull request #6973: URL: https://github.com/apache/incubator-pinot/pull/6973#issuecomment-848129143 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6973?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+commen

[GitHub] [incubator-pinot] snleee commented on pull request #6974: Revert deep store directory structure changes after introducing upsert

2021-05-25 Thread GitBox
snleee commented on pull request #6974: URL: https://github.com/apache/incubator-pinot/pull/6974#issuecomment-848115394 Have we decided to roll-back the entire commit? I thought we are going to fix forward by replacing the part that got inadvertently swicthed to `rawTableName` to `tableNam

[GitHub] [incubator-pinot] sajjad-moradi opened a new pull request #6974: Revert deep store directory structure changes after introducing upsert

2021-05-25 Thread GitBox
sajjad-moradi opened a new pull request #6974: URL: https://github.com/apache/incubator-pinot/pull/6974 ## Description This PR is the fix for the issue described in #6966. Basically it reverts the changes recently made to deep store directory structure. ## Testing Done Deployed loc

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #6969: Fix partial comparison for realtime table and allow keep cluster on failure

2021-05-25 Thread GitBox
siddharthteotia commented on a change in pull request #6969: URL: https://github.com/apache/incubator-pinot/pull/6969#discussion_r639071638 ## File path: pinot-integration-tests/src/test/java/org/apache/pinot/compat/tests/SqlResultComparator.java ## @@ -113,9 +126,147 @@ publi

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #6969: Fix partial comparison for realtime table and allow keep cluster on failure

2021-05-25 Thread GitBox
siddharthteotia commented on a change in pull request #6969: URL: https://github.com/apache/incubator-pinot/pull/6969#discussion_r639070818 ## File path: pinot-integration-tests/src/test/java/org/apache/pinot/compat/tests/SqlResultComparator.java ## @@ -113,9 +126,147 @@ publi

[incubator-pinot] branch deep.store.dir.structure updated (8878df5 -> fe10fc1)

2021-05-25 Thread jlli
This is an automated email from the ASF dual-hosted git repository. jlli pushed a change to branch deep.store.dir.structure in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. omit 8878df5 Update LICENSE & NOTICE (#6944) omit 9adbe55 Include complex-type-handling qui

[GitHub] [incubator-pinot] siddharthteotia commented on pull request #6973: Implement PassThroughTransformOperator to optimize select queries(#6972)

2021-05-25 Thread GitBox
siddharthteotia commented on pull request #6973: URL: https://github.com/apache/incubator-pinot/pull/6973#issuecomment-848087338 @GSharayu , you may want to update the PR description to state if existing query tests cover both scenarios and may be point to the test -- This is an automate

[GitHub] [incubator-pinot] GSharayu commented on a change in pull request #6973: Implement PassThroughTransformOperator to optimize select queries(#6972)

2021-05-25 Thread GitBox
GSharayu commented on a change in pull request #6973: URL: https://github.com/apache/incubator-pinot/pull/6973#discussion_r639038817 ## File path: pinot-core/src/main/java/org/apache/pinot/core/plan/TransformPlanNode.java ## @@ -33,13 +34,15 @@ public class TransformPlanNode

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #6973: Implement PassThroughTransformOperator to optimize select queries(#6972)

2021-05-25 Thread GitBox
siddharthteotia commented on a change in pull request #6973: URL: https://github.com/apache/incubator-pinot/pull/6973#discussion_r639032664 ## File path: pinot-core/src/main/java/org/apache/pinot/core/operator/transform/PassThroughTransformOperator.java ## @@ -0,0 +1,51 @@ +/*

[GitHub] [incubator-pinot] GSharayu opened a new pull request #6973: Implement PassThroughTransformOperator to optimize select queries(#6972)

2021-05-25 Thread GitBox
GSharayu opened a new pull request #6973: URL: https://github.com/apache/incubator-pinot/pull/6973 For general select queries e.g SELECT * FROM Foo . LIMIT N e.g SELECT col1, col2 . FROM Foo LIMIT N the columns are identifier expressions and not some transfo

[incubator-pinot] branch master updated: Optimize TIME_CONVERT/DATE_TIME_CONVERT predicates (#6957)

2021-05-25 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/master by this push: new 3c7dfcd Optimize TIME_CONVERT/DATE_TIM

[GitHub] [incubator-pinot] Jackie-Jiang merged pull request #6957: Optimize TIME_CONVERT/DATE_TIME_CONVERT predicates

2021-05-25 Thread GitBox
Jackie-Jiang merged pull request #6957: URL: https://github.com/apache/incubator-pinot/pull/6957 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this se

[GitHub] [incubator-pinot] GSharayu opened a new issue #6972: Implement PassThroughTransformOperator to optimize select queries

2021-05-25 Thread GitBox
GSharayu opened a new issue #6972: URL: https://github.com/apache/incubator-pinot/issues/6972 For general select queries e.g SELECT * FROM Foo . LIMIT N e.g SELECT col1, col2 . FROM Foo LIMIT N the columns are identifier expressions and not some transform

[GitHub] [incubator-pinot] daniellavoie opened a new issue #6971: User provided table configuration can crash Servers

2021-05-25 Thread GitBox
daniellavoie opened a new issue #6971: URL: https://github.com/apache/incubator-pinot/issues/6971 # Context Been brainstorming with @mayankshriv about my observations regarding Pinot stability. From running clusters in production and troubleshooting people in our community Slack, my

[GitHub] [incubator-pinot] Jackie-Jiang closed issue #5704: Support toWeek/toMonth/toYear in datetimeConvertUdf

2021-05-25 Thread GitBox
Jackie-Jiang closed issue #5704: URL: https://github.com/apache/incubator-pinot/issues/5704 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service

[GitHub] [incubator-pinot] yupeng9 commented on pull request #6968: Support null value fields in generic row ser/de

2021-05-25 Thread GitBox
yupeng9 commented on pull request #6968: URL: https://github.com/apache/incubator-pinot/pull/6968#issuecomment-848040904 For null value support, does this still require enabling null via config? -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [incubator-pinot] sajjad-moradi commented on issue #6966: Issues with recent changes on upload segment endpoint

2021-05-25 Thread GitBox
sajjad-moradi commented on issue #6966: URL: https://github.com/apache/incubator-pinot/issues/6966#issuecomment-848013436 AFAIK SegmentDeletionManager is used for deleting active segments that need to be deleted because of their retention time. Other than retention issue, there's another

[GitHub] [incubator-pinot] daniellavoie commented on a change in pull request #6839: Update helm chart - Include securityContext, gracePeriod and remove duplicates in helm

2021-05-25 Thread GitBox
daniellavoie commented on a change in pull request #6839: URL: https://github.com/apache/incubator-pinot/pull/6839#discussion_r638790210 ## File path: kubernetes/helm/pinot/templates/broker/service.yaml ## @@ -21,18 +21,18 @@ apiVersion: v1 kind: Service metadata: name: {{

[GitHub] [incubator-pinot] syed72 opened a new issue #6970: Increase the latency of a query which has TIME as sorted column when ORDER BY TIME DESC is applied

2021-05-25 Thread GitBox
syed72 opened a new issue #6970: URL: https://github.com/apache/incubator-pinot/issues/6970 Hi, There is usecase, where need to Increase the latency of a query which has ATIME as sorted column in a pinot table when ORDER BY ATIME DESC limit 100 is applied. I've a select query wh

[GitHub] [incubator-pinot] codecov-commenter commented on pull request #6969: Fix partial comparison for realtime table and allow keep cluster on failure

2021-05-25 Thread GitBox
codecov-commenter commented on pull request #6969: URL: https://github.com/apache/incubator-pinot/pull/6969#issuecomment-847666543 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6969?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+commen

[GitHub] [incubator-pinot] codecov-commenter commented on pull request #6968: Support null value fields in generic row ser/de

2021-05-25 Thread GitBox
codecov-commenter commented on pull request #6968: URL: https://github.com/apache/incubator-pinot/pull/6968#issuecomment-847623166 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6968?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+commen