mcvsubbu commented on a change in pull request #6976:
URL: https://github.com/apache/incubator-pinot/pull/6976#discussion_r639319875
##########
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotSegmentUploadDownloadRestletResource.java
##########
@@ -292,12 +292,12 @@ private SuccessResponse uploadSegment(@Nullable String
tableName, TableType tabl
tableNameWithType);
zkDownloadUri = downloadUri;
} else {
- zkDownloadUri = getZkDownloadURIForSegmentUpload(tableNameWithType,
segmentName);
+ zkDownloadUri = getZkDownloadURIForSegmentUpload(tableName,
segmentName);
}
// Zk operations
- completeZkOperations(enableParallelPushProtection, headers,
finalSegmentFile, tableNameWithType, segmentMetadata,
- segmentName, zkDownloadUri, moveSegmentToFinalLocation,
crypterClassName);
+ completeZkOperations(enableParallelPushProtection, headers,
finalSegmentFile, tableName, tableNameWithType,
Review comment:
Passing both `tableNameWithType` and `tableName` seems redundant. If we
pass `tableNameWithType`, we should be able to derive `tableName` inside
`completeZkOperations()` method, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
