chenboat commented on a change in pull request #6976:
URL: https://github.com/apache/incubator-pinot/pull/6976#discussion_r639348735
##########
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotSegmentUploadDownloadRestletResource.java
##########
@@ -386,11 +386,11 @@ private SegmentMetadata getSegmentMetadata(File
tempDecryptedFile, File tempSegm
}
private void completeZkOperations(boolean enableParallelPushProtection,
HttpHeaders headers, File uploadedSegmentFile,
- String tableNameWithType, SegmentMetadata segmentMetadata, String
segmentName, String zkDownloadURI,
- boolean moveSegmentToFinalLocation, String crypter)
+ String rawTableName, String tableNameWithType, SegmentMetadata
segmentMetadata, String segmentName,
Review comment:
+1, why we need an extra variable here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
